Re: [PATCH v14 00/15] phy: Add support for Lynx 10G SerDes

[Vladimir Oltean <vladimir.oltean@nxp.com>]

Hello,

On Thu, 13 Apr 2023 12:05:52 -0400, Sean Anderson wrote:
> This series is ready for review by the phy maintainers. I have addressed
> all known feedback and there are no outstanding issues.
> 
> Major reconfiguration of baud rate (e.g. 1G->10G) does not work.
> 
> There are several stand-alone commits in this series. Please feel free
> to pick them as appropriate. In particular, commits 1, 3, 4, 12, 13, and
> 14 are all good candidates for picking.
> 
> - Although this is untested, it should support 2.5G SGMII as well as
>   1000BASE-KX. The latter needs MAC and PCS support, but the former
>   should work out of the box.
> - It allows for clock configurations not supported by the RCW. This is
>   very useful if you want to use e.g. SRDS_PRTCL_S1=0x3333 and =0x1133
>   on the same board. This is because the former setting will use PLL1
>   as the 1G reference, but the latter will use PLL1 as the 10G
>   reference. Because we can reconfigure the PLLs, it is possible to
>   always use PLL1 as the 1G reference.

I am an engineer working for NXP and I have access to the majority of
hardware that includes the Lynx 10G SERDES, as well as to block guides
that are not visible to customers, and to people from the hardware
design and validation teams.

I have an interest in adding a driver for this SERDES to support dynamic
Ethernet protocol reconfiguration, and perhaps the internal PHY for
copper backplane modes (1000Base-KX, 10GBase-KR) and its link training
procedure - although the latter will need more work.

I would like to thank you for starting the effort, but please, stop
submitting code for modes that are untested, and do not submit features
that do not work. If you do not have the time to fix up the loose ends
for this patch submission now, you won't have the time to debug
regressions on boards you might not even have access to, which worked
fine previously due to the static RCW/PBL configuration.

I have downloaded your patches, and although I have objections to some
of them already, I will be in the process of evaluating, testing,
changing them, for the coming weeks, perhaps even more. Please consider
this a NACK for the current patch set due to the SERDES related material,
although the unrelated patches (like "dt-bindings: Convert gpio-mmio to
yaml") can and should have been submitted separately, so they can be
analyzed by their respective maintainers based on their own merit and
not as part of an overall problematic set.

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy