From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA549C77B7C for ; Thu, 4 May 2023 09:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SM7fnv7x6g/Io8lm3CVerzib/BrRFjSQ3w+AMRDI99g=; b=4jIHWYowmzAVTd1nKC2VPG+LIT vt6totWQwBGkMVwPKdGhGl+FB9Bv/5ORCR3TiH+sRQylzSndE1HyjkutTDnnOq5hMDxAQ0PL1tTEN ebyN7gQGioXTbpIRttuXC8AiYLsXpqaaGz5lHFdBVaPVe6dXo4wcragmkxhuhPOLZsViD9XbPNsjV DZVx9TPTJDYQXgI1LWsfxATUMeUFNiTwFZ3G4G5SnMreh53UuD69ke2MeYywC5WNdZD8q9wxElAlW ritFnUPMmQbqNhcY7FumMUTQzUJKQLMUTxToB/om7+0OapAFMwFkUGCm8STMJv+ZXEu7HQ/9vIMIA ov3lu6cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puVid-007MQv-1D; Thu, 04 May 2023 09:57:47 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puViZ-007MPD-2A; Thu, 04 May 2023 09:57:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1683194263; x=1714730263; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=skX0KctM5NyGzhY5XFNMWtwT33oUgFCc7oCsUf4NI6Q=; b=hNdk/pyR6r/PKIAoAkY55Puwy++7w+7BLHTrNQjUBAJ9r7jpS6/7CAE/ 1VcsAAdbtLhtVtRsPkzUDqMNCf1cbcKMgGnWSP2Ell/DEb4xc0d5EK3m6 /oySOEy5DvTLhvGWA2ejPjjER6+CrCQ4rDrenQ2paOYYoSe+yWhgRjQoJ GauC4/bX0/vGDF3SKKQjf8u9daV34l+DD57HyFbgOp0s8rriJlmROLYUw mhlRIA8RoZI0tXXCwjkXpuccTAa7zE1DmXCbk8TCRJf7PU0slVuiOXg8j 6263xUxl+8bY+EBwdVAqfxaIgeiC06mdUZwz3OsJAhndeWY+K/q+CYGxa Q==; X-IronPort-AV: E=Sophos;i="5.99,249,1677567600"; d="asc'?scan'208";a="213646175" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 May 2023 02:57:38 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 4 May 2023 02:57:33 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 4 May 2023 02:57:31 -0700 Date: Thu, 4 May 2023 10:57:12 +0100 From: Conor Dooley To: Changhuang Liang CC: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Message-ID: <20230504-worshiper-ongoing-5581e1f2c2c4@wendy> References: <20230425-commotion-prewashed-876247bed4ab@spud> <0b0f9187-ad6b-a1d9-6ec4-beb8989ca731@starfivetech.com> <3ed72340-accc-4ad1-098f-4a2eb6448828@linaro.org> <482e812a-05dd-105c-189c-e926b4be9d28@starfivetech.com> <089e24d1-588a-4a56-f00b-0b35d1d99295@linaro.org> <1ac26c1a-1726-515d-6598-849a07ed0b86@linaro.org> <5adda0ad-965c-fbf0-878c-9d41d28b5c39@starfivetech.com> <86693969-59bf-5bcc-42a3-b6e94a0d6f3e@linaro.org> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_025743_959492_28805295 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5509737560859328852==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============5509737560859328852== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+N3Mbg4s7LcQH++0" Content-Disposition: inline --+N3Mbg4s7LcQH++0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 04, 2023 at 05:48:20PM +0800, Changhuang Liang wrote: > On 2023/5/4 17:36, Krzysztof Kozlowski wrote: > > On 04/05/2023 10:43, Changhuang Liang wrote: > >> On 2023/5/4 15:26, Krzysztof Kozlowski wrote: > >>>> aon_syscon: syscon@17010000 { > >>>> compatible =3D "starfive,jh7110-aon-syscon", "syscon", "starfive,jh= 7110-aon-pmu"; > >>>> reg =3D <0x0 0x17010000 0x0 0x1000>; > >>>> #power-domain-cells =3D <1>; > >>>> }; > >>>> > >>>> If right? I will tell the syscon patch's owner delete the "simple-mf= d" in aon_syscon node. > >>> > >>> Yes, but your compatibles are now wrong. Just compatible =3D > >>> "starfive,jh7110-aon-syscon", "syscon". > >>> > >> > >> If compatible =3D "starfive,jh7110-aon-syscon", "syscon". My pmu drive= rs need use=20 > >> "starfive,jh7110-aon-syscon" to match. > >=20 > > And how it would even work with your proposal > > "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu"? > >=20 > > Try... > >=20 > >> And my pmu series will add this=20 > >> aon_syscon in yaml and device tree, so the syscon patch's owner don't = need=20 > >> to add the aon_syscon in its yaml and device tree? > >=20 > > I don't understand. But if you need to drop syscon, sure, drop it. > >=20 >=20 > Yes, I think it can drop aon_syscon node in syscon patch series. And mayb= e my > compatible =3D "starfive,jh7110-aon-pmu", "syscon"; is better. >=20 > aon_syscon: syscon@17010000 { > compatible =3D "starfive,jh7110-aon-pmu", "syscon"; I don't really understand why you actually need to have this compatible. Why not keep "starfive,jh7110-aon-syscon" & register the PMU using a software mechanism? > reg =3D <0x0 0x17010000 0x0 0x1000>; > #power-domain-cells =3D <1>; > }; >=20 > Best regards, > Krzysztof ^^^^^^^^^^^^^^ btw, your mailer is doing something odd with quotation. Cheers, Conor. --+N3Mbg4s7LcQH++0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZFOBbgAKCRB4tDGHoIJi 0kPXAQDud5N7nXj7gDMGD+6MnWsxLG803WiUGD455jBCgzvmeAEAps+uRCXiT365 KJIw/A5d325YftGjykNMpI0usmQWPg4= =HjHL -----END PGP SIGNATURE----- --+N3Mbg4s7LcQH++0-- --===============5509737560859328852== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============5509737560859328852==--