From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Marcin Wierzbicki <mawierzb@cisco.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Roger Quadros <rogerq@kernel.org>,
Swapnil Jakhade <sjakhade@cadence.com>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
xe-linux-external@cisco.com, danielwa@cisco.com,
olicht@cisco.com, Bartosz Wawrzyniak <bwawrzyn@cisco.com>
Subject: Re: [PATCH v2] phy: cadence: Sierra: Add single link SGMII register configuration
Date: Wed, 10 May 2023 11:34:47 +0200 [thread overview]
Message-ID: <20230510093447.6hwro4ukv6i2dzve@pengutronix.de> (raw)
In-Reply-To: <20230508160142.2489365-1-mawierzb@cisco.com>
[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]
Hello,
On Mon, May 08, 2023 at 04:01:40PM +0000, Marcin Wierzbicki wrote:
> Add single link SGMII register configuration for no SSC for
> cdns,sierra-phy-t0 compatibility string.
> The configuration is based on Sierra Programmer's Guide and
> validated in Cisco CrayAR SoC.
>
> Co-developed-by: Bartosz Wawrzyniak <bwawrzyn@cisco.com>
> Signed-off-by: Bartosz Wawrzyniak <bwawrzyn@cisco.com>
> Signed-off-by: Marcin Wierzbicki <mawierzb@cisco.com>
> Change-Id: Id4c093a1bbf409f3176736b5326854a1396391c1
The Change-Id footers are not supposed to appear in the kernel's
history, so it's better to leave them out when submitting a patch.
(I didn't look at the remaining patch, so me not criticizing more
doesn't implicitly mean the rest is fine. (But of course it also doesn't
mean it is not fine.))
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 112 bytes --]
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-05-10 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 16:01 [PATCH v2] phy: cadence: Sierra: Add single link SGMII register configuration Marcin Wierzbicki
2023-05-10 9:30 ` Roger Quadros
2023-05-10 9:34 ` Uwe Kleine-König [this message]
2023-05-10 14:40 ` Marcin Wierzbicki
2023-05-16 14:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510093447.6hwro4ukv6i2dzve@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bwawrzyn@cisco.com \
--cc=danielwa@cisco.com \
--cc=kishon@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mawierzb@cisco.com \
--cc=olicht@cisco.com \
--cc=rogerq@kernel.org \
--cc=sjakhade@cadence.com \
--cc=vkoul@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox