From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92A02C7EE25 for ; Mon, 12 Jun 2023 08:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+s7asBhcAAl9WMwixNpT6mFTBU/faBkBvcw1cQbq4fQ=; b=KYoCWdbpEz20wj KwOgydpAm5QbADN37Bkxtsc1E1DAHxKnoQXurL5NiBpiH2kIVk27iWW5MZ5H2iTwyZb7WNms+1iwt jPEX8JuEaj4eWqEnuQViD8Y2k0qTTRywo1FYiH5/mGMoD+Bpi+LyFiYdecw25/te2oU3e7NmMluzR PSss0SOD3yQ9hqQ0bXlZQClEh2s/oOdCdGYBFlrH4anbQI2ccyMJD4ihlrSvdRtELh9+H0d7dV2wj AvgVwxMo3eXK5oqhcbnYq7GasvC9n1PqpJ97cQ8CkXmLf5znJxeFtT1kZQyURIN3NxRsTyAYzqrbv F2LtCFVfpbOEeFGEqIVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8dHb-003AAv-0m; Mon, 12 Jun 2023 08:52:15 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8dHY-003A88-0c; Mon, 12 Jun 2023 08:52:13 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b1a46ad09fso46897931fa.2; Mon, 12 Jun 2023 01:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686559923; x=1689151923; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vC6uwJ0JqcA9AI2hZ192LN4Lm6HljDsWRRLUQCbqRcI=; b=ha+NLGOPK268A8Rm69MB2VrlRZ+bdLMoCKBLy0i1SKtuixABoEGpHl4oGE70nPdWrI fWHYhWb5EBh38UF+ViInymqzwkg/Zad+alqWfDprpVo9fgantG3Tz2sziWPw8upec7ts /Fv3t/yWt6xY9KXU53ybP9Y85wyqEazYhy6JiPo96nIX5SF4uRKG5GITBsqxWuCk1vQX EkWAFhD8ZV+9RpimOe60IiIxpLQXcl/lff1tzJzFERRz1X4gJJh8cCQuDLq3wpAnM8wY WWTst4ebBmy5XYqnnge0LQw1u/wcQ76+CfadGwNDS32TMQdIsStrT+N5jEUX9QHUrcCk D7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686559923; x=1689151923; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vC6uwJ0JqcA9AI2hZ192LN4Lm6HljDsWRRLUQCbqRcI=; b=aViVu/1WcEFGxgsEMbVv6LYlM32qgRSL0AtXlDI+2XupXYbQO50fn6uTE/NuBQ/weg KgcBMuk+I05eipWrAfn0R9grI5ZiEaT8MraSd9YcsFgLt2DzMxwOLfuIsnAEZIMAqaK6 AJXJ8DDPAmpCHdaOoGPqqftAcjWnjudP3o4FlHmDYBC4AHBBlf6hp8TEr8eYT1K0zQvz tMr3Ogz3QRyYLLlWLnDyLn/vkCN4pLeoipgG8HSAQvWEPO6Gw91aU2bwcIQz+dXWDqrR uLPAp5TPLsu78jKv7BtCG8nXRIp5F8Bjxpsjd8h3NE5OueXTegSqQdZMuWLU6+ybvf0L XVkQ== X-Gm-Message-State: AC+VfDypjWeXGARuHuBn10VyPoNpXvZQZ8ytGymu3vwnbVd3paMPkcly +QLazZg/bpnb+FPgUZgJuMg= X-Google-Smtp-Source: ACHHUZ7EKA8vldamQ7vDC+e0lKSYEpHmgr+nXY6Twa32SsY75+3B3FPeePjMNjp0U0aabyKDkLIrCw== X-Received: by 2002:a05:651c:1039:b0:2af:d2ef:49d4 with SMTP id w25-20020a05651c103900b002afd2ef49d4mr2231817ljm.1.1686559923246; Mon, 12 Jun 2023 01:52:03 -0700 (PDT) Received: from mobilestation ([95.79.140.35]) by smtp.gmail.com with ESMTPSA id s9-20020a2e9c09000000b002b31e0be2d7sm1003800lji.90.2023.06.12.01.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 01:52:02 -0700 (PDT) Date: Mon, 12 Jun 2023 11:52:00 +0300 From: Serge Semin To: Krzysztof Kozlowski Cc: Sebastian Reichel , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Damien Le Moal , Vinod Koul , Kishon Vijay Abraham I , linux-ide@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v3 2/5] dt-bindings: ata: dwc-ahci: add Rockchip RK3588 Message-ID: <20230612085200.5okxcipiw5sofo62@mobilestation> References: <20230608162238.50078-1-sebastian.reichel@collabora.com> <20230608162238.50078-3-sebastian.reichel@collabora.com> <4c914503-c2e5-a5d8-97af-daaee0b4ec7c@linaro.org> <20230612083536.q3sq7w6cyiuxaqtv@mobilestation> <838ed0e6-985d-9a45-7ece-c607bda15871@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <838ed0e6-985d-9a45-7ece-c607bda15871@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_015212_228785_C708C0B2 X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Jun 12, 2023 at 10:39:57AM +0200, Krzysztof Kozlowski wrote: > On 12/06/2023 10:35, Serge Semin wrote: > > On Mon, Jun 12, 2023 at 10:24:06AM +0200, Krzysztof Kozlowski wrote: > >> On 08/06/2023 18:22, Sebastian Reichel wrote: > >>> This adds Rockchip RK3588 AHCI binding. In order to narrow down the > >>> allowed clocks without bloating the generic binding, the description > >>> of Rockchip's AHCI controllers has been moved to its own file. > >>> > >>> Signed-off-by: Sebastian Reichel > >>> --- > >> > >> ... > >> > >>> + > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - enum: > >>> + - rockchip,rk3568-dwc-ahci > >>> + - rockchip,rk3588-dwc-ahci > >>> + - const: snps,dwc-ahci > >>> + > >>> + ports-implemented: > >>> + const: 1 > >>> + > >>> +patternProperties: > >>> + "^sata-port@[0-9a-e]$": > >>> + $ref: /schemas/ata/snps,dwc-ahci-common.yaml#/$defs/dwc-ahci-port > >>> + > >>> + unevaluatedProperties: false > >> > > > >> You should be able to skip this patternProperties entirely, because it > >> comes from dwc-ahci-common -> ahci-common schema. Did you try the patch > >> without it? > > > > Please see my message about this. The "sata-port@[0-9a-e]$" sub-node > > bindings could be updated with the "reg" property constraint which, > > based on the "ports-implemented" property value, most likely is > > supposed to be always set to const: 1. > > Then anyway the pattern is wrong as it should be @1 always. * I miscalculated a bit, it should have been zero but in general the pattern-property is indeed redundant. As a conclusion the change should look like this: +properties: + compatible: + items: + - enum: + - rockchip,rk3568-dwc-ahci + - rockchip,rk3588-dwc-ahci + - const: snps,dwc-ahci + + ports-implemented: + const: 1 + + "sata-port@0": + $ref: /schemas/ata/snps,dwc-ahci-common.yaml#/$defs/dwc-ahci-port + + properties: + reg: + const: 0 + + unevaluatedProperties: false + + ... Right? -Serge(y) > > Best regards, > Krzysztof > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy