From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6998C04A94 for ; Fri, 7 Jul 2023 15:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Do4GhiWTPiju/mqTLNhqOkgGmY/ZPwb/lxcviSGDNB0=; b=LMF0BEp9R4mlxa w3YCJsAnZEwu7WwHCK1BrM4Vq2HUe5xJrml9DtgTPj9QvmJ+CeG2z6r3NKQDazLambF3MJBU5y+JQ NB5rRiyNNknHFlZXXqYf56mdxO2jjITE/K2cDxHYSPY5EgZzdaIyT6WTm4U2gMecTdLW7Jzuaandv sLbg9xlG5tK4Z0VB9X7gNV4IrZp5FvGrMrDM7sDlsO/gbHUmMMv8ZM3wWMyDvI9eDS+VFw8T8Weza aJQj9Fyp/kP2jYmSkCTppDqQ+JAzgWm8vKyQ3VeP0mKzbHIxxPr6sxAskShFtMQWzc2HhpC8mHnhd YK7rb8cnsz1CwLwb4jLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHnMv-0052SA-1X; Fri, 07 Jul 2023 15:27:37 +0000 Received: from mail-io1-f41.google.com ([209.85.166.41]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHnMq-0052Or-2L; Fri, 07 Jul 2023 15:27:35 +0000 Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7837329a00aso70874839f.2; Fri, 07 Jul 2023 08:27:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688743649; x=1691335649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iSMX3fbwS3ZdQ14KbIA9PVvNgGYdtwwGwe8Mi8kgYeU=; b=irQ+kHrrF20/TiArkt9elD7uLEx9dKF0UU41/OTCm5IK+pzd4ROrkWl3wVNMRtOF8D MD5ntkIL49SUQxUhULbIOrojZW7xNjz3v9SejlNfjJFwq2G2Dq7BjnJFdgjGpVMPFXHb s95OSxCCgdn+u8BUxWG32p4O3n8viAitiIjSIftJE/IdjKaOyv7GwIVn2Zrz1h9dDerB msYJn//tWhOP3koJORcNOC+3KieYv7YgKwLqgTOK6Qxi/8GMGB3tMyecr5BTJ8z/j5Qg ZEPnKYtFpZqSzIuaZgKrfRyNzogmcoYOtbEhoTdBv7GdAnlwp8hAXbVFDUI+wQfkz3vA 4ppA== X-Gm-Message-State: ABy/qLay3EEx85WKO0uhnYShKPSUQ37jXdvZubKrEm5YsQ/BX4Rii6pi paxdL62+Vaf1vCjIgTQKig== X-Google-Smtp-Source: APBJJlGQb/+NSo1YY2XQiOfry0niDhsIK8kPOwBt3oTrgIhTVOV41ugAIwkpb1OfmPqwJ646BYkBgA== X-Received: by 2002:a92:c70f:0:b0:345:c11e:d1ad with SMTP id a15-20020a92c70f000000b00345c11ed1admr5255201ilp.26.1688743649601; Fri, 07 Jul 2023 08:27:29 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id ee17-20020a056638293100b0042b37080b23sm1279795jab.73.2023.07.07.08.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 08:27:28 -0700 (PDT) Received: (nullmailer pid 334293 invoked by uid 1000); Fri, 07 Jul 2023 15:27:24 -0000 Date: Fri, 7 Jul 2023 09:27:24 -0600 From: Rob Herring To: Oleksii Moisieiev Cc: Gatien Chevallier , "gregkh@linuxfoundation.org" , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "alexandre.torgue@foss.st.com" , "vkoul@kernel.org" , "jic23@kernel.org" , "olivier.moysan@foss.st.com" , "arnaud.pouliquen@foss.st.com" , "mchehab@kernel.org" , "fabrice.gasnier@foss.st.com" , "andi.shyti@kernel.org" , "ulf.hansson@linaro.org" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "hugues.fruchet@foss.st.com" , "lee@kernel.org" , "will@kernel.org" , "catalin.marinas@arm.com" , "arnd@kernel.org" , "richardcochran@gmail.com" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-iio@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-media@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-phy@lists.infradead.org" , "linux-serial@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH 04/10] dt-bindings: treewide: add feature-domains description in binding files Message-ID: <20230707152724.GA329615-robh@kernel.org> References: <20230705172759.1610753-1-gatien.chevallier@foss.st.com> <20230705172759.1610753-5-gatien.chevallier@foss.st.com> <875y6vzuga.fsf@epam.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <875y6vzuga.fsf@epam.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_082732_760371_F1AE724D X-CRM114-Status: GOOD ( 22.58 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Jul 07, 2023 at 02:07:18PM +0000, Oleksii Moisieiev wrote: > > Gatien Chevallier writes: > > > feature-domains is an optional property that allows a peripheral to > > refer to one or more feature domain controller(s). > > > > Description of this property is added to all peripheral binding files of > > the peripheral under the STM32 firewall controllers. It allows an accurate > > representation of the hardware, where various peripherals are connected > > to this firewall bus. The firewall can then check the peripheral accesses > > before allowing it to probe. > > > > Signed-off-by: Gatien Chevallier > > --- > > > > Disclaimer: Some error with dtbs_check will be observed as I've > > considered the property to be generic, as Rob asked > > > > Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml | 4 ++++ > > Documentation/devicetree/bindings/dma/st,stm32-dma.yaml | 4 ++++ > > Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml | 4 ++++ > > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 4 ++++ > > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 4 ++++ > > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 4 ++++ > > Documentation/devicetree/bindings/iio/dac/st,stm32-dac.yaml | 4 ++++ > > .../devicetree/bindings/media/cec/st,stm32-cec.yaml | 4 ++++ > > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 ++++ > > .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 4 ++++ > > Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml | 4 ++++ > > Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 5 +++++ > > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 4 ++++ > > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 4 ++++ > > Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 4 ++++ > > .../devicetree/bindings/regulator/st,stm32-vrefbuf.yaml | 4 ++++ > > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 4 ++++ > > Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 4 ++++ > > Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 4 ++++ > > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 4 ++++ > > .../devicetree/bindings/sound/st,stm32-spdifrx.yaml | 4 ++++ > > Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml | 4 ++++ > > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 4 ++++ > > Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++ > > 24 files changed, 97 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > > index b767ec72a999..daf8dcaef627 100644 > > --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > > @@ -50,6 +50,10 @@ properties: > > power-domains: > > maxItems: 1 > > > > + feature-domains: > > + minItems: 1 > > + maxItems: 3 > > + > > I beliewe feature-domains is generic binding. This means that maxItems > can be implementation dependend. I would rather drop maxItems so the > following format will be possible: > > feature-domains = <&etzpc 1>, <&etzpc 2>, <&some_other_domain 1 2 3 4> > feature-domain-names = "firewall 1", "firewall 2", "other_domain" The above already allows this (not -names, but the number of entries). > > Also I beliewe driver will handle feature-domain-names property so it > will parse feature-domains only related to the firewall. Now I'm curious. What's an example that's not a firewall? (Note I'm still not happy with the naming of 'feature' as anything is a feature, but that's the least of the issues really.) Rob -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy