From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] phy: qcom-m31: Fix error code in probe()
Date: Thu, 7 Sep 2023 15:54:05 +0530 [thread overview]
Message-ID: <20230907102405.GA7987@varda-linux.qualcomm.com> (raw)
In-Reply-To: <7926c8e6-630e-4d7a-b0b2-d29b3c8b2c09@moroto.mountain>
On Thu, Sep 07, 2023 at 12:54:39PM +0300, Dan Carpenter wrote:
> This accidentally returns the wrong variable. It should be "qphy->vreg"
> instead of "qphy->phy".
>
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> When we're adding new drivers then we should use the new driver
> prefix instead of the subsystem prefix. For example:
>
> Bad: [PATCH] phy: qcom: Introduce M31 USB PHY driver
> Good: [PATCH] phy: qcom-m31: Introduce M31 USB PHY driver
>
> That way it's obvious to the first person who sends a bugfix
> what the driver prefix is.
>
> drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
> index ed08072ca032..99d570f4142a 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31.c
> @@ -256,7 +256,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
>
> qphy->vreg = devm_regulator_get(dev, "vdda-phy");
> if (IS_ERR(qphy->vreg))
> - return dev_err_probe(dev, PTR_ERR(qphy->phy),
> + return dev_err_probe(dev, PTR_ERR(qphy->vreg),
> "failed to get vreg\n");
>
> phy_set_drvdata(qphy->phy, qphy);
> --
> 2.39.2
I believe this is addressed by https://lore.kernel.org/linux-arm-msm/20230824091345.1072650-1-yangyingliang@huawei.com/
Thanks
Varada
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-09-07 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 9:54 [PATCH] phy: qcom-m31: Fix error code in probe() Dan Carpenter
2023-09-07 10:24 ` Varadarajan Narayanan [this message]
2023-09-07 10:29 ` Dan Carpenter
2023-09-07 16:23 ` Deepak R Varma
2023-09-08 7:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907102405.GA7987@varda-linux.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox