From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Merlijn Wajer <merlijn@wizzup.org>,
Miaoqian Lin <linmq006@gmail.com>, Pavel Machek <pavel@ucw.cz>,
linux-phy@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 3/3] phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins
Date: Wed, 13 Sep 2023 07:59:13 +0300 [thread overview]
Message-ID: <20230913045913.GO5282@atomide.com> (raw)
In-Reply-To: <20230912151421.s2n6uztafg23ceu7@mercury.elektranox.org>
* Sebastian Reichel <sebastian.reichel@collabora.com> [230912 15:14]:
> Apparently phy_power_off is not called on device removal, so I
> understand the need to setup sleep pins in phy_mdm6600_device_power_off()
> in addition to the exsting setup in phy_mdm6600_power_off().
>
> But I'm a bit confused about the change required in probe(), since
> phy_mdm6600_power_on() selects the default state. I wouldn't expect
> any access before the phy is powered on? Anyways,
Maybe we should just set the sleep state in remove and leave it out of the
phy functions. If a separate state is needed for the phy_mdm6600_power_off(),
it could be the pinctrl idle state.
We need the reset pin in probe to get the modem started. The modem may
also be started in uart mode for firmware flashing depending on how the
gpio pins are set.
Regards,
Tony
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-09-13 4:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 3:54 [PATCH 1/3] phy: mapphone-mdm6600: Fix runtime disable on probe Tony Lindgren
2023-09-11 3:54 ` [PATCH 2/3] phy: mapphone-mdm6600: Fix runtime PM for remove Tony Lindgren
2023-09-12 15:00 ` Sebastian Reichel
2023-09-13 4:36 ` Tony Lindgren
2023-09-11 3:54 ` [PATCH 3/3] phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins Tony Lindgren
2023-09-12 15:14 ` Sebastian Reichel
2023-09-13 4:59 ` Tony Lindgren [this message]
2023-09-12 15:00 ` [PATCH 1/3] phy: mapphone-mdm6600: Fix runtime disable on probe Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913045913.GO5282@atomide.com \
--to=tony@atomide.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=kishon@kernel.org \
--cc=kishon@ti.com \
--cc=linmq006@gmail.com \
--cc=linux-phy@lists.infradead.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).