From: Conor Dooley <conor@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Krishna chaitanya chundru <quic_krichai@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com,
quic_nitegupt@quicinc.com, quic_skananth@quicinc.com,
quic_vpernami@quicinc.com, quic_parass@quicinc.com
Subject: Re: [PATCH v2 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property
Date: Wed, 8 Nov 2023 15:52:11 +0000 [thread overview]
Message-ID: <20231108-surgical-yelling-7314b68c0289@spud> (raw)
In-Reply-To: <CAA8EJpqvCJsft3Y-m2ZYORBg=6P7EhT-PsCSkuQ4xaxuf3KOwA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1868 bytes --]
On Tue, Nov 07, 2023 at 03:01:47PM +0200, Dmitry Baryshkov wrote:
> On Tue, 7 Nov 2023 at 14:26, Krishna chaitanya chundru
> <quic_krichai@quicinc.com> wrote:
> >
> > Document qcom,refclk-always-on property which is needed in some platforms
> > to supply refclk even in PCIe low power states.
> >
> > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> > ---
> > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > index 2c3d6553a7ba..263291447a5b 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> > @@ -93,6 +93,13 @@ properties:
> > "#phy-cells":
> > const: 0
> >
> > + qcom,refclk-always-on:
> > + type: boolean
> > + description: If there is some issues in platform with clkreq signal
>
> nit: there are some
>
> However this still doesn't describe what kind of issues with clkreq
> you observe. I mean, clkreq is just a GPIO pin.
>
> > + propagation to the host and due to that host will not send refclk, which
> > + results in linkdown in L1.2 or L1.1 exit initiated by EP. This property
> > + if set keeps refclk always on even in Low power states (optional).
Dimitry's issues with the property aside, putting "(optional)" in the
description is meaningless - qcom,refclk-always-on isn't listed in the
required properties section, so therefore has to be optional.
Cheers,
Conor.
> > +
> > required:
> > - compatible
> > - reg
> >
> > --
> > 2.42.0
> >
> >
>
>
> --
> With best wishes
> Dmitry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 112 bytes --]
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-11-08 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 12:26 [PATCH v2 0/3] phy: qcom-qmp-pcie: Add support to keep refclk always on Krishna chaitanya chundru
2023-11-07 12:26 ` [PATCH v2 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property Krishna chaitanya chundru
2023-11-07 13:01 ` Dmitry Baryshkov
2023-11-08 15:52 ` Conor Dooley [this message]
2023-11-27 11:49 ` Krishna Chaitanya Chundru
2023-11-07 12:26 ` [PATCH v2 2/3] phy: qcom-qmp-pcie: Add endpoint refclk control register offset Krishna chaitanya chundru
2023-11-07 13:06 ` Dmitry Baryshkov
2023-11-09 9:36 ` Krishna Chaitanya Chundru
2023-11-09 9:45 ` Dmitry Baryshkov
2023-11-09 10:02 ` Krishna Chaitanya Chundru
2023-11-07 12:26 ` [PATCH v2 3/3] phy: qcom-qmp-pcie: Add support for keeping refclk always on Krishna chaitanya chundru
2023-11-07 13:08 ` Dmitry Baryshkov
2023-11-07 21:57 ` [PATCH v2 0/3] phy: qcom-qmp-pcie: Add support to keep " Konrad Dybcio
2023-11-09 9:32 ` Krishna Chaitanya Chundru
2023-11-09 13:57 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108-surgical-yelling-7314b68c0289@spud \
--to=conor@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_parass@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox