From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85BFEC636CB for ; Fri, 24 Nov 2023 14:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NaHGifRWhx1hV1OqvoJ1TgJBfMb0Xh6ukirk2Brb81o=; b=OibFEqxGvd8RRh7m6NU+RKHY8G Q2+wWv/U8b9kEENivs8FFgZuWIczxTMWcLgpvtexHQZdqBjMTZ6TkPVNdb1w0kDiPRT05DWeqZPsz bg3mZ+VS+ZP8KCL8TvKrf4Kp1pAIiOvqcuLo5F4FLDz00keM+i8ynRQceDhDsztzNI0C9IzAPrWL4 xfRKOplEXOMbwUvyoxOQseieRrEhVTz7wxGUyDh8sOiwZFPFlER6LSNKI6k5ZZMNCip2bNmjCseER qqHXIED6YaI1/W6e0/HXjzJfqbUcOpuEBGZ44DSwE9Uv7X6o4Uq2cnX5rJNrqH2JNyJvIbWZ38lYK VJ2W7sRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6XNX-007RDV-0L; Fri, 24 Nov 2023 14:41:59 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6XNR-007R8z-1t; Fri, 24 Nov 2023 14:41:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id C5119B830EA; Fri, 24 Nov 2023 14:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C6B4C433CB; Fri, 24 Nov 2023 14:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700836911; bh=sN2GV7ooCULXSqP4A45dgDJT99C/q8vC8n4JoqkQwkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tZlkN8TCzfmvQw+zzZzoOpOxWzQXubQmb+3KG6Pfqe6wOFk8DbHTn9r34srQLIBus +o2w6oBIEL2mjiwOjv0VeYMAp5wGtsfFjUkiw33gECaIJG5pcIV325wWOFM7uG03JI I9naTpaw78L/lfvDeYQT4Zg595YZXDZrCdsmCawd7Ej3YHUVAjUnpbQkzjy0iOVapE dzR3++E+TIqzu6LQo1qQxiRLZm1K1w/3o8hYpUzKgtg2TGzQssQQYd11Amp37xOs7a vA4DjYXZ/raNg4NI1JTeWa69+CkHTGEiuTWccZi0yl5rg7GPlGkQF4buv3e58zYSND CbXINWXgZKFGQ== Date: Fri, 24 Nov 2023 14:41:43 +0000 From: Conor Dooley To: Neil Armstrong Cc: Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , David Airlie , Daniel Vetter , Jagan Teki , Nicolas Belin , Vinod Koul , Kishon Vijay Abraham I , Remi Pommarel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, Rob Herring Subject: Re: [PATCH v9 04/12] dt-bindings: phy: amlogic,g12a-mipi-dphy-analog: drop unneeded reg property and example Message-ID: <20231124-vowel-reversing-619f7c4e5060@spud> References: <20231124-amlogic-v6-4-upstream-dsi-ccf-vim3-v9-0-95256ed139e6@linaro.org> <20231124-amlogic-v6-4-upstream-dsi-ccf-vim3-v9-4-95256ed139e6@linaro.org> <20231124-felt-tip-everybody-f2a6836e52af@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_064153_895942_DA010C5E X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1054977638485175484==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============1054977638485175484== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xgsO/76B+uGPTN6M" Content-Disposition: inline --xgsO/76B+uGPTN6M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 24, 2023 at 02:50:58PM +0100, Neil Armstrong wrote: > Hi Conor, >=20 > On 24/11/2023 13:36, Conor Dooley wrote: > > On Fri, Nov 24, 2023 at 09:41:15AM +0100, Neil Armstrong wrote: > > > The amlogic,g12a-mipi-dphy-analog is a feature of the simple-mfd > > > amlogic,meson-axg-hhi-sysctrl system control register zone which is an > > > intermixed registers zone, thus it's very hard to define clear ranges= for > > > each SoC controlled features even if possible. > > >=20 > > > The amlogic,g12a-mipi-dphy-analog was wrongly documented as an indepe= ndent > > > register range, which is not the reality, thus fix the bindings by dr= opping > > > the reg property now it's referred from amlogic,meson-gx-hhi-sysctrl.= yaml > > > and documented as a subnode of amlogic,meson-axg-hhi-sysctrl. > > >=20 > > > Also drop the unnecessary example, the top level bindings example sho= uld > > > be enough. > > >=20 > > > Fixes: 76ab79f9726c ("dt-bindings: phy: add Amlogic G12A Analog MIPI = D-PHY bindings") > > > Signed-off-by: Neil Armstrong > >=20 > > I feel like I left a tag on this one before, but I can't remember. > > Perhaps I missed the conclusion to the discussion to the discussion with > > Rob about whether having "reg" was desirable that lead to a tag being > > dropped? >=20 > I checked again and nope, not tag, but Rob's question was legitimate and = I reworded > and clarified the commit message following your reviews. > On the other side you suggested a Fixes tag, which I added. >=20 > The rewording is about why reg doesn't make sense on the nature of the me= mory > region and it doesn't make sense here like other similar nodes. Okay, I thought that I had given you one. Perhaps I forgot to send, or Rob's message came in between me asking about the Fixes tag & replying with an Ack. Sorry about that, Acked-by: Conor Dooley Cheers, Conor. --xgsO/76B+uGPTN6M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWC2JwAKCRB4tDGHoIJi 0rfLAQCNolGZjIZg5rXxw9C1OMazRjRDdxd0RzNgb5+TM66JZQD8CbqSE3MjrSJn SkJrWLo0HrWEEIlIb569LlFJT5w6QQ0= =UnJl -----END PGP SIGNATURE----- --xgsO/76B+uGPTN6M-- --===============1054977638485175484== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============1054977638485175484==--