From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED28FC10F05 for ; Wed, 6 Dec 2023 13:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UiIEfBouQFvijs9alX3TZDxJ9+p6PlYGLi5XHDAO66s=; b=0VLULqVMwfp0Ss IGbo3MbmWrmvffQLD9omQzjbjcYjDMwCV4A13YaSVwXFTPpJT8naECPtr83pBkRzpa3xVsp72+rub t7asxxact0gVl0pmB5q/1IMhZwjOom1yvnDFzvBXvxBVhPEYrOYy1k7se79FJRg6mb4NS8ws9JsPf a8z/a6sgjTGj4moMjWZVRxrLCEZkQqdv6qycVs0bx43jwh5VtttoxyNXhNWaIlisCU0GcjNXam9Gj OMv/PlcKinlz6uYUbzpZRpAAsNoM6gbEBqH1KJYzxYE+E6xXCEBCQ1pAcDt2VrKBsScWsPIYFLcP6 auNMlRR3lE77aKWWBHfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAs2V-00AOdB-1w; Wed, 06 Dec 2023 13:34:11 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAs2S-00AOc9-0G; Wed, 06 Dec 2023 13:34:09 +0000 Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6d9d29a2332so46602a34.0; Wed, 06 Dec 2023 05:34:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701869646; x=1702474446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GKUyAGPVNJ2iCz/byc+vad2U0HtCXFR/OKxsFSUjBSo=; b=kUmqBE2ATAWmxYNy3PzxspgcqsZg1hHUoEsef52DRuB2LRZMmZlFyXyVs3pDfXoLde HHxq3ir0Wy1+7IXU/Dntmd0f9is2gQiLnZ3788HILiCoXE2EO9Yi0gPBV9Jv963wN9/T 5lxVQBIiHZSa67Na9Bh4ei1rvm83CCEDbPNS1YdYiYEcksNH9XFMLO2UFOUUI/bZdQaS WgJ/EuXFxCqlXe3HMdfYlQyR3mYQNX4VzsdMQfmlarWd3cX90Kjo6zZbikq07br2X7OO qNYEQC/wzJXSlurWMWTYw44iIm8bebqDxlFynN1voVl5lwysUpHeTOHITyZpV2/6c3TG oiwQ== X-Gm-Message-State: AOJu0Yx/cBNHlRlidpIpSRXu4L9+kYAwsb9UDhCmOvmLEVj1H86C5hA2 44r7sJHCV7iXwu53Exg+Qw== X-Google-Smtp-Source: AGHT+IHWs8BDYeEsQ9p7nU50NuMdIrEA5NhSUWcTgZm0IYA+OhimehJYkLAie1qpwHIrrcHjciYBFA== X-Received: by 2002:a05:6830:2aaa:b0:6d8:74e2:552a with SMTP id s42-20020a0568302aaa00b006d874e2552amr431988otu.22.1701869645696; Wed, 06 Dec 2023 05:34:05 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id z17-20020a9d62d1000000b006b9848f8aa7sm2665206otk.45.2023.12.06.05.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 05:34:05 -0800 (PST) Received: (nullmailer pid 1911334 invoked by uid 1000); Wed, 06 Dec 2023 13:34:03 -0000 Date: Wed, 6 Dec 2023 07:34:03 -0600 From: Rob Herring To: Daniel Golle Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Lunn , Heiner Kallweit , Russell King , Alexander Couzens , Qingfang Deng , SkyLake Huang , Philipp Zabel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS Message-ID: <20231206133403.GA1894508-robh@kernel.org> References: <3cd8af5e44554c2db2d7898494ee813967206bd9.1701826319.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3cd8af5e44554c2db2d7898494ee813967206bd9.1701826319.git.daniel@makrotopia.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_053408_122693_37F8904D X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Wed, Dec 06, 2023 at 01:44:38AM +0000, Daniel Golle wrote: > Add driver for USXGMII PCS found in the MediaTek MT7988 SoC and supporting > USXGMII, 10GBase-R and 5GBase-R interface modes. In order to support > Cisco SGMII, 1000Base-X and 2500Base-X via the also present LynxI PCS > create a wrapped PCS taking care of the components shared between the > new USXGMII PCS and the legacy LynxI PCS. > > Signed-off-by: Daniel Golle > --- > .../bindings/net/pcs/mediatek,usxgmii.yaml | 46 +- Why are you changing the binding you just added? In any case, bindings are separate patches. > MAINTAINERS | 2 + > drivers/net/pcs/Kconfig | 11 + > drivers/net/pcs/Makefile | 1 + > drivers/net/pcs/pcs-mtk-usxgmii.c | 413 ++++++++++++++++++ > include/linux/pcs/pcs-mtk-usxgmii.h | 26 ++ > 6 files changed, 456 insertions(+), 43 deletions(-) > create mode 100644 drivers/net/pcs/pcs-mtk-usxgmii.c > create mode 100644 include/linux/pcs/pcs-mtk-usxgmii.h -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy