From: Rob Herring <robh@kernel.org>
To: David Wronek <davidwronek@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v4 3/8] dt-bindings: phy: Add QMP UFS PHY compatible for SC7180
Date: Mon, 12 Feb 2024 16:21:09 -0600 [thread overview]
Message-ID: <20240212222109.GA2655166-robh@kernel.org> (raw)
In-Reply-To: <20240121-sm7125-upstream-v4-3-f7d1212c8ebb@gmail.com>
On Sun, Jan 21, 2024 at 05:57:43PM +0100, David Wronek wrote:
> Document the QMP UFS PHY compatible for SC7180
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: David Wronek <davidwronek@gmail.com>
> ---
> Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> index 8474eef8d0ff..5faa1cb3a12e 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> @@ -19,6 +19,7 @@ properties:
> - qcom,msm8996-qmp-ufs-phy
> - qcom,msm8998-qmp-ufs-phy
> - qcom,sa8775p-qmp-ufs-phy
> + - qcom,sc7180-qmp-ufs-phy
This doesn't match what you put in the dts which is adding to the
warnings:
51 phy@1d87000: compatible: ['qcom,sc7180-qmp-ufs-phy', 'qcom,sm7150-qmp-ufs-phy'] is too long
51 phy@1d87000: clock-names: ['ref', 'ref_aux'] is too short
48 phy@1d87000: clocks: [[39, 97], [39, 103]] is too short
30 phy@1d87000: 'power-domains' is a required property
> - qcom,sc7280-qmp-ufs-phy
> - qcom,sc8180x-qmp-ufs-phy
> - qcom,sc8280xp-qmp-ufs-phy
> @@ -102,6 +103,7 @@ allOf:
> contains:
> enum:
> - qcom,msm8998-qmp-ufs-phy
> + - qcom,sc7180-qmp-ufs-phy
> - qcom,sc8180x-qmp-ufs-phy
> - qcom,sc8280xp-qmp-ufs-phy
> - qcom,sdm845-qmp-ufs-phy
>
> --
> 2.43.0
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-02-12 22:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 16:57 [PATCH v4 0/8] Add UFS support for SC7180/SM7125 David Wronek
2024-01-21 16:57 ` [PATCH v4 1/8] dt-bindings: crypto: ice: Document SC7180 inline crypto engine David Wronek
2024-01-26 9:09 ` Herbert Xu
2024-01-21 16:57 ` [PATCH v4 2/8] dt-bindings: ufs: qcom: Add SC7180 compatible string David Wronek
2024-02-12 22:22 ` Rob Herring
2024-02-13 10:29 ` Dmitry Baryshkov
2024-02-13 18:11 ` Rob Herring
2024-02-14 8:56 ` Krzysztof Kozlowski
2024-03-05 18:53 ` Rob Herring
2024-01-21 16:57 ` [PATCH v4 3/8] dt-bindings: phy: Add QMP UFS PHY compatible for SC7180 David Wronek
2024-02-12 22:21 ` Rob Herring [this message]
2024-01-21 16:57 ` [PATCH v4 4/8] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 9S David Wronek
2024-01-21 16:57 ` [PATCH v4 5/8] phy: qcom: qmp-ufs: Add SC7180 support David Wronek
2024-01-21 16:57 ` [PATCH v4 6/8] arm64: dts: qcom: sc7180: Add UFS nodes David Wronek
2024-01-21 16:57 ` [PATCH v4 7/8] arm64: dts: qcom: sm7125-xiaomi-common: " David Wronek
2024-01-21 16:57 ` [PATCH v4 8/8] arm64: dts: qcom: Add support for Xiaomi Redmi Note 9S David Wronek
2024-01-23 14:20 ` (subset) [PATCH v4 0/8] Add UFS support for SC7180/SM7125 Vinod Koul
2024-02-01 21:53 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212222109.GA2655166-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=davem@davemloft.net \
--cc=davidwronek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).