From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34392C4829E for ; Thu, 15 Feb 2024 12:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=26xZETbmQ21CUdNHE9H3TYVIIMqms9LwgYLSEVZDpdA=; b=R9XpwTK5Z3Wb0b nKxFhhwKvmItgkrx0qVqQUdq9QB+OtOzQjay+pVFQVGebXQORrNwEs8XfQhYt23sxwJYWU3tkRu+y 9VilvixVu+KKfkztgyXenuWG2MWkMWHUIR5+W1frBDsVAHZUPWBDlaskOsKeDAyIs9dOJd6ZauqxW HrTcQNb6K2bYy+jqL01PE1JAhli5iw+1AyuB0Pk9ZfAroIlKAQx4l4o5CLHNSuykXKnQEpoL+n7qh GsqCJdEVGjR2ZHWVuCJrYDhEFBoJrAiY9OsZkXIfRA8AU8HzrexAq4I7kRjwJYXjg0IhqGOOji6ay Zv/FGFGxYQOIIzaa09rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raats-0000000GEYI-3Xhd; Thu, 15 Feb 2024 12:31:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raatp-0000000GEX7-36Nt; Thu, 15 Feb 2024 12:31:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EF93F61D4C; Thu, 15 Feb 2024 12:31:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 646FDC433C7; Thu, 15 Feb 2024 12:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708000290; bh=Rtv0ZqMtH22wW9o5CLE4ANcXNgzVDytLO9CvtPg0SkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GisX5szz172MOWHxrJ6VLy2Hi6J/ulEGFD7SFjzkGTrkt9FyYw3+DUKZf29RA5RyC xTORMDyt4X7YRKEcuBI2Cx7psIyk4w5Ja9/p41UbAZQ/cHpyTyqR7Rj5Nb1oBVvISs GNLSnkBPATXd8bp8uriJ/jM3jB52QqEn+n5V/migzlddtXiv0vkoA9/x8HSt+hka/R 51yBSdgZBrS2P9LTibJRw19TQroncSWhPTe/j74rQl77zH4BWaTkU+wX4X7alSgiNu i+Bw1Dw6GFSECfuxp4yyJyhy484KO3FACaGt0qEWIqE05qWk4GYrEpVzPyt6MJ9w31 jPjEtAzijKqDg== Date: Thu, 15 Feb 2024 06:31:27 -0600 From: Rob Herring To: Sebastian Reichel Cc: Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, Krzysztof Kozlowski , Conor Dooley , Frank Wang , Kever Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 03/12] dt-bindings: phy: add rockchip usbdp combo phy document Message-ID: <20240215123127.GA3762185-robh@kernel.org> References: <20240213163609.44930-1-sebastian.reichel@collabora.com> <20240213163609.44930-4-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240213163609.44930-4-sebastian.reichel@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_043133_888847_4DC23DD8 X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024 at 05:32:37PM +0100, Sebastian Reichel wrote: > Add device tree binding document for Rockchip USBDP Combo PHY > with Samsung IP block. > > Co-developed-by: Frank Wang > Signed-off-by: Frank Wang > Signed-off-by: Sebastian Reichel > --- > .../bindings/phy/phy-rockchip-usbdp.yaml | 169 ++++++++++++++++++ > 1 file changed, 169 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml > new file mode 100644 > index 000000000000..4ac1825144d7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml > @@ -0,0 +1,169 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/phy-rockchip-usbdp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip USBDP Combo PHY with Samsung IP block > + > +maintainers: > + - Frank Wang > + - Zhang Yubing > + > +properties: > + compatible: > + enum: > + - rockchip,rk3588-usbdp-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: refclk > + - const: immortal > + - const: pclk > + - const: utmi > + > + resets: > + maxItems: 5 > + > + reset-names: > + items: > + - const: init > + - const: cmn > + - const: lane > + - const: pcs_apb > + - const: pma_apb > + > + rockchip,dp-lane-mux: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 2 > + maxItems: 4 items: maximum: 3 > + description: > + An array of physical Type-C lanes indexes. Position of an entry > + determines the DisplayPort (DP) lane index, while the value of an entry > + indicates physical Type-C lane. The supported DP lanes number are 2 or 4. > + e.g. for 2 lanes DP lanes map, we could have "rockchip,dp-lane-mux = <2, > + 3>;", assuming DP lane0 on Type-C phy lane2, DP lane1 on Type-C phy > + lane3. For 4 lanes DP lanes map, we could have "rockchip,dp-lane-mux = > + <0, 1, 2, 3>;", assuming DP lane0 on Type-C phy lane0, DP lane1 on Type-C > + phy lane1, DP lane2 on Type-C phy lane2, DP lane3 on Type-C phy lane3. If > + DP lane map by DisplayPort Alt mode, this property is not need. > + > + rockchip,u2phy-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the syscon managing the 'usb2 phy general register files'. > + > + rockchip,usb-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the syscon managing the 'usb general register files'. > + > + rockchip,usbdpphy-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the syscon managing the 'usbdp phy general register files'. > + > + rockchip,vo-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the syscon managing the 'video output general register files'. > + When select the DP lane mapping will request its phandle. > + > + sbu1-dc-gpios: > + description: > + GPIO connected to the SBU1 line of the USB-C connector via a big resistor > + (~100K) to apply a DC offset for signalling the connector orientation. > + maxItems: 1 > + > + sbu2-dc-gpios: > + description: > + GPIO connected to the SBU2 line of the USB-C connector via a big resistor > + (~100K) to apply a DC offset for signalling the connector orientation. > + maxItems: 1 > + > + orientation-switch: > + description: Flag the port as possible handler of orientation switching > + type: boolean > + > + mode-switch: > + description: Flag the port as possible handler of altmode switching > + type: boolean > + > + dp-port: > + type: object > + additionalProperties: false > + > + properties: > + "#phy-cells": > + const: 0 > + > + required: > + - "#phy-cells" > + > + usb3-port: > + type: object > + additionalProperties: false > + > + properties: > + "#phy-cells": > + const: 0 > + > + required: > + - "#phy-cells" I don't see why these child nodes are needed. Just use a cell to define DP and USB3 phys. > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + A port node to link the PHY to a TypeC controller for the purpose of > + handling orientation switching. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - reset-names > + - dp-port > + - usb3-port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + usbdp_phy0: phy@fed80000 { > + compatible = "rockchip,rk3588-usbdp-phy"; > + reg = <0xfed80000 0x10000>; > + clocks = <&cru CLK_USBDPPHY_MIPIDCPPHY_REF>, > + <&cru CLK_USBDP_PHY0_IMMORTAL>, > + <&cru PCLK_USBDPPHY0>, > + <&u2phy0>; > + clock-names = "refclk", "immortal", "pclk", "utmi"; > + resets = <&cru SRST_USBDP_COMBO_PHY0_INIT>, > + <&cru SRST_USBDP_COMBO_PHY0_CMN>, > + <&cru SRST_USBDP_COMBO_PHY0_LANE>, > + <&cru SRST_USBDP_COMBO_PHY0_PCS>, > + <&cru SRST_P_USBDPPHY0>; > + reset-names = "init", "cmn", "lane", "pcs_apb", "pma_apb"; > + rockchip,u2phy-grf = <&usb2phy0_grf>; > + rockchip,usb-grf = <&usb_grf>; > + rockchip,usbdpphy-grf = <&usbdpphy0_grf>; > + rockchip,vo-grf = <&vo0_grf>; > + > + usbdp_phy0_dp: dp-port { > + #phy-cells = <0>; > + }; > + > + usbdp_phy0_u3: usb3-port { > + #phy-cells = <0>; > + }; > + }; > -- > 2.43.0 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy