From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C839DC5475B for ; Wed, 6 Mar 2024 14:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gO+gydRUkUns2lm3aUqeBDdfH1zXECwka9lz8NBPvpU=; b=RCJ7PBywIWqh8efg6v7KD454pT rCj+qMQZK18GCD89duvNCawIZEBKGMNpjFq7hUUAZoVe5Bw1ehzjsNMYQxQ9Qm5p/iRdCzKnbIlgl n6jNHfkMv2UnJdSvxQ2ZvhlCTsG6F4nDTpnYGatdL7c8WB99PTY8rh2PkCNwH9KzNygXPvTBz3yrU RVaJZWZ6kT/op6tLLk+bUc09dPTWAkEnZnRfouWb420f4QGb1yscgfWUH+21M6bUuedL61XVw72Xh +Dt+pcjEG/8BPS4t3b8ObtHo3F+ySE1+PLtU2HHrJEnFTEQUpZg+IBKX2SqbWFUh+YMOICxsNaI/M 3GmaIJ5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhsZG-00000000eF5-1R1v; Wed, 06 Mar 2024 14:48:26 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhsZB-00000000eBp-3Qee; Wed, 06 Mar 2024 14:48:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7F3DFCE1752; Wed, 6 Mar 2024 14:48:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42FFAC433F1; Wed, 6 Mar 2024 14:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709736495; bh=LKxAHNk2aLDWzzV1w2tW3dpSb8kzakIi8zhJRlDYp30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lXBlgeaeEd838cjSpXB5fqRMp0JDlOUS2RNQONh2ebnE3caajbq4gcz5fgrUUrSyU JDGeWAMG9Bd3x0Q0Zixif0b5VboyKVsI8uWeQeIvZPuadhN2GnG1MJasnaniRuvn/x A8RtYP6ecWpHi87rDDNV4VrS9FhOIwMilZU1k03FhdKOZ8eXDrbJ5AdHY5yCNPPldE hnxsilPlv7krDOXsoX6v5EEUo793kDnpUYR48kQKHhlrqJMcltGCEs5wkqN1KHlUnW 6kw8Bsa/Ah24iuGlq+MLiZgTuYSE7GBNJ3pm6O0Th8G+8NfhuQFFsJ+5VZJxmLi0KX FslSnN+FajSng== Date: Wed, 6 Mar 2024 15:48:13 +0100 From: Maxime Ripard To: Alexander Stein Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Maarten Lankhorst , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sandor Yu , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com, Dmitry Baryshkov Subject: Re: [PATCH v15 2/8] phy: Add HDMI configuration options Message-ID: <20240306-inquisitive-funny-bull-017550@houat> References: <20240306101625.795732-1-alexander.stein@ew.tq-group.com> <20240306101625.795732-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 In-Reply-To: <20240306101625.795732-3-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240306_064822_215735_0837FAB3 X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4720274480655663154==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============4720274480655663154== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wazjs4qrv6r7qq5x" Content-Disposition: inline --wazjs4qrv6r7qq5x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Alexander, On Wed, Mar 06, 2024 at 11:16:19AM +0100, Alexander Stein wrote: > From: Sandor Yu >=20 > Allow HDMI PHYs to be configured through the generic > functions through a custom structure added to the generic union. >=20 > The parameters added here are based on HDMI PHY > implementation practices. The current set of parameters > should cover the potential users. >=20 > Signed-off-by: Sandor Yu > Reviewed-by: Dmitry Baryshkov > Acked-by: Vinod Koul > --- > include/linux/phy/phy-hdmi.h | 24 ++++++++++++++++++++++++ > include/linux/phy/phy.h | 7 ++++++- > 2 files changed, 30 insertions(+), 1 deletion(-) > create mode 100644 include/linux/phy/phy-hdmi.h >=20 > diff --git a/include/linux/phy/phy-hdmi.h b/include/linux/phy/phy-hdmi.h > new file mode 100644 > index 0000000000000..b7de88e9090f0 > --- /dev/null > +++ b/include/linux/phy/phy-hdmi.h > @@ -0,0 +1,24 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright 2022 NXP > + */ > + > +#ifndef __PHY_HDMI_H_ > +#define __PHY_HDMI_H_ > + > +#include > +/** > + * struct phy_configure_opts_hdmi - HDMI configuration set > + * @pixel_clk_rate: Pixel clock of video modes in KHz. > + * @bpc: Maximum bits per color channel. > + * @color_space: Colorspace in enum hdmi_colorspace. > + * > + * This structure is used to represent the configuration state of a HDMI= phy. > + */ > +struct phy_configure_opts_hdmi { > + unsigned int pixel_clk_rate; > + unsigned int bpc; > + enum hdmi_colorspace color_space; > +}; Does the PHY actually care about the pixel clock rate, color space and formats, or does it only care about the character rate? Also, how would you handle pixel doubling? Maxime --wazjs4qrv6r7qq5x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZeiCLAAKCRDj7w1vZxhR xSnUAP41rpokDnniw6MdmXTRycs0PMI6TgR/87jmxzdVFERWKgEA/uUZeHTkC2sD 5V8zpf6ghz8P69W2+uKQN5GBGohZ5Ag= =ozbL -----END PGP SIGNATURE----- --wazjs4qrv6r7qq5x-- --===============4720274480655663154== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============4720274480655663154==--