From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 160E3C3DA4B for ; Mon, 15 Jul 2024 15:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MJatxAmiZrVq6+6Kt6mtqfOkhOzZ8C3b3119LWEGFx4=; b=IvDtJXjc6veb8X+mtpT5QwIC9c MEkqvgjZ6LaTSumph1VEicqNmLWDFdE9dxgtZKNLXjA5cualoFFW/cjxEHsacb0rlgiTN+nmQJvJa anoJ0i9p2VlAa8H2YuCREx7EY0Ay27GzlwGGgQTBtjooOzCyJ6R1tCjN2BrVJVTDpFAZF8QbS0Uws FyNB52kl1qQAnA29jL4hkY7scytheVBEjEauWqas54Ofq437Wpoh51/ba8zdq60TBTHUFdyQEiOSh Ml9cU6W/uKr/TfmUPMzpP69F7rRaFa/wndCFnFbBmrzyOGI6bB7O3mM0wZb9K4HJtB/br9NXCAGHp dR7i/XAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTNar-00000007Xgs-2HOW; Mon, 15 Jul 2024 15:26:25 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTNao-00000007Xfr-3poQ for linux-phy@lists.infradead.org; Mon, 15 Jul 2024 15:26:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4B96ACE102B; Mon, 15 Jul 2024 15:26:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9FF5C32782; Mon, 15 Jul 2024 15:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721057179; bh=sNW/aSHX8YqWmU4H5l4JY22GHRxmk/j7ao32iwDx0qQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ltCWfPdfZnEyL/P+J/m5VDzukXMca/1bVQAaZkeIJNR6CE/Z700sIcX0KNGiJceuu aRN+0QaIyjm2F/I+vdOGhrR9U3LSB0ZBOxFgoEDbmN8tS0B43NpTp/cSyD5vh3P1/V LQcoUgFXK74LUfvIKqpoR/yMLvvEXZEjdKXwF4QSUCYAPTU73Ef4oMfmUcEs2CoDOL xkCmuPCmLQnoGoByhA6THeRTfXISmzgoCtz+gbiJWsrWPheRpSZgHrHuqgIJjnrKA7 er6gwtuB4zbLASUosYTZ1iaA1WQGv3/cu8vZoRPgxSyYqSjwJgfVml2upejvxVmUXn gQKb5ZOHQ/aOw== Date: Mon, 15 Jul 2024 16:26:12 +0100 From: Conor Dooley To: Marc Gonzalez Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Arnaud Vrac , Pierre-Hugues Husson , Jeffrey Hugo Subject: Re: [PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible Message-ID: <20240715-trickery-spongy-c9d8e246b4cc@spud> References: <20240715-hdmi-tx-v6-0-d27f029627ad@freebox.fr> <20240715-hdmi-tx-v6-3-d27f029627ad@freebox.fr> MIME-Version: 1.0 In-Reply-To: <20240715-hdmi-tx-v6-3-d27f029627ad@freebox.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_082623_152655_75063D26 X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8548766318275781885==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============8548766318275781885== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OHR+9gzr+luxGuOP" Content-Disposition: inline --OHR+9gzr+luxGuOP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > Current driver already supports the msm8998 HDMI TX. > We just need to add the compatible string. Why is this required when the driver change suggests that this device is compatible with the existing 8974? >=20 > Signed-off-by: Marc Gonzalez > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/h= dmi.c > index 24abcb7254cc4..0bfee41c2e71a 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -549,6 +549,7 @@ static void msm_hdmi_dev_remove(struct platform_devic= e *pdev) > } > =20 > static const struct of_device_id msm_hdmi_dt_match[] =3D { > + { .compatible =3D "qcom,hdmi-tx-8998", .data =3D &hdmi_tx_8974_config }, > { .compatible =3D "qcom,hdmi-tx-8996", .data =3D &hdmi_tx_8974_config }, > { .compatible =3D "qcom,hdmi-tx-8994", .data =3D &hdmi_tx_8974_config }, > { .compatible =3D "qcom,hdmi-tx-8084", .data =3D &hdmi_tx_8974_config }, >=20 > --=20 > 2.34.1 >=20 --OHR+9gzr+luxGuOP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZpU/lAAKCRB4tDGHoIJi 0t3VAQCHN0LZCGVHMJwWGIelEtEm/eH6wIS85GY5SnC33zqgnAEA5k/oMJgRULQi RaUAxvbASVC26bdW+BxCiMRezUdxewY= =7Wal -----END PGP SIGNATURE----- --OHR+9gzr+luxGuOP-- --===============8548766318275781885== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============8548766318275781885==--