linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: kishon@kernel.org, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
	dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v3] phy: qcom: qmp: Add debug prints for register writes
Date: Thu, 1 Aug 2024 12:30:26 +0530	[thread overview]
Message-ID: <20240801070026.GB3705@thinkpad> (raw)
In-Reply-To: <172249532035.256913.2685367794999812971.b4-ty@kernel.org>

On Thu, Aug 01, 2024 at 12:25:20PM +0530, Vinod Koul wrote:
> 
> On Wed, 31 Jul 2024 20:55:48 +0530, Manivannan Sadhasivam wrote:
> > These register prints are useful to validate the init sequence against the
> > Qcom internal documentation and also to share with the Qcom hw engineers to
> > debug issues related to PHY.
> > 
> > Sample debug prints:
> > 
> > qcom-qmp-pcie-phy 1c0e000.phy: Writing Reg: QSERDES_V5_COM_SYSCLK_EN_SEL Offset: 0x0094 Val: 0xd9
> > qcom-qmp-pcie-phy 1c0e000.phy: Writing Reg: QSERDES_V5_COM_HSCLK_SEL Offset: 0x0158 Val: 0x11
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] phy: qcom: qmp: Add debug prints for register writes
>       commit: 4e92d504475ea5841716ad775f412342520a3d26
> 

Thanks! Bjorn spotted that it is worth making 'char *name' a const. Can you
please ammend the commit?

- Mani

-- 
மணிவண்ணன் சதாசிவம்

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2024-08-01  7:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 15:25 [PATCH v3] phy: qcom: qmp: Add debug prints for register writes Manivannan Sadhasivam
2024-07-31 15:32 ` Dmitry Baryshkov
2024-08-01  6:55 ` Vinod Koul
2024-08-01  7:00   ` Manivannan Sadhasivam [this message]
2024-08-04 16:39     ` Vinod Koul
2024-08-05 14:06       ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240801070026.GB3705@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kishon@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).