From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C63EC3DA7F for ; Mon, 12 Aug 2024 15:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hq/9CBx+I17jq8bSY+sEbtyAmT0spulqZA1yrxUmhKU=; b=kziEaY0naDLRr+KwtbyoiYS0/O T8Ybw/PSF67Wjjco8iq/WNIVjfEzW7JXmZXW8qUINvUlLV3L14JSHB4F6JGJUI6vXA5r9251hBgvX /Q+4wSFnFfbT6K9yZjml9IOdGlUUZz6C7f4I+th50P66njnyJ+lUClfdRIV+thx2BtnZ5zF+NDpF5 Q3t4Y3cWZCpawvia8/ynIky4OJRcMpJ15eb8mMGSs+STbYkkYttZBwJhhlentEXElbVslsECn19aV /2nJSboi/OyVxY9DTcTXpaQXxIUTCamAeZu5xRpZtAga2N+AkPqA6+HyqJcu+YjCT4ioejUmAZVlS glU6STWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdXOd-00000000oMC-0VOH; Mon, 12 Aug 2024 15:55:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdXOZ-00000000oLm-3Jki; Mon, 12 Aug 2024 15:55:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1544960FC7; Mon, 12 Aug 2024 15:55:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6098DC32782; Mon, 12 Aug 2024 15:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723478142; bh=fIxgfU9U7UdKHCzgTt5JxPxYSDRiI+jpNpkMi6cCmNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P3mgSpRiCH/hfVz2HIjVM3C3Yq1lKI/jniZJcW7Ur61Ag1fqi65ipjx2ct84DMI7M ysFCCNySYeQc9/SjndDB+u/vUZB6yel/3PTpuALkdKCzgb4fEN+R4JpiF47QioSeDx q6hQE6XJuufABIB5Cyn/PVzhgYEyCxcpi8w73daUvRcKkqS+mhH0QCfPlsLZ70vXxU 1maqNbGWxk3KsNl93e3FEmNsxc/oM6locRh/VSratxEfDtPff5xHOOblWkXV1nLL82 JFWjibQXr6QkjDKkLp5iLrFxtvilJGf/NEtL1Zakmnt3L2hh5WyJ0Sx07x7rOmUZfs QkQN7t4vp1Idw== Date: Mon, 12 Aug 2024 16:55:38 +0100 From: Conor Dooley To: Jan Kiszka Cc: Minda Chen , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v2 1/3] dt-bindings: phy: jh7110-usb-phy: Add sys-syscon property Message-ID: <20240812-overstuff-skirt-7a8aabbcdc6f@spud> References: <30f3ca9f6bd788e16767b36aa22c0e9dc4d1c6a4.1723472153.git.jan.kiszka@siemens.com> MIME-Version: 1.0 In-Reply-To: <30f3ca9f6bd788e16767b36aa22c0e9dc4d1c6a4.1723472153.git.jan.kiszka@siemens.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_085543_956461_1DFF2F6D X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7197319549015307311==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============7197319549015307311== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LtVVHt/+tPGAV+JK" Content-Disposition: inline --LtVVHt/+tPGAV+JK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 12, 2024 at 04:15:51PM +0200, Jan Kiszka wrote: > From: Jan Kiszka >=20 > Analogously to the PCI PHY, access to sys_syscon is needed to connect > the USB PHY to its controller. >=20 > Signed-off-by: Jan Kiszka > Reviewed-by: Rob Herring (Arm) > --- > CC: Rob Herring > CC: Krzysztof Kozlowski > CC: Conor Dooley > --- > .../bindings/phy/starfive,jh7110-usb-phy.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-ph= y.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > index 269e9f9f12b6..eaf0050c6f17 100644 > --- a/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > @@ -19,6 +19,16 @@ properties: > "#phy-cells": > const: 0 > =20 > + starfive,sys-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to System Register Controller sys_sysco= n node. > + - description: PHY connect offset of SYS_SYSCONSAIF__SYSCFG re= gister for USB PHY. Why is having a new property for this required? The devicetree only has a single usb phy, so isn't it sufficient to look up the syscon by compatible, rather than via phandle + offset? > + description: > + The phandle to System Register Controller syscon node and the PHY = connect offset > + of SYS_SYSCONSAIF__SYSCFG register. Connect PHY to USB controller. > + > clocks: > items: > - description: PHY 125m > @@ -47,4 +57,5 @@ examples: > <&stgcrg 6>; > clock-names =3D "125m", "app_125m"; > #phy-cells =3D <0>; > + starfive,sys-syscon =3D <&sys_syscon 0x18>; > }; > --=20 > 2.43.0 >=20 --LtVVHt/+tPGAV+JK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZrowegAKCRB4tDGHoIJi 0gXFAP9irfiKqj3CaOoVEdmxFBQbHAu8wbJBdmXuGodai0OMaQEAp0i//vC20L1l o+8FpvJ1Mt/ZC28yMFhDKZtipTS5rgc= =rBq+ -----END PGP SIGNATURE----- --LtVVHt/+tPGAV+JK-- --===============7197319549015307311== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============7197319549015307311==--