From: Hans de Goede <hdegoede@redhat.com>
To: "Sebastian Reichel" <sre@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Enric Balletbo Serra <enric.balletbo@collabora.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-phy@lists.infradead.org
Subject: [PATCH 3/6] power: supply: rt9467-charger: Remove "usb_type" property write support
Date: Sat, 31 Aug 2024 16:20:36 +0200 [thread overview]
Message-ID: <20240831142039.28830-4-hdegoede@redhat.com> (raw)
In-Reply-To: <20240831142039.28830-1-hdegoede@redhat.com>
The "usb_type" property must be read-only for charger power-supply devices,
see: Documentation/ABI/testing/sysfs-class-power.
But the rt9467 driver allows writing 0/1 to it to disable/enable charging.
Other charger drivers use the "status" property for this and the rt9467
code also allows writing 0/1 to its "status" property and this does
the exact same thing as writing 0/1 to its "usb_type" property.
Drop write support for the "usb_type" property making it readonly to match
the ABI documentation. If userspace wants to disable/enable charging it
can use the "status" property for this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/power/supply/rt9467-charger.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c
index fdfdc83ab045..f935bd761ac1 100644
--- a/drivers/power/supply/rt9467-charger.c
+++ b/drivers/power/supply/rt9467-charger.c
@@ -745,8 +745,6 @@ static int rt9467_psy_set_property(struct power_supply *psy,
RT9467_RANGE_IPREC, val->intval);
case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
return rt9467_psy_set_ieoc(data, val->intval);
- case POWER_SUPPLY_PROP_USB_TYPE:
- return regmap_field_write(data->rm_field[F_USBCHGEN], val->intval);
default:
return -EINVAL;
}
@@ -764,7 +762,6 @@ static int rt9467_chg_prop_is_writeable(struct power_supply *psy,
case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
- case POWER_SUPPLY_PROP_USB_TYPE:
return 1;
default:
return 0;
--
2.46.0
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-08-31 14:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 14:20 [PATCH 0/6] power: supply: Change usb_types from an array into a bitmask Hans de Goede
2024-08-31 14:20 ` [PATCH 1/6] power: supply: "usb_type" property may be written to Hans de Goede
2024-09-03 7:04 ` Greg Kroah-Hartman
2024-08-31 14:20 ` [PATCH 2/6] power: supply: ucs1002: Adjust ucs1002_set_usb_type() to accept string values Hans de Goede
2024-08-31 14:20 ` Hans de Goede [this message]
2024-08-31 14:20 ` [PATCH 4/6] power: supply: sysfs: Add power_supply_show_enum_with_available() helper Hans de Goede
2024-08-31 14:20 ` [PATCH 5/6] power: supply: sysfs: Move power_supply_show_enum_with_available() up Hans de Goede
2024-08-31 14:20 ` [PATCH 6/6] power: supply: Change usb_types from an array into a bitmask Hans de Goede
2024-09-03 7:04 ` Greg Kroah-Hartman
2024-09-03 8:27 ` Hans de Goede
2024-09-03 8:32 ` Greg Kroah-Hartman
2024-09-03 21:57 ` [PATCH 0/6] " Sebastian Reichel
2024-09-03 22:04 ` Sebastian Reichel
2024-09-04 9:26 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240831142039.28830-4-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andrew.smirnov@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox