From: Daniel Machon <daniel.machon@microchip.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
<UNGLinuxDriver@microchip.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-phy@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 8/9] dt-bindings: phy: sparx5: document lan969x in sparx5 dt-bindings
Date: Mon, 9 Sep 2024 09:43:24 +0000 [thread overview]
Message-ID: <20240909094324.u2aahgnrmxkxt7fc@DEN-DL-M70577> (raw)
In-Reply-To: <ee4d4375-873b-4b9c-b694-f0191e5c2c54@kernel.org>
> >>> compatible:
> >>> - const: microchip,sparx5-serdes
> >>> + enum:
> >>> + - microchip,sparx5-serdes
> >>> + - microchip,lan969x-serdes
> >>
> >> It seems there is no lan969x SoC/chip. Are you sure you are using
> >> correct naming, matching what kernel is using? Maybe you just sent
> >> whatever you had in downstream (hint: that's never a good idea).
> >
> > You are right. There is no upstream support for lan969x SoC yet. The
> > upstreaming of the lan969x SoC has just begun, and this series is part
> > of that upstreaming effort. The lan969x switch driver (not submitted
> > yet) will depend on this SERDES driver, however, their functionality is
> > really independent of each other. That is why I am also upstreaming the
> > SERDES- and switch driver series independent of each other.
>
> That's not exactly my point. Becayse lan969x appears. I claim you use
> incorrect name, so are you sure you do not use wildcards?
> Best regards,
> Krzysztof
Ahh.
So the problem is the 'x' in lan969x, right? I think we have a habbit of
documenting compatible strings like this in bindings. Anyway, what I can
do is document the different part numbers in the bindings: lan9691,
lan9692, lan9693, lan9694, lan9696 and lan9698.
/Daniel
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-09-09 10:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 12:52 [PATCH 0/9] phy: sparx5-serdes: add support for lan969x serdes driver Daniel Machon
2024-09-06 12:52 ` [PATCH 1/9] phy: sparx5-serdes: add support for private match data Daniel Machon
2024-09-06 12:52 ` [PATCH 2/9] phy: sparx5-serdes: add constants to " Daniel Machon
2024-09-06 12:52 ` [PATCH 3/9] phy: sparx5-serdes: add constant for the number of CMU's Daniel Machon
2024-09-06 12:52 ` [PATCH 4/9] phy: sparx5-serdes: add ops to match data Daniel Machon
2024-09-06 12:52 ` [PATCH 5/9] phy: sparx5-serdes: add function for getting the CMU index Daniel Machon
2024-09-06 12:52 ` [PATCH 6/9] phy: sparx5-serdes: add indirection layer to register macros Daniel Machon
2024-09-06 12:52 ` [PATCH 7/9] phy: sparx5-serdes: add support for branching on chip type Daniel Machon
2024-09-06 12:52 ` [PATCH 8/9] dt-bindings: phy: sparx5: document lan969x in sparx5 dt-bindings Daniel Machon
2024-09-06 12:59 ` Krzysztof Kozlowski
2024-09-09 8:22 ` Daniel Machon
2024-09-09 8:35 ` Krzysztof Kozlowski
2024-09-09 9:43 ` Daniel Machon [this message]
2024-09-09 10:42 ` Krzysztof Kozlowski
2024-09-06 12:52 ` [PATCH 9/9] phy: lan969x-serdes: add support for lan969x serdes driver Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909094324.u2aahgnrmxkxt7fc@DEN-DL-M70577 \
--to=daniel.machon@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox