linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] phy: tegra: xusb: Add error pointer check in xusb.c
@ 2024-09-30 19:11 Dipendra Khadka
  2024-10-21 12:50 ` Thierry Reding
  2024-10-22  5:32 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Dipendra Khadka @ 2024-09-30 19:11 UTC (permalink / raw)
  To: jckuo, vkoul, kishon, thierry.reding, jonathanh, nkristam
  Cc: Dipendra Khadka, linux-phy, linux-tegra, linux-kernel

Add error pointer check after tegra_xusb_find_lane().

Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
---
 drivers/phy/tegra/xusb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index cfdb54b6070a..342f5ccf611d 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -699,6 +699,8 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
 		return -ENOMEM;
 
 	lane = tegra_xusb_find_lane(port->padctl, "usb2", port->index);
+	if (IS_ERR(lane))
+		return PTR_ERR(lane);
 
 	/*
 	 * Assign phy dev to usb-phy dev. Host/device drivers can use phy
-- 
2.43.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: tegra: xusb: Add error pointer check in xusb.c
  2024-09-30 19:11 [PATCH] phy: tegra: xusb: Add error pointer check in xusb.c Dipendra Khadka
@ 2024-10-21 12:50 ` Thierry Reding
  2024-10-22  5:32 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2024-10-21 12:50 UTC (permalink / raw)
  To: Dipendra Khadka
  Cc: jckuo, vkoul, kishon, jonathanh, nkristam, linux-phy, linux-tegra,
	linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]

On Mon, Sep 30, 2024 at 07:11:00PM +0000, Dipendra Khadka wrote:
> Add error pointer check after tegra_xusb_find_lane().
> 
> Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")
> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
> ---
>  drivers/phy/tegra/xusb.c | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: tegra: xusb: Add error pointer check in xusb.c
  2024-09-30 19:11 [PATCH] phy: tegra: xusb: Add error pointer check in xusb.c Dipendra Khadka
  2024-10-21 12:50 ` Thierry Reding
@ 2024-10-22  5:32 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-10-22  5:32 UTC (permalink / raw)
  To: jckuo, kishon, thierry.reding, jonathanh, nkristam,
	Dipendra Khadka
  Cc: linux-phy, linux-tegra, linux-kernel


On Mon, 30 Sep 2024 19:11:00 +0000, Dipendra Khadka wrote:
> Add error pointer check after tegra_xusb_find_lane().
> 
> 

Applied, thanks!

[1/1] phy: tegra: xusb: Add error pointer check in xusb.c
      commit: e70d2677ef4088d59158739d72b67ac36d1b132b

Best regards,
-- 
~Vinod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-22  5:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 19:11 [PATCH] phy: tegra: xusb: Add error pointer check in xusb.c Dipendra Khadka
2024-10-21 12:50 ` Thierry Reding
2024-10-22  5:32 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).