Re: [PATCH v6 3/8] dt-bindings: PCI: qcom,pcie-x1e80100: Add 'global' interrupt

Krzysztof Kozlowski
2024-10-11T14:40:43Z

On 11/10/2024 16:33, Krzysztof Kozlowski wrote:
> On Fri, Oct 11, 2024 at 03:41:37AM -0700, Qiang Yu wrote:
>> Document 'global' SPI interrupt along with the existing MSI interrupts so
>> that QCOM PCIe RC driver can make use of it to get events such as PCIe
>> link specific events, safety events, etc.
>
> Describe the hardware, not what the driver will do.
>
>>
>> Though adding a new interrupt will break the ABI, it is required to
>> accurately describe the hardware.
>
> That's poor reason. Hardware was described and missing optional piece
> (because according to your description above everything was working
> fine) is not needed to break ABI.
>
> Sorry, if your driver changes the ABI for this poor reason.
>
> NAK.
>

Plus you did not test DTS, not fixed existing users.

That's v6, so we assume you already know how to test it and do the
testing before posting new versions.

Best regards,
Krzysztof