* [PATCH] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies
@ 2024-10-15 12:14 Johan Hovold
2024-10-15 12:27 ` Neil Armstrong
2024-10-17 15:31 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Johan Hovold @ 2024-10-15 12:14 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, Dmitry Baryshkov, Abel Vesa,
Neil Armstrong, linux-arm-msm, linux-phy, linux-kernel,
Johan Hovold
The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting
one. This also avoids the follow warning at boot:
qcom-qmp-pcie-phy 1bfc000.phy: supply vdda-qref not found, using dummy regulator
Fixes: 9dab00ee9544 ("phy: qcom: qmp-pcie: Add Gen4 4-lanes mode for X1E80100")
Fixes: 606060ce8fd0 ("phy: qcom-qmp-pcie: Add support for X1E80100 g3x2 and g4x2 PCIE")
Cc: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index f71787fb4d7e..36aaac34e6c6 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -3661,8 +3661,8 @@ static const struct qmp_phy_cfg x1e80100_qmp_gen4x2_pciephy_cfg = {
.reset_list = sdm845_pciephy_reset_l,
.num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l),
- .vreg_list = sm8550_qmp_phy_vreg_l,
- .num_vregs = ARRAY_SIZE(sm8550_qmp_phy_vreg_l),
+ .vreg_list = qmp_phy_vreg_l,
+ .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
.regs = pciephy_v6_regs_layout,
.pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL,
@@ -3695,8 +3695,8 @@ static const struct qmp_phy_cfg x1e80100_qmp_gen4x4_pciephy_cfg = {
.reset_list = sdm845_pciephy_reset_l,
.num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l),
- .vreg_list = sm8550_qmp_phy_vreg_l,
- .num_vregs = ARRAY_SIZE(sm8550_qmp_phy_vreg_l),
+ .vreg_list = qmp_phy_vreg_l,
+ .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
.regs = pciephy_v6_regs_layout,
.pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL,
--
2.45.2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies
2024-10-15 12:14 [PATCH] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies Johan Hovold
@ 2024-10-15 12:27 ` Neil Armstrong
2024-10-17 15:31 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2024-10-15 12:27 UTC (permalink / raw)
To: Johan Hovold, Vinod Koul
Cc: Kishon Vijay Abraham I, Dmitry Baryshkov, Abel Vesa,
linux-arm-msm, linux-phy, linux-kernel
On 15/10/2024 14:14, Johan Hovold wrote:
> The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting
> one. This also avoids the follow warning at boot:
>
> qcom-qmp-pcie-phy 1bfc000.phy: supply vdda-qref not found, using dummy regulator
>
> Fixes: 9dab00ee9544 ("phy: qcom: qmp-pcie: Add Gen4 4-lanes mode for X1E80100")
> Fixes: 606060ce8fd0 ("phy: qcom-qmp-pcie: Add support for X1E80100 g3x2 and g4x2 PCIE")
> Cc: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> index f71787fb4d7e..36aaac34e6c6 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> @@ -3661,8 +3661,8 @@ static const struct qmp_phy_cfg x1e80100_qmp_gen4x2_pciephy_cfg = {
>
> .reset_list = sdm845_pciephy_reset_l,
> .num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l),
> - .vreg_list = sm8550_qmp_phy_vreg_l,
> - .num_vregs = ARRAY_SIZE(sm8550_qmp_phy_vreg_l),
> + .vreg_list = qmp_phy_vreg_l,
> + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
> .regs = pciephy_v6_regs_layout,
>
> .pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL,
> @@ -3695,8 +3695,8 @@ static const struct qmp_phy_cfg x1e80100_qmp_gen4x4_pciephy_cfg = {
>
> .reset_list = sdm845_pciephy_reset_l,
> .num_resets = ARRAY_SIZE(sdm845_pciephy_reset_l),
> - .vreg_list = sm8550_qmp_phy_vreg_l,
> - .num_vregs = ARRAY_SIZE(sm8550_qmp_phy_vreg_l),
> + .vreg_list = qmp_phy_vreg_l,
> + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
> .regs = pciephy_v6_regs_layout,
>
> .pwrdn_ctrl = SW_PWRDN | REFCLK_DRV_DSBL,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies
2024-10-15 12:14 [PATCH] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies Johan Hovold
2024-10-15 12:27 ` Neil Armstrong
@ 2024-10-17 15:31 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-10-17 15:31 UTC (permalink / raw)
To: Johan Hovold
Cc: Kishon Vijay Abraham I, Dmitry Baryshkov, Abel Vesa,
Neil Armstrong, linux-arm-msm, linux-phy, linux-kernel
On Tue, 15 Oct 2024 14:14:06 +0200, Johan Hovold wrote:
> The PCIe PHYs on x1e80100 do not a have a qref supply so stop requesting
> one. This also avoids the follow warning at boot:
>
> qcom-qmp-pcie-phy 1bfc000.phy: supply vdda-qref not found, using dummy regulator
>
>
Applied, thanks!
[1/1] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies
commit: 031b46b4729b1a6ff8484a1e29cdb41b710ed740
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-17 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 12:14 [PATCH] phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies Johan Hovold
2024-10-15 12:27 ` Neil Armstrong
2024-10-17 15:31 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox