From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36E1FC02185 for ; Fri, 17 Jan 2025 10:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6UzdrHE9rDd0M5c1kEX9eJlS+fDkB1aOPkrFxgjSD2k=; b=HKGlUiJuoYQPA7 ILZwNxyMPvKSfC1loSNluBh4u65uwYDqP1N2cdTG290E0iJ/prndhc0eWsbdwPA/0pR3BuAUD0aEw YTcplVsMhhoptCgT2NbTM/DNe1fhBJOZZDoW2SZ3MlieJVvnPPJoWfs2wwiBAKHyO/xZeFKcpetIC AIFwCyiNWiXAnMtmlXS+v9Tdbxz1IM8Q6SLbeuA7VlXV63wxwF1MX9cZT6X5tCQ25dXiuQycpCwwc ujY0v0j1fZK8ieeMNSNxhC8qedPfCmtS2kSC/VwvAOh1cSLKWxqbuuOQ3c4lgGJ+CZ2fu0hVj6+cR w19ddXeqDPf3Y3vEpf7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYjms-000000003R5-46Q0; Fri, 17 Jan 2025 10:41:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYjlb-000000003Cn-12w3; Fri, 17 Jan 2025 10:39:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3403D1476; Fri, 17 Jan 2025 02:40:21 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D2753F7B4; Fri, 17 Jan 2025 02:39:49 -0800 (PST) Date: Fri, 17 Jan 2025 10:39:41 +0000 From: Andre Przywara To: Vinod Koul Cc: Andras Szemzo , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Linus Walleij , Philipp Zabel , Maxime Ripard , Kishon Vijay Abraham I , Ulf Hansson , Paul Walmsley , Palmer Dabbelt , Albert Ou , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Florian Fainelli , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 10/12] dt-bindings: phy: allwinner: add v853 usb phy Message-ID: <20250117103941.7f9bda7b@donnerap.manchester.arm.com> In-Reply-To: References: <20250110123923.270626-1-szemzo.andras@gmail.com> <20250110123923.270626-11-szemzo.andras@gmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250117_023955_338308_96E54E01 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Wed, 15 Jan 2025 07:51:50 +0000 Vinod Koul wrote: > On 10-01-25, 13:39, Andras Szemzo wrote: > > Document Allwinner v853 USB phy. > > > > Signed-off-by: Andras Szemzo > > --- > > .../phy/allwinner,sun8i-v853-usb-phy.yaml | 89 +++++++++++++++++++ > > 1 file changed, 89 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml > > new file mode 100644 > > index 000000000000..773c3f476db8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml > > @@ -0,0 +1,89 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/allwinner,sun8i-v853-usb-phy.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner V853 USB PHY > > + > > +maintainers: > > + - Chen-Yu Tsai > > + - Maxime Ripard > > + > > +properties: > > + "#phy-cells": > > + const: 1 > > + > > + compatible: > > + const: > > + - allwinner,sun8i-v853-usb-phy > > Does this really need a new binding document, if so why... Cant this be > added to one of the existing docs which driver uses? The USB-PHY bindings don't differ too much on a first glance, but still enough in nasty details (number of PHYs supported, number of clocks required, etc.) to make a joint binding basically unreadable (we tried that). That's why we opted to have separate bindings. Now I believe it's worth to look for the closest existing binding, and just put the compatible in there, in the hope we don't need much else, and that it still stays readable. Cheers, Andre -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy