From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A5CDC02185 for ; Sat, 18 Jan 2025 15:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZFQ0XA0DHt/SnHJXy/CWbXSU/WumtPfl3nb/4lXWPa4=; b=qcgKsDPaiwfD2u u2+RDdBKtoGXy+Pe84XDGhCjh+SGrJdZ2lK3kH9PhWa0cZP006bbRoJ6uA8EMi5Ga+A0aRVP42l11 JTDQv2zQIG/aNgMPGCglYN9WZDSNu5ypXRW5njQByMiHwvOMpFwmoMRE2lk9YUgz3gt+6eQs17p/e XlWCDQ37RobpdXfG4LInHmqflD3dil54HXBV8A49e8D8GXjkm+BmK7p+3MgjwrNSLyspR/WC7kA2E ul9kTAQL0ow7D79CCk0CyEeEqEs8BSsMpJ8/UY18ARb/ztxJ0J3A+IlVsPO9m+0pq2g7yoTYtlWvT vz2e9R1S0sYRxdEL+hVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tZAkC-00000002c8l-1LFt; Sat, 18 Jan 2025 15:28:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tZAk9-00000002c7T-3VRd for linux-phy@lists.infradead.org; Sat, 18 Jan 2025 15:28:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A0ED85C5B33; Sat, 18 Jan 2025 15:27:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E57CC4CED1; Sat, 18 Jan 2025 15:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737214093; bh=ryyLacW9mUm6gv/8X5dzDmrL7n4I/9bGy9c43D05QVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=keLHsHQ9Q8xvzD4M9nS7m97wZhtEdjXv0XegesIUrovGtDrYGHTyNFeDmlfZAsX4j vyagkYlB21pRjl47Q7PwEVu+Fni9eZ0fx9VPmqw2tDoJNfsTHYKhsQ6Pwz2ModDMsM 8AshIgWq7YyzKChl2KBQNrL7NAoflrespI0NPsdJBaP2pWXK1zMBLdXvTgZjGuS7Fq v6dpXBVAlD8IAXKD+x5bn8F4XC0nWflFmpazE64avaolwlsImmBns4KjCdyy/xR07R OYBA1WIlNUwaNJcEIh80H/n/2UPSk9iJUH+s0xz4OgzgpBfOj3celY4OSFCin2/Rcs xJIAILpAtTwAw== Date: Sat, 18 Jan 2025 16:28:09 +0100 From: Krzysztof Kozlowski To: Melody Olvera Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Bjorn Andersson , Andy Gross , Konrad Dybcio , Satya Durga Srinivasu Prabhala , Trilok Soni , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nitin Rawat , Manish Pandey Subject: Re: [PATCH 4/5] arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC Message-ID: <20250118-voracious-ninja-gazelle-ed2c68@krzk-bin> References: <20250113-sm8750_ufs_master-v1-0-b3774120eb8c@quicinc.com> <20250113-sm8750_ufs_master-v1-4-b3774120eb8c@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250113-sm8750_ufs_master-v1-4-b3774120eb8c@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250118_072813_920681_C203C122 X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Jan 13, 2025 at 01:46:27PM -0800, Melody Olvera wrote: > From: Nitin Rawat > > Add UFS host controller and PHY nodes for SM8750 SoC. > > Co-developed-by: Manish Pandey > Signed-off-by: Manish Pandey > Signed-off-by: Nitin Rawat > Signed-off-by: Melody Olvera > --- > arch/arm64/boot/dts/qcom/sm8750.dtsi | 81 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi > index 3bbd7d18598ee0a3a0d5130c03a3166e1fc14d82..20690c102244b337847a6482dd83c37e19746de9 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > / { > interrupt-parent = <&intc>; > @@ -1939,6 +1940,86 @@ mmss_noc: interconnect@1780000 { > #interconnect-cells = <2>; > }; > > + ufs_mem_phy: phy@1d80000 { > + compatible = "qcom,sm8750-qmp-ufs-phy"; > + reg = <0x0 0x01d80000 0x0 0x2000>; > + > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, > + <&tcsrcc TCSR_UFS_CLKREF_EN>; > + clock-names = "ref", Since there is going to be resend, let's save me one commit afterwards: Incorrect space after '='. There is always only one before and one after. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy