From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kaustabh Chakraborty <kauschluss@disroot.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Vivek Gautam <gautam.vivek@samsung.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Sergey Lisov <sleirsgoevy@gmail.com>,
linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] phy: exynos5-usbdrd: fix MPLL_MULTIPLIER and SSC_REFCLKSEL masks in refclk
Date: Wed, 5 Feb 2025 09:53:25 +0100 [thread overview]
Message-ID: <20250205-nice-amiable-lynx-a616b0@krzk-bin> (raw)
In-Reply-To: <20250204-exynos7870-usbphy-v1-1-f30a9857efeb@disroot.org>
On Tue, Feb 04, 2025 at 02:10:12AM +0530, Kaustabh Chakraborty wrote:
> In exynos5_usbdrd_{pipe3,utmi}_set_refclk(), the masks
> PHYCLKRST_MPLL_MULTIPLIER_MASK and PHYCLKRST_SSC_REFCLKSEL_MASK are not
> inverted when applied to the register values. Fix it.
>
> Fixes: 59025887fb08 ("phy: Add new Exynos5 USB 3.0 PHY driver")
Missing Cc-stable and this should be sent separately.
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index c421b495eb0fe4396d76f8c9d7c198ad7cd08869..4a108fdab118c0edd76bd88dc9dbf6a498e064b3 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -488,9 +488,9 @@ exynos5_usbdrd_pipe3_set_refclk(struct phy_usb_instance *inst)
> reg |= PHYCLKRST_REFCLKSEL_EXT_REFCLK;
>
> /* FSEL settings corresponding to reference clock */
> - reg &= ~PHYCLKRST_FSEL_PIPE_MASK |
> - PHYCLKRST_MPLL_MULTIPLIER_MASK |
> - PHYCLKRST_SSC_REFCLKSEL_MASK;
> + reg &= ~(PHYCLKRST_FSEL_PIPE_MASK |
> + PHYCLKRST_MPLL_MULTIPLIER_MASK |
> + PHYCLKRST_SSC_REFCLKSEL_MASK);
> switch (phy_drd->extrefclk) {
> case EXYNOS5_FSEL_50MHZ:
> reg |= (PHYCLKRST_MPLL_MULTIPLIER_50M_REF |
> @@ -532,9 +532,9 @@ exynos5_usbdrd_utmi_set_refclk(struct phy_usb_instance *inst)
> reg &= ~PHYCLKRST_REFCLKSEL_MASK;
> reg |= PHYCLKRST_REFCLKSEL_EXT_REFCLK;
>
> - reg &= ~PHYCLKRST_FSEL_UTMI_MASK |
> - PHYCLKRST_MPLL_MULTIPLIER_MASK |
> - PHYCLKRST_SSC_REFCLKSEL_MASK;
> + reg &= ~(PHYCLKRST_FSEL_UTMI_MASK |
> + PHYCLKRST_MPLL_MULTIPLIER_MASK |
> + PHYCLKRST_SSC_REFCLKSEL_MASK);
> reg |= PHYCLKRST_FSEL(phy_drd->extrefclk);
This part does not set MPLL_MULTIPLIER and SSC_REFCLKSEL fields later,
but I also assume intention was to clear the fields.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-02-05 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 20:40 [PATCH 0/4] Introduce USBDRD-PHY support for Exynos7870 SoC Kaustabh Chakraborty
2025-02-03 20:40 ` [PATCH 1/4] phy: exynos5-usbdrd: fix MPLL_MULTIPLIER and SSC_REFCLKSEL masks in refclk Kaustabh Chakraborty
2025-02-05 8:53 ` Krzysztof Kozlowski [this message]
2025-02-03 20:40 ` [PATCH 2/4] phy: exynos5-usbdrd: use GENMASK and FIELD_PREP for Exynos5 PHY registers Kaustabh Chakraborty
2025-02-03 20:40 ` [PATCH 3/4] dt-bindings: phy: samsung,usb3-drd-phy: add exynos7870-usbdrd-phy compatible Kaustabh Chakraborty
2025-02-05 8:54 ` Krzysztof Kozlowski
2025-02-05 8:56 ` Krzysztof Kozlowski
2025-02-03 20:40 ` [PATCH 4/4] phy: exynos5-usbdrd: add exynos7870 USBDRD support Kaustabh Chakraborty
2025-02-11 17:48 ` Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205-nice-amiable-lynx-a616b0@krzk-bin \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=kauschluss@disroot.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sleirsgoevy@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox