From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A28AFC021B2 for ; Tue, 25 Feb 2025 12:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YrnEASMtx8IMIRSlyMzv8LZwtrpG4awSRqppiJH9cOk=; b=eo5bx7rnkzSfNh b4/dmd2ndiQ8G36NZkd4YvyPIYVQjLCB6knP58MsonAICkPJa0dwoCAOAcRklrMJq7VrZWBRXRuQb CNRHboKBavtao/PpoN7Ey80Z0tmZ8UdodJQkehOdeGCnz4Np2w247HMz8m9Xe74mxhUk9iRL7Y26g ziydChJYGKujrJMpAwVUTSs5AkVPkX4AXOK9x1EEmFrNTgOOtYYHBuFr7fFpui58OI2x83ivReM6b DahmINdK14cDNc99opwFzxLK40F3IJsyTxYbYauzYSZfgzk85KMZ5RKGq5XV58nrAC17PvP7YeV+6 tz0wZFSVMYRHDahm0fKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tmtxj-0000000HCT6-1YpX; Tue, 25 Feb 2025 12:22:59 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tmtOQ-0000000H59O-2XJ5; Tue, 25 Feb 2025 11:46:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 2EDF561239; Tue, 25 Feb 2025 11:46:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E92D7C4CEDD; Tue, 25 Feb 2025 11:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740483989; bh=4IIRoh5wb+/jIFP4g7aKueshVyB+l000sg+l64SSteI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jOiyrIO+unuve0eE7gyGrpzrY1t0WNOSfUpUXflagWiw1Wj+TfYH5+Gf6VghbxTRy lGVTtdUWHkiBQDmRih8snkWBDO+rI3j1anTpXteFXmxn585+oREVOnPZeh4+k/PsOh UXLIwJ1f8UJjC/a/FplnZrWb1APIe16KtPG63u+BjhLmgq0V7U/fk58FwQQi/GsnF9 jB4ZuVNweDB+2m4RWjwnDLn2huExQin9znUa3+keWKJ/yDGy1DXLVfN5hks64pP+vx Ea7TMIJw7sbjyaRvxdu+dHiFRM2QpHznJMW2sxsVySk3R/ehtXDJPMG981GSujsr29 BNFDAW4pKxL9A== Date: Tue, 25 Feb 2025 12:46:26 +0100 From: Krzysztof Kozlowski To: Ivaylo Ivanov Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/8] dt-bindings: phy: snps-eusb2: add exynos2200 support Message-ID: <20250225-conscious-spotted-ape-a71edd@krzk-bin> References: <20250223122227.725233-1-ivo.ivanov.ivanov1@gmail.com> <20250223122227.725233-3-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250223122227.725233-3-ivo.ivanov.ivanov1@gmail.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Sun, Feb 23, 2025 at 02:22:21PM +0200, Ivaylo Ivanov wrote: > Exynos 2200 makes use of the Synposys eUSB2 IP, so document it in the > binding. Unlike the currently documented Qualcomm SoCs, it doesn't provide > reset lines for reset control and uses more clocks. > > Signed-off-by: Ivaylo Ivanov Mismatched sob. Be sure you run checkpatch before posting. > --- > .../bindings/phy/snps,eusb2-phy.yaml | 64 +++++++++++++++++-- > 1 file changed, 57 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml > index 22c77968f..f4164db71 100644 > --- a/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml > @@ -23,6 +23,7 @@ properties: > - qcom,x1e80100-snps-eusb2-phy > - const: qcom,sm8550-snps-eusb2-phy > - const: qcom,sm8550-snps-eusb2-phy > + - const: samsung,exynos2200-snps-eusb2-phy > > reg: > maxItems: 1 > @@ -31,12 +32,12 @@ properties: > const: 0 > > clocks: > - items: > - - description: ref > + minItems: 1 > + maxItems: 3 > > clock-names: > - items: > - - const: ref > + minItems: 1 > + maxItems: 3 > > resets: > maxItems: 1 > @@ -58,11 +59,60 @@ required: > - compatible > - reg > - "#phy-cells" > - - clocks > - - clock-names > - vdd-supply > - vdda12-supply > - - resets > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm8550-snps-eusb2-phy > + > + then: > + properties: > + reg: > + maxItems: 1 I don't understand this. What's the top-level value here? > + > + clocks: > + items: > + - description: ref > + > + clock-names: > + items: > + - const: ref > + > + required: > + - clocks > + - clock-names > + - resets > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynos2200-snps-eusb2-phy > + > + then: > + properties: > + Drop blank line Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy