From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
dmitry.baryshkov@linaro.org, neil.armstrong@linaro.org,
abel.vesa@linaro.org, manivannan.sadhasivam@linaro.org,
lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
andersson@kernel.org, konradybcio@kernel.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, quic_qianyu@quicinc.com,
quic_krichai@quicinc.com, quic_vbadigan@quicinc.com
Subject: Re: [PATCH v5 1/6] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Update pcie phy bindings for sa8775p
Date: Wed, 7 May 2025 07:09:03 +0200 [thread overview]
Message-ID: <20250507-obedient-copperhead-from-arcadia-4b052e@kuoka> (raw)
In-Reply-To: <20250507031019.4080541-2-quic_ziyuzhan@quicinc.com>
On Wed, May 07, 2025 at 11:10:14AM GMT, Ziyue Zhang wrote:
> qcs8300 pcie1 phy use the same clocks as sa8775p, in the review comments
> of qcs8300 patches, gcc aux clock should be removed and replace it with
> phy_aux clock.So move "qcom,sa8775p-qmp-gen4x4-pcie-phy" compatible from
> 7 clocks' list to 6 clocks' list to solve the dtb check error.
>
> qcs8300 pcie phy only use 6 clocks, so move qcs8300 gen4x2 pcie phy
> compatible from 7 clocks' list to 6 clocks' list.
I don't understand any of this. You just submitted the bindings not so
far ago. Does this mean they were never tested?
What does it mean that gcc aux clock should be removed in the review
comments?
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-05-07 5:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 3:10 [PATCH v5 0/6] pci: qcom: Add QCS8300 PCIe support Ziyue Zhang
2025-05-07 3:10 ` [PATCH v5 1/6] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Update pcie phy bindings for sa8775p Ziyue Zhang
2025-05-07 5:09 ` Krzysztof Kozlowski [this message]
2025-05-07 7:18 ` Ziyue Zhang
2025-05-07 3:10 ` [PATCH v5 2/6] dt-bindings: PCI: qcom,pcie-sa8775p: document qcs8300 Ziyue Zhang
2025-05-07 5:10 ` Krzysztof Kozlowski
2025-05-07 8:19 ` Ziyue Zhang
2025-05-07 8:25 ` Krzysztof Kozlowski
2025-05-07 9:56 ` Qiang Yu
2025-05-07 10:03 ` Krzysztof Kozlowski
2025-05-07 10:07 ` Qiang Yu
2025-05-07 3:10 ` [PATCH v5 3/6] arm64: dts: qcom: qcs8300: enable pcie0 Ziyue Zhang
2025-05-07 3:10 ` [PATCH v5 4/6] arm64: dts: qcom: qcs8300-ride: enable pcie0 interface Ziyue Zhang
2025-05-07 3:10 ` [PATCH v5 5/6] arm64: dts: qcom: qcs8300: enable pcie1 Ziyue Zhang
2025-05-07 3:10 ` [PATCH v5 6/6] arm64: dts: qcom: qcs8300-ride: enable pcie1 interface Ziyue Zhang
2025-05-07 15:41 ` [PATCH v5 0/6] pci: qcom: Add QCS8300 PCIe support Rob Herring (Arm)
2025-05-11 22:33 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507-obedient-copperhead-from-arcadia-4b052e@kuoka \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_ziyuzhan@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox