From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94C1CC71157 for ; Wed, 18 Jun 2025 10:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PsKjC5odKxyzfkqv5q+1zgVLo0vgy2NGKw7o7kJT674=; b=bDKQtpiP12zc4q OCSXAxFj8FahsBGdt7LAjT/bvHfhjid4heEeRfcgaMV7vuFcvHzrIm+In19rRW7yMnEnvSfhZSN6C P/25m+o+aHOvYnB7DZdgY0P3Brk5xioii7N4UpErk312Mbk8oWEjYmwvTxBQ/TrqEhLUYyN+NA7de sirJ2Jreaxs/RoKP3TYF4HKme/YcPDLAjQLgdXBrQdQKNa40cYw/ZQfkkpYSSdhuxcWoLlcw0f3J8 +/Y/X1WBdkUcieJoN8kyzUCtrhzf811DU3Kd7Rx6vprwZxPLKo/nXx7RnP+u5d78zPVM30LsL6uzt 2JOp0AXgoWBTkJEEt7iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRq90-00000009oBc-1YGx; Wed, 18 Jun 2025 10:35:50 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRpaB-00000009gb5-1ceJ for linux-phy@lists.infradead.org; Wed, 18 Jun 2025 09:59:53 +0000 Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 69BE0527A; Wed, 18 Jun 2025 11:59:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1750240777; bh=WylBtnNm5+D1WBqQ7n5b4AX+XLZXRGkFwWek5BXnqQk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CV+gCdPVgMPYF5Y/GiLSYFPkLBu7LAo+xGIf5ZZrqiKkUd12g/in7u3zpDL/NeTdu iUe7WSkpzmXhxceWpwXxfc1Wa5JspnpRJkwFK/imOOcAA9n6puqce87w2oFY6aQG72 QH2B0eLhizw3gpKqH+4G2oB6YaUjxXfKpdmJS6Ro= From: Tomi Valkeinen Date: Wed, 18 Jun 2025 12:59:17 +0300 Subject: [PATCH v4 14/17] drm/bridge: cdns-dsi: Use video mode and clean up cdns_dsi_mode2cfg() MIME-Version: 1.0 Message-Id: <20250618-cdns-dsi-impro-v4-14-862c841dbe02@ideasonboard.com> References: <20250618-cdns-dsi-impro-v4-0-862c841dbe02@ideasonboard.com> In-Reply-To: <20250618-cdns-dsi-impro-v4-0-862c841dbe02@ideasonboard.com> To: Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vinod Koul , Kishon Vijay Abraham I , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jayesh Choudhary , Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Francesco Dolcini , Aradhya Bhatia , Devarsh Thakkar , Parth Pancholi , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4459; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=WylBtnNm5+D1WBqQ7n5b4AX+XLZXRGkFwWek5BXnqQk=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBoUo4BGAmE+TH/R4RW43+0JeJrvMptcyEWtkJSn SwUNiIrq/+JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCaFKOAQAKCRD6PaqMvJYe 9fyzD/sEDvnFRm5vslpBwXfDXS9RK/8BEkKD/XQTjO+mnjj+wRbCw0jTsVSTPal2a0HgIIU/Lp/ RrDUouZiR5aYiIRqCF/lLflr3Wj9Q4xlGQ8NVWeIzE0dpgYq/Dc/H/uNlAemJbfgV1eoqSvs9N9 co7+r4ej7qLOZbeHBvurNxOHfhsqFTonNC5OBB/BTAArTymJxhfOHCEBivtyi6T/AdX1fPoDWth ve0bP9YSO6EaxpSsAuqFMEJqQTrGzFCgEjv+x0cIFUiSmSNY0MEmRhy+rXEBH0TbWpNg6s6WXoC p6i1SPjBFzwgdpqMCPtxzT6ysP0LHcYvmbNbmUwAFr/Gxz4qzYxKNeHeo9YI0Y5AaICsF82I+22 AIdxkD15ZWtHhUHsSEfChfOAOurO1Tw7b4nTDZsQ/tPUQuNAQ+EyCNX1AM2ZHxIAiF/JWXch7kr 82rSL5GSR0ToIdQHmz1Ta2+w0EjkcPc/wMIExx7KlRufQ/vDasM6XEBCemC8zvhEnDgpM817oVO 991ydvp7v2HqK5Yo3MNJAyg3ZH67AjJ1NhkWT8X840K/Zf/Ke/k4kNwES2FnFjej+y4FyXNJ4Hb /UfGivbk+cD2dj+UEaGsRhFt+U/xO1c5PSj1Iy85Z2USrDw6loRJjg5o5pyoiYW7yjZoiKoUFXc 4NADnAG9svzWxVQ== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250618_025951_606717_2BA2E182 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The driver does all the calculations and programming with video timings (hftp, hbp, etc.) instead of the modeline values (hsync_start, ...). Thus it makes sense to use struct videomode instead of struct drm_display_mode internally. Switch to videomode and do some cleanups in cdns_dsi_mode2cfg() along the way. Tested-by: Parth Pancholi Reviewed-by: Aradhya Bhatia Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 45 ++++++++++++++------------ 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 6bc0a0d00d69..07f8d5f5c2aa 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -9,6 +9,7 @@ #include #include #include