From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34B52C77B7C for ; Thu, 3 Jul 2025 14:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NA/8mhhq/AFXGavXyuqy665eNKlPTiMUZjkKAX0e2Bw=; b=k7M/DOms80c3bv E7PsZAtcVeSTS5yhoK7vgrf1kIaBlpIKc0wt9eToYaR790yfLxLv/PyWG31LRT+dVLNBjzxah5DRN IWRCqIyl+sW90SH5wyq+5oxhIWkZkilbSEDb0mA5b97ehVhZUXNNFd9yJ3bA1fuy+18bvYYURvaG5 uwrXxXMZIxtnGJhsNS3WBUA8GOGx38ak7zL0CskjYZIrswhYLaIiiUmhY88fiQaN0u+/5aQN0+Ygw GyKiU2V3NHQ4ogY7HTTj/9V39gB5MRS3MuO+ER/NVcU8g9yWRpG8JaIIHkL0Riu0albbGF+MlQE9Z Wqu8YRCbIyDCeZ4NfrkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXL1p-0000000Bgp1-3lPx; Thu, 03 Jul 2025 14:35:09 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXJbE-0000000BQZE-0ytv for linux-phy@lists.infradead.org; Thu, 03 Jul 2025 13:03:37 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3a54700a463so565348f8f.1 for ; Thu, 03 Jul 2025 06:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751547814; x=1752152614; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zY+gmVQiaUnNp4jEFsxwLdll+E7uRUbUBQTVKPUvak0=; b=QRo5L0xTWO5kpOfC2yOEbav4sF2eUpqI0xIIfLOZqoDJRiJWeX4zP7EGhGb8E56ito bv/A5Nd8jJmeJQfMDTGDD5bguj46pQx5keE5LEUgacgV8rKR65HG5S7DGkq4Xrk9LtGR fEmHyiZHHkULrulmGD6HumYlV1a4D0mxT99VMOFk+TvEpx+FEqdqat6vEWJ7Eend/9fs d7VwuZZhYcWh4SGA0cNjNB7jLaYguFh8sp4mKgVUl3Nxqpo+xjl1mmVLCIX5Qdm5cuo4 WazlhwOHb1pV64CqApuYBKpus547nGJc3viAQqKbirr8ySMS7m4rqY+m8tM0BwKicwCp ou7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751547814; x=1752152614; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zY+gmVQiaUnNp4jEFsxwLdll+E7uRUbUBQTVKPUvak0=; b=BLOaSSB+LLBP6EZPhfDT5OzCsTr3ypl2hQne4EkLnrZHlKUz+qx2lI9/hCvHSRXqec IuvCuHDPCMKjhpAupK8/YlDs2OfU5XOvouwJmReFOZWRMelFqV3t6ffhHLNBqUVRoP8F 0/w7hmn9VaXQTDwx89zFVpT9KSBX5GiLvYU4ZJVR95Tbs0m8d2TXVocDgV5gc+yPAKrQ poM9iJxFn5+NiQ0EhXJFgPZXCIrM0ChDOxdZUpK1mQKrHBplchamiYI2pxHDkPrVxJqg uIVPnzi5Mh43EfYc9Ldop/L2Ct87NSyiu9g899OYF1NE9U6T85WqXTCDQsG4ymoFV+N0 QLaA== X-Gm-Message-State: AOJu0YxiHjS4OJ09KFtdJXCDIYn85J+xmMt4Uy+a4BREEax9yCWHvWH1 56yb0GA8mt/QQXQKP0QiDHesrokMVgMLxoZwgA5ARmT762Ga/Y5CaZh2xrvOohDKXg8= X-Gm-Gg: ASbGncs7isHCPKGLmiboq2XKTG/nowbKIdt93UFiU4AOMxU4cmp9zQQEoG0ofOrNN+t ZiQY2spVu5LeBhhEv7w7P3DVP/kBmsrjnxObqj4iASlwVzEL7G9sonYHFDHpyqcNJxBoR6uNIHv wlFeW6JeMamot4e0xVh8Skr/oapk10qjZYKKWly+NSmP1+7hl3HICAKh05N77FUz7NEbsEf0dK2 ztE2KdTE004elrpzQI0BiHt1WxzfOHt4Jgk2kTamJymHzAnB8RU7Ycm3JMED7XuJ3fV18X4NKBq H8HQxgF9exM2Z5nk6b0cbhWuUIvgFb1Kh1rd90/pCwpC24y6RXdydvsH7wddVAiYZzCKzzx4vTU vQiy/xP0CIQMwd4pq X-Google-Smtp-Source: AGHT+IFAmqbG8QwOKcAIIyFO7TCvSI5jKlQABIcoROoKfcTrDyTYY+J9CssjlH6HomYb2Z62O9WhbQ== X-Received: by 2002:a5d:584d:0:b0:3a4:d685:3de7 with SMTP id ffacd0b85a97d-3b342a0e01cmr2543169f8f.8.1751547813693; Thu, 03 Jul 2025 06:03:33 -0700 (PDT) Received: from gpeter-l.roam.corp.google.com ([145.224.66.164]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a99693fesm26170005e9.7.2025.07.03.06.03.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 06:03:33 -0700 (PDT) From: Peter Griffin Date: Thu, 03 Jul 2025 14:03:23 +0100 Subject: [PATCH v2 2/2] phy: samsung: gs101-ufs: Add .notify_pmstate() and hibern8 enter/exit values MIME-Version: 1.0 Message-Id: <20250703-phy-notify-pmstate-v2-2-fc1690439117@linaro.org> References: <20250703-phy-notify-pmstate-v2-0-fc1690439117@linaro.org> In-Reply-To: <20250703-phy-notify-pmstate-v2-0-fc1690439117@linaro.org> To: Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Alim Akhtar , Krzysztof Kozlowski Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel-team@android.com, William Mcvicker , Peter Griffin X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5752; i=peter.griffin@linaro.org; h=from:subject:message-id; bh=SGXL8vHpnOze8hCmwSTRKJn6StGn2XGnu+E5YVyfKLw=; b=owEBbQKS/ZANAwAKAc7ouNYCNHK6AcsmYgBoZn+hg2HMRi/dl+2ECaqD6oA575YwGvtgGtYNE a8rLPZfkrOJAjMEAAEKAB0WIQQO/I5vVXh1DVa1SfzO6LjWAjRyugUCaGZ/oQAKCRDO6LjWAjRy uqLSD/95i0gIkM1wypk88hIX1bhKXhzKowe/VoMuslxo6MVrSw7Y4l4xm1z0vQWIUrRufoDx/98 x2absM0xSUf+pWjyhyC8CzlV234TtH6nqszQ1ao4MothcZV2EhAvqCnHWkW0TWxwXrNIrnIy6hC oufEwLX+vNTKhI10Eu+8wcT7WCzeHYUKV4IsyqMmTulFArdz9elklPa/YJI4huDwz8sBbodHZBQ q1Mxc84zYAoNOZJC9BJvKW2rePssI8wec0zY0M5ly1T7sSSj1f8s3x+MgVkTUB/MnC0+/QJhlB7 xR1+ZmH0jhhBn9pER6SRYfxy7z6+ixqtMqJZw0Xu3WPhqL0PfxS7iuhViZ+J1A4QeNejQbqHqNQ VoD4JMuDJi0EGzicc4Sqbe6rPfIptGjqXXX6wITSFlA7V1lDkLnpwkB1d7Ze01ywqnXpcBuQDMp PsxwoCbNQaEdw5ABh7dFiI10yAy/It6C68CU6UP0Wv1rx8BAhLm7gUStywVCdLTDXOvehDyyN5n qqnBR1/OpABHfCdzEPBm27g1NHE+Ku7ds+BjZOfvL2YeOuVf+OUzVbdFOz6n0by2nKLKuvfjLfB eejF8B4dpDU3uJvHna7IJJzIxt59I8YZD39gz0jQGfUdVuPEspFL0+E20ZBwxc9x84X4G+9pRb+ +yzfMnPAdbiiIoA== X-Developer-Key: i=peter.griffin@linaro.org; a=openpgp; fpr=0EFC8E6F5578750D56B549FCCEE8B8D6023472BA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250703_060336_288537_5BAB9F6C X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Implement the .notify_pmstate() callback and provide the gs101 specific phy values that need to be programmed when entering and exiting the hibern8 state. Signed-off-by: Peter Griffin --- drivers/phy/samsung/phy-gs101-ufs.c | 28 ++++++++++++++++++++++++++ drivers/phy/samsung/phy-samsung-ufs.c | 38 +++++++++++++++++++++++++++++++++++ drivers/phy/samsung/phy-samsung-ufs.h | 7 +++++++ 3 files changed, 73 insertions(+) diff --git a/drivers/phy/samsung/phy-gs101-ufs.c b/drivers/phy/samsung/phy-gs101-ufs.c index 17b798da5b5761f8e367599517d2d97bf0bb6b74..a15e1f453f7f3cecd6d3aa75217633ac4b6085d0 100644 --- a/drivers/phy/samsung/phy-gs101-ufs.c +++ b/drivers/phy/samsung/phy-gs101-ufs.c @@ -108,12 +108,39 @@ static const struct samsung_ufs_phy_cfg tensor_gs101_post_pwr_hs_config[] = { END_UFS_PHY_CFG, }; +static const struct samsung_ufs_phy_cfg tensor_gs101_post_h8_enter[] = { + PHY_TRSV_REG_CFG_GS101(0x262, 0x08, PWR_MODE_ANY), + PHY_TRSV_REG_CFG_GS101(0x265, 0x0A, PWR_MODE_ANY), + PHY_COMN_REG_CFG(0x1, 0x8, PWR_MODE_ANY), + PHY_COMN_REG_CFG(0x0, 0x86, PWR_MODE_ANY), + PHY_COMN_REG_CFG(0x8, 0x60, PWR_MODE_HS_ANY), + PHY_TRSV_REG_CFG_GS101(0x222, 0x08, PWR_MODE_HS_ANY), + PHY_TRSV_REG_CFG_GS101(0x246, 0x01, PWR_MODE_HS_ANY), + END_UFS_PHY_CFG, +}; + +static const struct samsung_ufs_phy_cfg tensor_gs101_pre_h8_exit[] = { + PHY_COMN_REG_CFG(0x0, 0xC6, PWR_MODE_ANY), + PHY_COMN_REG_CFG(0x1, 0x0C, PWR_MODE_ANY), + PHY_TRSV_REG_CFG_GS101(0x262, 0x00, PWR_MODE_ANY), + PHY_TRSV_REG_CFG_GS101(0x265, 0x00, PWR_MODE_ANY), + PHY_COMN_REG_CFG(0x8, 0xE0, PWR_MODE_HS_ANY), + PHY_TRSV_REG_CFG_GS101(0x246, 0x03, PWR_MODE_HS_ANY), + PHY_TRSV_REG_CFG_GS101(0x222, 0x18, PWR_MODE_HS_ANY), + END_UFS_PHY_CFG, +}; + static const struct samsung_ufs_phy_cfg *tensor_gs101_ufs_phy_cfgs[CFG_TAG_MAX] = { [CFG_PRE_INIT] = tensor_gs101_pre_init_cfg, [CFG_PRE_PWR_HS] = tensor_gs101_pre_pwr_hs_config, [CFG_POST_PWR_HS] = tensor_gs101_post_pwr_hs_config, }; +static const struct samsung_ufs_phy_cfg *tensor_gs101_hibern8_cfgs[] = { + [CFG_POST_HIBERN8_ENTER] = tensor_gs101_post_h8_enter, + [CFG_PRE_HIBERN8_EXIT] = tensor_gs101_pre_h8_exit, +}; + static const char * const tensor_gs101_ufs_phy_clks[] = { "ref_clk", }; @@ -170,6 +197,7 @@ static int gs101_phy_wait_for_cdr_lock(struct phy *phy, u8 lane) const struct samsung_ufs_phy_drvdata tensor_gs101_ufs_phy = { .cfgs = tensor_gs101_ufs_phy_cfgs, + .cfgs_hibern8 = tensor_gs101_hibern8_cfgs, .isol = { .offset = TENSOR_GS101_PHY_CTRL, .mask = TENSOR_GS101_PHY_CTRL_MASK, diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c index f3cbe6b17b235bb181b3fae628d75822f0c9183a..b0dc40c19d2ed85dbdb74aff768a24f03b4b3f49 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.c +++ b/drivers/phy/samsung/phy-samsung-ufs.c @@ -217,6 +217,42 @@ static int samsung_ufs_phy_set_mode(struct phy *generic_phy, return 0; } +static int samsung_ufs_phy_notify_pmstate(struct phy *phy, + enum phy_linkstate pmstate) +{ + struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy); + const struct samsung_ufs_phy_cfg *cfg; + int i, err; + + if (!ufs_phy->cfgs_hibern8) + return 0; + + if (pmstate == PHY_UFS_HIBERN8_ENTER) + cfg = ufs_phy->cfgs_hibern8[CFG_POST_HIBERN8_ENTER]; + else if (pmstate == PHY_UFS_HIBERN8_EXIT) + cfg = ufs_phy->cfgs_hibern8[CFG_PRE_HIBERN8_EXIT]; + + for_each_phy_cfg(cfg) { + for_each_phy_lane(ufs_phy, i) { + samsung_ufs_phy_config(ufs_phy, cfg, i); + } + } + + if (pmstate == PHY_UFS_HIBERN8_EXIT) { + for_each_phy_lane(ufs_phy, i) { + if (ufs_phy->drvdata->wait_for_cdr) { + err = ufs_phy->drvdata->wait_for_cdr(phy, i); + if (err) + goto err_out; + } + } + } + + return 0; +err_out: + return err; +} + static int samsung_ufs_phy_exit(struct phy *phy) { struct samsung_ufs_phy *ss_phy = get_samsung_ufs_phy(phy); @@ -233,6 +269,7 @@ static const struct phy_ops samsung_ufs_phy_ops = { .power_off = samsung_ufs_phy_power_off, .calibrate = samsung_ufs_phy_calibrate, .set_mode = samsung_ufs_phy_set_mode, + .notify_pmstate = samsung_ufs_phy_notify_pmstate, .owner = THIS_MODULE, }; @@ -287,6 +324,7 @@ static int samsung_ufs_phy_probe(struct platform_device *pdev) phy->dev = dev; phy->drvdata = drvdata; phy->cfgs = drvdata->cfgs; + phy->cfgs_hibern8 = drvdata->cfgs_hibern8; memcpy(&phy->isol, &drvdata->isol, sizeof(phy->isol)); if (!of_property_read_u32_index(dev->of_node, "samsung,pmu-syscon", 1, diff --git a/drivers/phy/samsung/phy-samsung-ufs.h b/drivers/phy/samsung/phy-samsung-ufs.h index a28f148081d168344b47f2798b00cb098f0a8574..f2c2e744e5bae87c9cfcaa17f4a09456f134966a 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.h +++ b/drivers/phy/samsung/phy-samsung-ufs.h @@ -92,6 +92,11 @@ enum { CFG_TAG_MAX, }; +enum { + CFG_POST_HIBERN8_ENTER, + CFG_PRE_HIBERN8_EXIT, +}; + struct samsung_ufs_phy_cfg { u32 off_0; u32 off_1; @@ -108,6 +113,7 @@ struct samsung_ufs_phy_pmu_isol { struct samsung_ufs_phy_drvdata { const struct samsung_ufs_phy_cfg **cfgs; + const struct samsung_ufs_phy_cfg **cfgs_hibern8; struct samsung_ufs_phy_pmu_isol isol; const char * const *clk_list; int num_clks; @@ -124,6 +130,7 @@ struct samsung_ufs_phy { struct clk_bulk_data *clks; const struct samsung_ufs_phy_drvdata *drvdata; const struct samsung_ufs_phy_cfg * const *cfgs; + const struct samsung_ufs_phy_cfg * const *cfgs_hibern8; struct samsung_ufs_phy_pmu_isol isol; u8 lane_cnt; int ufs_phy_state; -- 2.50.0.727.gbf7dc18ff4-goog -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy