From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91E5CC87FD2 for ; Wed, 23 Jul 2025 10:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2DPFVbIWSl+NHrbV2vToYW6NcOVsPAfOOvxFoyGJqJM=; b=uAzs9OpMbaUIhd hZgrhCbIBtPFqx04l+9GGrsu0VDzbVpYFQ4eNYudqAj+mHXt1VubYxFUHsfiug2KEVBsDIcYfFf6X XmHCCtTWfHUBmG8dGOY7MPYVD4NEdoZQtAoV1B95EfNLKmFi4WGqHot/jdiSnyvvAQtYbG/U5s0RI lzCBIvN6V3j+ZB71J0aX83e4QcWdsCWepWagKO9PGr8Fv0JH2rz+qs4oM6V5S91xm6c4hTtAKBzs3 jvoKrdiffsnw/ZdjFCyCHlfXC3EInXU8Yw4so1En+sDmJu0CHMe6yHHwlGOog1tZCpZlBlHVVcByt UgjeMAmnD2GxofiEKMbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ueWcU-00000004fcH-1GBf; Wed, 23 Jul 2025 10:22:42 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ueWMD-00000004cP2-10RB for linux-phy@lists.infradead.org; Wed, 23 Jul 2025 10:05:54 +0000 Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EBFAA157F; Wed, 23 Jul 2025 12:05:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1753265114; bh=7lmhdHLGtnxLHPbRqWTXPm7itvpD72rVUURBCngSQhA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KZRPq9ft738dHaAIypRBzyhHDSysMwRpdQvVBQ5J+NRDP9MCyIiDhoZKENJrDla7+ isnFXLXxDK8BZOsyjfvPWrentzgEzVyz0bc/yFUc6J/wV50+0fBe8vyRAOaNB9Ccuj 7DkmKLqT4k41hIp4JzPqXqRslb4Rzd8DcbHH0GMo= From: Tomi Valkeinen Date: Wed, 23 Jul 2025 13:05:18 +0300 Subject: [PATCH v5 12/15] drm/bridge: cdns-dsi: Use video mode and clean up cdns_dsi_mode2cfg() MIME-Version: 1.0 Message-Id: <20250723-cdns-dsi-impro-v5-12-e61cc06074c2@ideasonboard.com> References: <20250723-cdns-dsi-impro-v5-0-e61cc06074c2@ideasonboard.com> In-Reply-To: <20250723-cdns-dsi-impro-v5-0-e61cc06074c2@ideasonboard.com> To: Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vinod Koul , Kishon Vijay Abraham I , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jayesh Choudhary , Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Francesco Dolcini , Aradhya Bhatia , Devarsh Thakkar , Parth Pancholi , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4557; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=7lmhdHLGtnxLHPbRqWTXPm7itvpD72rVUURBCngSQhA=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBogLPtOIIi8tcw4ekhFpnzdFPrBI5KHOIdts8Yd ykIGxhsce6JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCaICz7QAKCRD6PaqMvJYe 9T9ED/99wGaPJcacn7ug9Y+uFeFiaIT7CgHKndCC9thdQ7yscbcdYQxZV7g6Oiv5HgPEsH9Zjkt XjNjm0uLciijmPOWwf5RI1VLQjCy6xySCd7ilrQa0Iyb+rHI/As1Zrv/LbLwQhfoaEnCzopofa0 GBPv/3KkWRb0t3opdfDSN8+i4CIUnKtOZ/7ElxWEIZmXqgG/WY999dEN6CCabYFs0m13rane8nv p/4XAGC+LwT0HC7FsGOEyY4jnb/ACio0OL8S43zHqwRojCf6qNTBGBme4fOd5D9NH+jg7iryRwO /Lqv/cHU5Lg1rLHh6CHZSv3w92ARINuDufsyh22Pdiie/Zean27kfAJDXysevys7ukdk1zcN4sG YER37pLD6Q2A4sZ8jPw2fQBPSvbHMJZzy+P8K/lbOVg9a0SkT24lzATJbTd6Vnih5Is65QeGU37 pO4OC+Er4wmjR2NK7puWIM0ApLQy8U3DnntZMt//TAbvbCGvpikDoTQT+dTIhvgIz3+wFF48B4z tPzUZV/qiCCdcASFyHECdfq0dRSqqjoC30ArlRuQTcSHo/2BC2f6OngkSmA1NjAMmERusRNqWsW AxWYturCSpneGDIu6Zd7qNqRfAgSgImRbtZFTm7x/5vKY1y45TcsaZy9YZTNEiA66xVvFyrNkUq EFtNHVwp2rFen1w== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250723_030553_425552_C9AF7598 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The driver does all the calculations and programming with video timings (hftp, hbp, etc.) instead of the modeline values (hsync_start, ...). Thus it makes sense to use struct videomode instead of struct drm_display_mode internally. Switch to videomode and do some cleanups in cdns_dsi_mode2cfg() along the way. Tested-by: Parth Pancholi Reviewed-by: Aradhya Bhatia Tested-by: Jayesh Choudhary Reviewed-by: Devarsh Thakkar Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 45 ++++++++++++++------------ 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 6bc0a0d00d69..07f8d5f5c2aa 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -9,6 +9,7 @@ #include #include #include