Re: [PATCH 01/38] dt-bindings: display: mediatek: dpi: Allow specifying resets

From: Rob Herring <robh@kernel.org>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	linux-mediatek@lists.infradead.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, krzk+dt@kernel.org, conor+dt@kernel.org,
	chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
	airlied@gmail.com, simona@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, jassisinghbrar@gmail.com,
	mchehab@kernel.org, matthias.bgg@gmail.com,
	chunfeng.yun@mediatek.com, vkoul@kernel.org, kishon@kernel.org,
	sean.wang@kernel.org, linus.walleij@linaro.org,
	lgirdwood@gmail.com, broonie@kernel.org, andersson@kernel.org,
	mathieu.poirier@linaro.org, daniel.lezcano@linaro.org,
	tglx@linutronix.de, atenart@kernel.org, jitao.shi@mediatek.com,
	ck.hu@mediatek.com, houlong.wei@mediatek.com,
	kyrie.wu@mediatek.corp-partner.google.com,
	andy.teng@mediatek.com, tinghan.shen@mediatek.com,
	jiaxin.yu@mediatek.com, shane.chien@mediatek.com,
	olivia.wen@mediatek.com, granquet@baylibre.com,
	eugen.hristev@linaro.org, arnd@arndb.de, sam.shih@mediatek.com,
	jieyy.yang@mediatek.com, frank-w@public-files.de,
	mwalle@kernel.org, fparent@baylibre.com,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH 01/38] dt-bindings: display: mediatek: dpi: Allow specifying resets
Date: Fri, 25 Jul 2025 15:26:55 -0500	[thread overview]
Message-ID: <20250725202655.GA1826181-robh@kernel.org> (raw)
In-Reply-To: <CAGXv+5HTdK8aiUYdtNVhWAvsSNfMPgK6iCqe-Jsb-OBqQBWsBg@mail.gmail.com>

On Thu, Jul 24, 2025 at 05:16:21PM +0800, Chen-Yu Tsai wrote:
> On Thu, Jul 24, 2025 at 4:39 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
> >
> > Even though the DPI IP has a reset bit on all MediaTek SoCs, it
> > is optional, and has always been unused until MT8195; specifically:
> > on older SoCs, like MT8173, the reset bit is located in MMSYS, and
> > on newer SoCs, like MT8195, it is located in VDOSYS.
> >
> > For this reason, allow specifying the resets and reset-names on
> > all MediaTek SoCs.
> >
> > Those properties are optional because there are multiple ways to
> > reset this IP and the reset lines in MM/VDO are used only if the
> > IP cannot perform warm-reset.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > index b659d79393a8..eb4f276e8dc4 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > @@ -102,6 +102,13 @@ properties:
> >        - port@0
> >        - port@1
> >
> > +  resets:
> > +    maxItems: 1
> > +
> > +  reset-names:
> > +    items:
> > +      - const: dpi
> > +
> 
> Do we really need the name if there is only one though?

Not really, but if it is already in use then easier to just fix the 
binding than both the binding and dts.

Rob

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy