Re: [PATCH 13/15] arm64: dts: mediatek: mt7981b: Add wifi memory region

Sjoerd Simons
2025-11-01T12:42:10Z

On Thu, 2025-10-16 at 13:28 +0200, AngeloGioacchino Del Regno wrote:
> Il 16/10/25 12:08, Sjoerd Simons ha scritto:
> > Add required memory region for the builtin wifi block. Disable the block
> > by default as it won't function properly without at least pin muxing.
> >
> > Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
>
> You should split this commit in two:
>   - Add wifi memory region
>   - Disable wifi by default

Will split.

> Regarding the second commit, you have to re-enable the wifi node in all of
> the currently supported MT7981b devices, including:
>   - Xiaomi AX3000T
>   - Cudy WR3000 V1
>
> While I agree that without pin muxing the wifi may not properly work, it is
> unclear whether the aforementioned devices are pre-setting the pinmux in the
> bootloader before booting Linux.
>
> In case those do, you'd be "breaking" WiFi on two routers here.

Wifi will never have worked on those upstream; The driver hits an unconditional -EINVAL during probe
due to the missing memory-region this patch adds. I'll make sure to note that in the new disable
patch.

--
Sjoerd Simons <sjoerd@collabora.com>