Re: [PATCH 12/15] arm64: dts: mediatek: mt7981b-openwrt-one: Enable Ethernet

Sjoerd Simons
2025-10-28T13:24:56Z

On Tue, 2025-10-28 at 12:14 +0100, Eric Woudstra wrote:
>
>
> On 10/21/25 10:21 PM, Sjoerd Simons wrote:
> > On Fri, 2025-10-17 at 19:31 +0200, Andrew Lunn wrote:
> > > > +&mdio_bus {
> > > > + phy15: ethernet-phy@f {
> > > > + compatible = "ethernet-phy-id03a2.a411";
> > > > + reg = <0xf>;
> > > > + interrupt-parent = <&pio>;
> > > > + interrupts = <38 IRQ_TYPE_EDGE_FALLING>;
> > >
> > > This is probably wrong. PHY interrupts are generally level, not edge.
> >
> > Sadly i can't find a datasheet for the PHY, so can't really validate that
> > easily. Maybe Eric can
> > comment here as the author of the relevant PHY driver.
> >
> > I'd note that the mt7986a-bananapi-bpi-r3-mini dts has the same setup for
> > this PHY, however that's
> > ofcourse not authoritative.
> >
>
> Lucien would have access to the correct information about the interrupt.

Thanks! For what it's worth i got around to putting a scope on the line last
night. It looks like the interrupt line is pulled down until cleared, so it
appears it's indeed a Level interrupt as Andrew guessed. But would be great to
have this confirmed based on the documentation :)

--
Sjoerd Simons <sjoerd@collabora.com>
Collabora