From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8A0ECCD1BF for ; Tue, 28 Oct 2025 08:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AMfkfC4CKuHym0Mqwjc6wCHppsGt7KIiN7EyHnJwWf8=; b=KO1OUYMzusFZw2 WaS9cMMD9yQJq/FEQoIuFSaln1mPkPBg4n3BCEgPRFznizgduEUqFJLAQ1og1eVGU8M6hSOWvQIQ/ +XL4nE3I9ebShUPl11PbM+cTt8/pxrG24iKEn40AqemabeJXYha72IIfABD5pWx/oxi7OcD1RFwey feYtD3H8+zIbxYNnkHjXHzXgi5opJHdxTBpEo4mb88ZJOu1IOWO87QsrB+kb9W85Hd6eSezNR+Ebg bLiIPw81ySf9gP/KnVevIZqWf++l8DADlnvIkq9ZsO+MpG6VbKcwWTWvYTsGuWgN3+tlO6nvTa7yF ABvexyn78U1w9nI2nFww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDf3r-0000000FY8s-2NJu; Tue, 28 Oct 2025 08:28:11 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDf3o-0000000FY7O-0BaC; Tue, 28 Oct 2025 08:28:09 +0000 Received: from pendragon.ideasonboard.com (unknown [193.209.96.36]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E545116CD; Tue, 28 Oct 2025 09:26:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1761639978; bh=oNlpkQO5cst6KsAukF9U7bQZ+Sa47oF2EkKRJDLHMeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jIKURGR5U/AmwLf+zhFNmroQF9QQUBrT0sjXi/qZVnGFcfUdImrsM2j8NnW9HLYXZ gcATKbqYBMHtB0VeGe2ohVjfTiTypIovnOmECF9Un2qglKWztUtcfYYxECAvEG3R3z 7BUVyheYs5jGK5m14Z1JQbpUiQLyX6EuiMkr8t4w= Date: Tue, 28 Oct 2025 10:27:53 +0200 From: Laurent Pinchart To: Frank Li Cc: Sakari Ailus , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eugen Hristev , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Alice Yuan , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Steve Longerbeam , Greg Kroah-Hartman , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-staging@lists.linux.dev, Luis Oliveira Subject: Re: [PATCH v3 01/31] dt-bindings: media: add DW MIPI CSI-2 Host support Message-ID: <20251028082753.GZ13023@pendragon.ideasonboard.com> References: <20250821-95_cam-v3-0-c9286fbb34b9@nxp.com> <20250821-95_cam-v3-1-c9286fbb34b9@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251028_012808_222644_12C8F605 X-CRM114-Status: GOOD ( 33.49 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Oct 27, 2025 at 05:05:09PM -0400, Frank Li wrote: > On Mon, Oct 27, 2025 at 10:51:21PM +0200, Sakari Ailus wrote: > > On Mon, Oct 27, 2025 at 12:32:28PM -0400, Frank Li wrote: > > > On Mon, Oct 27, 2025 at 10:31:25AM +0200, Sakari Ailus wrote: > > > > On Thu, Aug 21, 2025 at 04:15:36PM -0400, Frank Li wrote: > > > > > From: Eugen Hristev > > > > > > > > > > Add bindings for Synopsys DesignWare MIPI CSI-2 host, which used at i.MX93 > > > > > and i.MX95 platform. > > > > > > > > > > Signed-off-by: Luis Oliveira > > > > > Signed-off-by: Eugen Hristev > > > > > Signed-off-by: Frank Li > > > > > --- > > > > > Change in v3 > > > > > - drop remote-endpoint: true > > > > > - drop clock-lanes > > > > > > > > > > Change in v2 > > > > > - remove Eugen Hristev from mantainer. > > > > > - update ugen Hristev's s-o-b tag to align original author's email address > > > > > - remove single snps,dw-mipi-csi2-v150 compatible string > > > > > - move additionalProperties after required > > > > > --- > > > > > .../bindings/media/snps,dw-mipi-csi2-v150.yaml | 151 +++++++++++++++++++++ > > > > > MAINTAINERS | 1 + > > > > > 2 files changed, 152 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/snps,dw-mipi-csi2-v150.yaml b/Documentation/devicetree/bindings/media/snps,dw-mipi-csi2-v150.yaml > > > > > new file mode 100644 > > > > > index 0000000000000000000000000000000000000000..d950daa4ee9cfd504ef84b83271b2a1b710ffd6b > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/media/snps,dw-mipi-csi2-v150.yaml > > > > > @@ -0,0 +1,151 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/media/snps,dw-mipi-csi2-v150.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Synopsys DesignWare CSI-2 Host controller (csi2host) > > > > > + > > > > > +maintainers: > > > > > + - Frank Li > > > > > + > > > > > +description: > > > > > + CSI2HOST is used to receive image coming from an MIPI CSI-2 compatible > > > > > + camera. It will convert the incoming CSI-2 stream into a dedicated > > > > > + interface called the Synopsys IDI (Image Data Interface). > > > > > + This interface is a 32-bit SoC internal only, and can be assimilated > > > > > + with a CSI-2 interface. > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + items: > > > > > + - enum: > > > > > + - fsl,imx93-mipi-csi2 > > > > > + - const: snps,dw-mipi-csi2-v150 > > > > > + > > > > > + reg: > > > > > + items: > > > > > + - description: MIPI CSI-2 core register > > > > > + > > > > > + reg-names: > > > > > + items: > > > > > + - const: core > > > > > + > > > > > + clocks: > > > > > + maxItems: 2 > > > > > + > > > > > + clock-names: > > > > > + items: > > > > > + - const: per > > > > > + - const: pixel > > > > > + > > > > > + phys: > > > > > + maxItems: 1 > > > > > + description: MIPI D-PHY > > > > > + > > > > > + phy-names: > > > > > + items: > > > > > + - const: rx > > > > > + > > > > > + resets: > > > > > + maxItems: 1 > > > > > + > > > > > + interrupts: > > > > > + maxItems: 1 > > > > > + > > > > > + power-domains: > > > > > + maxItems: 1 > > > > > + > > > > > + ports: > > > > > + $ref: /schemas/graph.yaml#/properties/ports > > > > > + > > > > > + properties: > > > > > + port@0: > > > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > > > + unevaluatedProperties: false > > > > > + description: > > > > > + Input port node, single endpoint describing the input port. > > > > > + > > > > > + properties: > > > > > + endpoint: > > > > > + $ref: video-interfaces.yaml# > > > > > + unevaluatedProperties: false > > > > > + description: Endpoint connected to input device > > > > > + > > > > > + properties: > > > > > + bus-type: > > > > > + const: 4 > > > > > > > > If 4 is the only value supported, you can drop the property altogether. > > > > > > Sorry, What's your means here? There are more options in video-interfaces.yaml. > > > here just add restriction for bus-type. otherwise other value can be > > > provide in dts file. > > > > It could, but wouldn't any other value be incorrect? > > at least that 5 # Parallel doesn't make sense for CSI2's input. The point is that, if the only valid value is CSI-2 DPHY (4), then there's no need to specify it in DT. The driver would know the input bus is CSI-2 DPHY, so there's no need to convey that information in the device tree. > > In other words, this property is redundant and should be dropped. > > > > > > > + > > > > > + data-lanes: > > > > > + minItems: 1 > > > > > + maxItems: 4 > > > > > + items: > > > > > + maximum: 4 > > > > > + > > > > > + port@1: > > > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > > > + unevaluatedProperties: false > > > > > + description: > > > > > + Output port node, single endpoint describing the output port. > > > > > + > > > > > + properties: > > > > > + endpoint: > > > > > + unevaluatedProperties: false > > > > > + $ref: video-interfaces.yaml# > > > > > + description: Endpoint connected to output device > > > > > + > > > > > + properties: > > > > > + bus-type: > > > > > + const: 4 > > > > > > > > Are both input and output of this block CSI-2 with D-PHY? > > > > > > Yes, input from camera sensor, output to others image processors to do data > > > transfer or format convert. > > > > The description appears to be saying this is "Synopsys IDI", not CSI-2 with > > D-PHY. We don't have a bus-type for IDI. Couldn't you simply drop it? -- Regards, Laurent Pinchart -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy