From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1ADD6CCFA18 for ; Tue, 11 Nov 2025 18:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jSCTNs4apCW5xwAKEURYz7eRV9AfuzLBrO0hkYk81tQ=; b=B1c0y7SGIMJvkH4eQAzR+oenSj yzIKJQcl5LSSqtRw81B3zNvPMjOedEFAPjoMnkGndYcZc0Lk9tLXesNSPq5WhXc7a4cOZfCaY4uga vDf12zRTJqHGbcXXoK72XZPS/xI1E8FmWnu+5VneZTtj7Z/GFgZnXJp7H1thRiGwDfmek89KXPV7c 2C9bHStebs1BTvRodnLWknhA8KUIswuZ1ql03iukNr+wnyi8HnugurwYeF68Eg4kXydOcI9fZ7jv3 RMwCEZmZ8NfpcwmZBP2Dji+6b0n3mLbYrZnMMJ3OQ1JyqYlyyxUFF0S9tkc3Iz83aYRqDbVGaB1V9 /MV+7LvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIswl-00000007b1l-3fPK; Tue, 11 Nov 2025 18:18:27 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIswk-00000007b1c-1vGy; Tue, 11 Nov 2025 18:18:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 92F1060209; Tue, 11 Nov 2025 18:18:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A0EDC116D0; Tue, 11 Nov 2025 18:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762885105; bh=9A1g77d6NETJrsVEFwCGkGYcg7oNe/734nbYe0R1toY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DE1UvpH/bC9UZ2eBNdd8mq2OkWzJrQvT+sAdgbmfNQQBPEh/tAnmIjmopSsH+/i5E U1rDhQJM6MweLo/ufwiBDM1lFfgKcPglJWSBD8nWcdG+Vr4fZgBqLOGcWOkbbkTgFP qxrcE5TT/HeNEs2/29sSMaAT3+TvBpLE0BqHvBX3DLzbFSNvkQbKU/GZjwnEPwEnUC jC93p3cJ384/NXhhyYsEV/eB0Jm+haN1qW16cidNuUY6nM7B/Q8WDq45uLjgnaf5td /1NW0yt7iA2gNM7b0Id+r8yDnMfYFl70ge4s3ljjhcgKNlcbxqbej4tvEWtzceK24a JhfIq7TMhW33g== Date: Tue, 11 Nov 2025 18:18:16 +0000 From: Conor Dooley To: Michal Wilczynski Cc: Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Conor Dooley , Xingyu Wu , Vinod Koul , Kishon Vijay Abraham I , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Icenowy Zheng , Maud Spierings , Andy Yan , Heiko Stuebner , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH RFC 01/13] dt-bindings: soc: starfive: Add vout-subsystem IP block Message-ID: <20251111-massager-twistable-1e88f03d82f8@spud> References: <20251108-jh7110-clean-send-v1-0-06bf43bb76b1@samsung.com> <20251108-jh7110-clean-send-v1-1-06bf43bb76b1@samsung.com> MIME-Version: 1.0 In-Reply-To: <20251108-jh7110-clean-send-v1-1-06bf43bb76b1@samsung.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3744340275695391211==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============3744340275695391211== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LyJKcpcoYORwRgse" Content-Disposition: inline --LyJKcpcoYORwRgse Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 08, 2025 at 02:04:35AM +0100, Michal Wilczynski wrote: > Add the dt-binding documentation for the StarFive JH7110 Video Output > (VOUT) subsystem. >=20 > This node acts as a parent for all devices within the VOUT power domain, > including the DC8200 display controller, the VOUTCRG clock generator, > and the HDMI MFD block. Its driver is responsible for managing the > shared power domain and top-level bus clocks for these children. >=20 > It is a bit similar to the display subsystem qcom,sdm845-mdss DT node. >=20 > Signed-off-by: Michal Wilczynski > --- > .../starfive/starfive,jh7110-vout-subsystem.yaml | 156 +++++++++++++++= ++++++ > MAINTAINERS | 5 + > 2 files changed, 161 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh71= 10-vout-subsystem.yaml b/Documentation/devicetree/bindings/soc/starfive/sta= rfive,jh7110-vout-subsystem.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..4ad9423ea139a537b4cfea26b= 0ed4ed263aa14a1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-vout= -subsystem.yaml > @@ -0,0 +1,156 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/starfive/starfive,jh7110-vout-sub= system.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 VOUT (Video Output) Subsystem > + > +maintainers: > + - Michal Wilczynski > + > +description: > + The JH7110 video output subsystem is an IP block that contains > + the display controller (DC8200), HDMI controller/PHY, and VOUT > + clock generator (VOUTCRG). > + > +properties: > + compatible: > + const: starfive,jh7110-vout-subsystem > + > + reg: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + ranges: true > + > + '#address-cells': > + const: 2 > + > + '#size-cells': > + const: 2 > + > +patternProperties: > + "^display@[0-9a-f]+$": Personally I'd like to see these being regular properties, since there's exactly one possible setup for this. > + type: object > + description: Verisilicon DC8200 Display Controller node. Can you add the relevant references here instead of allowing any object? Cheers, Conor. > + > + "^hdmi@[0-9a-f]+$": > + type: object > + description: StarFive HDMI MFD (PHY + Controller) node. > + > + "^clock-controller@[0-9a-f]+$": > + type: object > + description: StarFive VOUT Clock Generator (VOUTCRG) node. > + > + "^syscon@[0-9a-f]+$": > + type: object > + description: StarFive VOUT Syscon node. > + > +required: > + - compatible > + - reg > + - power-domains > + - clocks > + - resets > + - ranges > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + soc { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + vout_subsystem: display-subsystem@29400000 { > + compatible =3D "starfive,jh7110-vout-subsystem"; > + reg =3D <0x0 0x29400000 0x0 0x200000>; > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges; > + > + power-domains =3D <&pwrc JH7110_PD_VOUT>; > + clocks =3D <&syscrg JH7110_SYSCLK_NOC_BUS_DISP_AXI>; > + resets =3D <&syscrg JH7110_SYSRST_NOC_BUS_DISP_AXI>; > + > + dc8200: display@29400000 { > + compatible =3D "verisilicon,dc"; > + reg =3D <0x0 0x29400000 0x0 0x2800>; > + interrupts =3D <95>; > + clocks =3D <&voutcrg JH7110_VOUTCLK_DC8200_CORE>, > + <&voutcrg JH7110_VOUTCLK_DC8200_AXI>, > + <&voutcrg JH7110_VOUTCLK_DC8200_AHB>, > + <&voutcrg JH7110_VOUTCLK_DC8200_PIX0>, > + <&voutcrg JH7110_VOUTCLK_DC8200_PIX1>; > + clock-names =3D "core", "axi", "ahb", "pix0", "pix1"; > + resets =3D <&voutcrg JH7110_VOUTRST_DC8200_AXI>, > + <&voutcrg JH7110_VOUTRST_DC8200_AHB>, > + <&voutcrg JH7110_VOUTRST_DC8200_CORE>; > + reset-names =3D "axi", "ahb", "core"; > + }; > + > + hdmi_mfd: hdmi@29590000 { > + compatible =3D "starfive,jh7110-hdmi-mfd"; > + reg =3D <0x0 0x29590000 0x0 0x4000>; > + interrupts =3D <99>; > + > + hdmi_phy: phy { > + compatible =3D "starfive,jh7110-inno-hdmi-phy"; > + clocks =3D <&xin24m>; > + clock-names =3D "refoclk"; > + #clock-cells =3D <0>; > + clock-output-names =3D "hdmi_pclk"; > + #phy-cells =3D <0>; > + }; > + > + hdmi_controller: controller { > + compatible =3D "starfive,jh7110-inno-hdmi-controller= "; > + interrupts =3D <99>; > + clocks =3D <&voutcrg JH7110_VOUTCLK_HDMI_TX_SYS>, > + <&voutcrg JH7110_VOUTCLK_HDMI_TX_MCLK>, > + <&voutcrg JH7110_VOUTCLK_HDMI_TX_BCLK>, > + <&hdmi_phy>; > + clock-names =3D "sys", "mclk", "bclk", "pclk"; > + resets =3D <&voutcrg JH7110_VOUTRST_HDMI_TX_HDMI>; > + reset-names =3D "hdmi_tx"; > + phys =3D <&hdmi_phy>; > + phy-names =3D "hdmi-phy"; > + }; > + }; > + > + voutcrg: clock-controller@295c0000 { > + compatible =3D "starfive,jh7110-voutcrg"; > + reg =3D <0x0 0x295c0000 0x0 0x10000>; > + clocks =3D <&syscrg JH7110_SYSCLK_VOUT_SRC>, > + <&syscrg JH7110_SYSCLK_VOUT_TOP_AHB>, > + <&syscrg JH7110_SYSCLK_VOUT_TOP_AXI>, > + <&syscrg JH7110_SYSCLK_VOUT_TOP_HDMITX0_MCLK>, > + <&syscrg JH7110_SYSCLK_I2STX0_BCLK>, > + <&hdmi_phy>; > + clock-names =3D "vout_src", "vout_top_ahb", > + "vout_top_axi", "vout_top_hdmitx0_mclk", > + "i2stx0_bclk", "hdmitx0_pixelclk"; > + resets =3D <&syscrg JH7110_SYSRST_VOUT_TOP_SRC>; > + reset-names =3D "vout_top"; > + #clock-cells =3D <1>; > + #reset-cells =3D <1>; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 348caaaa929a519bc0ec5c0c7b587468ef7532d5..99434e54dc39494153677a6ca= 359d70f2ba2ddb3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -24044,6 +24044,11 @@ S: Maintained > F: Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > F: drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c > =20 > +STARFIVE JH7110 DISPLAY SUBSYSTEM > +M: Michal Wilczynski > +S: Maintained > +F: Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-vout-s= ubsystem.yaml > + > STARFIVE JH7110 DPHY RX DRIVER > M: Jack Zhu > M: Changhuang Liang >=20 > --=20 > 2.34.1 >=20 --LyJKcpcoYORwRgse Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaRN96AAKCRB4tDGHoIJi 0op6AP94in4x/F+djtzX2cdGh5YC4XpNjLGROQ5E+6usNlM+lgEA8CLCphPZFJZM EEQ1XnVlM99yRJUHnSZmsnWiZzmyCQo= =wEbO -----END PGP SIGNATURE----- --LyJKcpcoYORwRgse-- --===============3744340275695391211== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============3744340275695391211==--