Re: [PATCH 1/6] dt-bindings: phy: describe additional regulator for Qualcomm SGMII PHY

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	 Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Wasim Nazir <wasim.nazir@oss.qualcomm.com>,
	 Mohd Ayaan Anwar <quic_mohdayaa@quicinc.com>,
	Yijie Yang <quic_yijiyang@quicinc.com>,
	 linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH 1/6] dt-bindings: phy: describe additional regulator for Qualcomm SGMII PHY
Date: Tue, 25 Nov 2025 10:59:06 +0100	[thread overview]
Message-ID: <20251125-happy-silver-monkey-569cfd@kuoka> (raw)
In-Reply-To: <20251124-sgmiieth_serdes_regulator-v1-1-73ae8f9cbe2a@oss.qualcomm.com>

On Mon, Nov 24, 2025 at 02:55:17PM +0530, Mohd Ayaan Anwar wrote:
> Describe the additional vdda-0p9-supply for the Qualcomm SGMII PHY.

Why... device was completely described or not? What else is missing?
Please read writing bindings doc - the bindings are supposed to be
complete, so you bringing up properties afterwards feels odd.

> 
> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml         | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> index 90fc8c039219c739eae05cc17108a9a2fc6193df..0a1330b9118d63cf5400325c58bca05ebc641055 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> @@ -36,6 +36,10 @@ properties:
>      description:
>        Phandle to a regulator that provides power to the PHY.
>  
> +  vdda-0p9-supply:

Why not vdda? What other supplies are you missing?

> +    description:
> +      Phandle to a 0.9V regulator supply to the PHY.

You just duplicated phy-supply, no? Both supply to the phy or how
exactly does it work?

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy