From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27AC0D3900B for ; Wed, 14 Jan 2026 19:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+8ptmr6bAnZCpaZEDhGeXxKmZcu20csdhHojcBez/oc=; b=2HAMr68mIb3qAW VBaiiepvWhod8GjeuWx/3F/2cNIfYClU6IibgzLpp330S+4ftDe5by4TLRjF2Hd5xCeAvyAX9FRnN YcUhT4Vi8s6q7JjBK1YT1QA9qMwuCOB+RogXsalqx3nNE2NXBX5uwZVeQaeaU40gb/MSrMr1mpb+l I+zgSEEXVnDLsf37WwUZtDu74JU4VzkPIaCFlDraMz71lhK3sIOSQUzYwhM/QGiMp7mzR2BQz2SKJ c+909X465T+23qn27zFion/wYOX87lMFY1sk1aVsCaiVw4JHuzFKEJkDiWxdLFtl8PZrsAnIsQRoE ZJ/DPBl4u1OIJdiAEcZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vg68z-0000000APkI-33RF; Wed, 14 Jan 2026 19:03:01 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vg68x-0000000APj9-09p7 for linux-phy@lists.infradead.org; Wed, 14 Jan 2026 19:03:00 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-64b7a91f9daso12557a12.2 for ; Wed, 14 Jan 2026 11:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768417377; x=1769022177; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zqOxMcid/peC1Iie6lTLw8C1UUftl4S8ZikbVgEoS64=; b=HM7+H4p0wvgK7GmDRY3Z3BIlK2ex3a+82VPAPqMJ6t8T3YXcW6kkK6cazQS5fEiU28 qLt3SyJiqURYJKmi0BiHyVh1Dmq+lm2ALXu9q+Eu8Dn/A/uIUuVwCszDR8TJl8iN85+Q coXlMGM/fAdjxGNTVDObXnzyKJwbuLRmtXF9zRJK3L6MGFt0f0TiSVfhudJHKYXCPm0N c60N/ZSHA7x9XaTnuUz+gyrsQugu0pDHMRML7hvLOrVBKwMfJ2jJz1iDJpLzA6HwzTvn pdIymv9km1l/Cwi+cm8nfkMcMEyKtzhbob1TORMqwysWKsUYgXc8UGz5Cf7wNgl2u7Bc PLuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768417377; x=1769022177; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zqOxMcid/peC1Iie6lTLw8C1UUftl4S8ZikbVgEoS64=; b=bowUdyDxuMdQI8X3QGdjgX4Mbr+MNYGsLHDgqXv8F1910TEryRKv7z3e39UfYgLE2F FDwtrT5PPTwueFXpYwn6CEuzZnCk3kTDuWHmaXcvFMqtU84b/VjIV2PCmF0SHB/SaU/+ Q7PLIMvIhaj4WtJAYugnUVTjuUARAb/iPUUz6qy1ArF5JO4Xi27ExhEahg7h+DbkCk/w HJfsmboSZPFbvk/g0AOUaHvCervBIV2feVnfto0SLFRSQ7jfwXtT/t9xyp4XSIPYMHcS pHQMSw+i7z6RLHRk5PEDWum7PeXt+l0cIe3cISiKpN5xj3XsuU0zAybJQ1QM/gImpQ/+ C2Aw== X-Forwarded-Encrypted: i=1; AJvYcCXrQdjfulH/Rd9Y1mMrSiQvxWnN6IOS5R1s18lCoRpDt0PW966A7ukhxJGzT1R2JcmUCF41g2OuJdQ=@lists.infradead.org X-Gm-Message-State: AOJu0YzhRWEiO3Iq/XUkQPHiW9iTAZSe3X4bwQlhOm1ppmYKBKeHM/sb SIzZvtmbCuC7Okdx1eJkcxxLtUh9rEQexsr1KjajUY/tHsGOjBkzMdYu X-Gm-Gg: AY/fxX7O73Pyu7HqElK1Xl2rPKeFA0YHyA8IefknZ+zk51utcWP3RacNNnDKPl6J0Kj rhcxNxCD0KCod9JNua2b2iTQRKKYCDzRRx+XkIBftA8P8x76cjmXkMIbavrhBn40Qh8+iyXerR+ omtUxgb4z7ibj+EJhdSb6sdS9d9UQipaxecGiRF4U5eE+gLek+LbjWns479wshbenuzT2eT/GSX 09gG2960uSqeDnX3358BUMK86DqIEJQECgqP5WDX4job4pILHe693YBEnkb03s1YLYp2zTCpXB6 d/6hbYYbmD3cwS98HtV+VSaA1d4SoR4V5369B2iN/8WRdhykmVKOP6mLVpRlz8dLcFfAkCMrq/N o8jYigGDmMbVEb8xDRBpRdW+6lWHSGAiM2Wa80E8HJiMEVxlQDYUhsYapThz3oeWzKTyq76ubFo kcZ84= X-Received: by 2002:a05:6402:34d3:b0:64b:5a76:792b with SMTP id 4fb4d7f45d1cf-653ec459a3cmr1649376a12.3.1768417377014; Wed, 14 Jan 2026 11:02:57 -0800 (PST) Received: from skbuf ([2a02:2f04:d703:5400:9b39:8144:8a26:667e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65411877591sm391335a12.5.2026.01.14.11.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 11:02:56 -0800 (PST) Date: Wed, 14 Jan 2026 21:02:53 +0200 From: Vladimir Oltean To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH net-next 03/14] phy: qcom-sgmii-eth: add .set_mode() and .validate() methods Message-ID: <20260114190253.ttrookxubevt7aku@skbuf> References: <20260114184705.djvad5phrnfen6wx@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260114_110259_095193_ADB76E13 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Wed, Jan 14, 2026 at 06:55:34PM +0000, Russell King (Oracle) wrote: > On Wed, Jan 14, 2026 at 08:47:05PM +0200, Vladimir Oltean wrote: > > On Wed, Jan 14, 2026 at 05:45:24PM +0000, Russell King (Oracle) wrote: > > > qcom-sgmii-eth is an Ethernet SerDes supporting only Ethernet mode > > > using SGMII, 1000BASE-X and 2500BASE-X. > > > > > > Add an implementation of the .set_mode() method, which can be used > > > instead of or as well as the .set_speed() method. The Ethernet > > > interface modes mentioned above all have a fixed data rate, so > > > setting the mode is sufficient to fully specify the operating > > > parameters. > > > > > > Add an implementation of the .validate() method, which will be > > > necessary to allow discovery of the SerDes capabilities for platform > > > independent SerDes support in the stmmac netowrk driver. > > > > s/netowrk/network/ > > > > > > > > Signed-off-by: Russell King (Oracle) > > > --- > > > > Reviewed-by: Vladimir Oltean > > According to patchwork (I forgot the RFC tag on the patches) it needs > linux/phy.h included. Plesae let me know if you'd like me to retain > your r-b. Thanks. Ah, ok, I thought that the SPEED_* macros are also phylib-specific like PHY_INTERFACE_MODE_*, and hence, the phylib header would already be included, but it seems the SPEED_* macros are provided by include/uapi/linux/ethtool.h. Go figure... Please keep the review tag. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy