public inbox for linux-phy@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency
@ 2026-02-02  9:51 Arnd Bergmann
  2026-02-03  8:24 ` Tommaso Merciai
  2026-02-04 15:44 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-02-02  9:51 UTC (permalink / raw)
  To: Vinod Koul, Tommaso Merciai
  Cc: Arnd Bergmann, Neil Armstrong, Biju Das, linux-phy, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The driver start registering a regulator, but can still be
enabled even when it is unable to call into the regulator
subsystem:

aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'

Add a Kconfig dependency to avoid this configuration.

Fixes: b6d7dd157763 ("phy: renesas: rcar-gen3-usb2: Add regulator for OTG VBUS control")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/phy/renesas/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
index d217c630b2fd..90a9ca2db7fc 100644
--- a/drivers/phy/renesas/Kconfig
+++ b/drivers/phy/renesas/Kconfig
@@ -29,6 +29,7 @@ config PHY_RCAR_GEN3_USB2
 	depends on ARCH_RENESAS
 	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
 	depends on USB_SUPPORT
+	depends on REGULATOR
 	select GENERIC_PHY
 	select MULTIPLEXER
 	select USB_COMMON
-- 
2.39.5


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency
  2026-02-02  9:51 [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency Arnd Bergmann
@ 2026-02-03  8:24 ` Tommaso Merciai
  2026-02-04 15:44 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Tommaso Merciai @ 2026-02-03  8:24 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Vinod Koul, Arnd Bergmann, Neil Armstrong, Biju Das, linux-phy,
	linux-kernel

On Mon, Feb 02, 2026 at 10:51:14AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver start registering a regulator, but can still be
> enabled even when it is unable to call into the regulator
> subsystem:
> 
> aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
> phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'
> 
> Add a Kconfig dependency to avoid this configuration.
> 
> Fixes: b6d7dd157763 ("phy: renesas: rcar-gen3-usb2: Add regulator for OTG VBUS control")

Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/phy/renesas/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> index d217c630b2fd..90a9ca2db7fc 100644
> --- a/drivers/phy/renesas/Kconfig
> +++ b/drivers/phy/renesas/Kconfig
> @@ -29,6 +29,7 @@ config PHY_RCAR_GEN3_USB2
>  	depends on ARCH_RENESAS
>  	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
>  	depends on USB_SUPPORT
> +	depends on REGULATOR
>  	select GENERIC_PHY
>  	select MULTIPLEXER
>  	select USB_COMMON
> -- 
> 2.39.5
> 

Thanks & Regards,
Tommaso

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency
  2026-02-02  9:51 [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency Arnd Bergmann
  2026-02-03  8:24 ` Tommaso Merciai
@ 2026-02-04 15:44 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-02-04 15:44 UTC (permalink / raw)
  To: Tommaso Merciai, Arnd Bergmann
  Cc: Arnd Bergmann, Neil Armstrong, Biju Das, linux-phy, linux-kernel


On Mon, 02 Feb 2026 10:51:14 +0100, Arnd Bergmann wrote:
> The driver start registering a regulator, but can still be
> enabled even when it is unable to call into the regulator
> subsystem:
> 
> aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
> phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'
> 
> [...]

Applied, thanks!

[1/1] phy: renesas: rcar-gen3-usb2: add regulator dependency
      commit: 3a03a0e47cf2e0ec7ce7ca9e0bf4c59ec537ad09

Best regards,
-- 
~Vinod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-04 15:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-02  9:51 [PATCH] phy: renesas: rcar-gen3-usb2: add regulator dependency Arnd Bergmann
2026-02-03  8:24 ` Tommaso Merciai
2026-02-04 15:44 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox