From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E7D2FEE4F2 for ; Sat, 28 Feb 2026 16:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C/qfW+ZwxFFVz5vDo5G8oC5iF9ImoBnb3TEbwW/W2tk=; b=FumZO9K2dZJY9+ YvPlPRvdtoFH2MPABbV31kpAL9Ym2vjqHxSYCkPOECs5ACqqDfeLjfkr5N8pJxZA8Hodhs/tfFJez mkpQyTtzjH5bCT294GzAX3ghG+MuYTr1ocfOjD/FmNWcMyxpTnSwGjMVFLP3leMUJBF4fjexNSolF hHrW63dm13mkmgRRklr5tQT6IQJju10vRxwzMuzMtXR1FLHgEaCMJSAxjQ/FHz7uSiEuelSxBz9nt 5cmHPAD3ElIyj7yWbGh7Uq2BPrdW8ai/qLIrZ4zzT9TJ5uZe+It3yLaVvgaU7snUb6TlsfsAC5GZq 3kZl8n0fO6p9MuQGrTgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwNDn-0000000A3RV-3aO3; Sat, 28 Feb 2026 16:31:15 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwNDm-0000000A3RD-1OwL; Sat, 28 Feb 2026 16:31:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6B7CD600CB; Sat, 28 Feb 2026 16:31:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 818F0C116D0; Sat, 28 Feb 2026 16:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772296273; bh=nT2o6uADu1l9was26u2c5s17fQJ4nx20mIidrP/gZI4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p+YPb6ttQ6QDD9awfMfrizt7DNQtdRhfQkE38+s34ZDF/Tb7oKq1yGHoUU4NHwH1z XTdf58qtRQ9sn2EGxvAzzK2mvu59VEQzYM+vrXrq2bDMMfKFq2AxK3HJavAVWsCqLJ ROhc2MGrzX2RKFbzMj/iH8HnGEywkIKDyIP1pTAWvuEWJWExxGjma3aLSU8T3SGBMf vrA/jjKFj5l6RUobRqeY01LDJt3tKB5lLWTozwgfK71REtg980NbVjcwuK3O86AaoS MR5ybCFQv5gZZphy/a5gk4wYeRe8b6oc/2sHJAdHXorD3PhbsnlCkdH+8Wa3prueqO IXAcB158q1qqQ== Date: Sat, 28 Feb 2026 08:31:11 -0800 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation Message-ID: <20260228083111.5df8550c@kernel.org> In-Reply-To: <20260227165556.5cf9e844@kernel.org> References: <20260227165556.5cf9e844@kernel.org> MIME-Version: 1.0 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, 27 Feb 2026 16:55:56 -0800 Jakub Kicinski wrote: > On Sat, 28 Feb 2026 00:11:29 +0000 Russell King (Oracle) wrote: > > The AI review for patch 7 says: > > > > This commit fixes a bug but lacks a Fixes: tag. The commit modifies > > behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add > > .set_mode() and .validate() methods") by making phy_power_on() call > > qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by > > making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on > > before attempting calibration. > > > > Should this commit include: > > > > Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods") > > > > which is _wrong_, this isn't a bug fix. > > Yes, that's what I thought but then I saw the other thread.. Trying to apply this now but stmmac parts don't apply on Linus's tree, and Vinod wants a tag :( What do we do? Could you, perhaps, send us a PR with this on top of Linus's tree (a resolution of the inevitable conflict with net-next would be helpful too). Or do we give up on the tag? -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy