From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CF5AF41986 for ; Wed, 15 Apr 2026 10:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=LUS0RuQwHW0x+Dfog8+FGUPK5N06HhJ28g0gw3+/+sI=; b=GUXXfHxbPcDdCP 9QgY38iF8V23gyAtrIRa1YFVX7oNubcFyUJFoFK6fLxwht9+GvEW2DFPgjdVm8bLA4t35FEqKBg+W 84Iuv+a30FDm/VpqLZ2+3rF8OGEL0nsXBYR8+h6kVVX4yzlcv31Rm8jVDlZKCskhUYeG8WX2DNQ0e 3NIbMHkU8tCHhd2J8iHhfjQfsL9mZ3a2eR5Msrzj4pldPThcaLt3DArhuYhRivRlKKUQrDnCKhPo9 OvgEwSsErqS1TmpfAkxGpYe8w0vYMgxRPFF+duNRkBrmSC98RPg4XNL9w8nDMPJlnTpxhsX5/2hEU PA8QPHvCUTYKxOKtszfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCxo1-00000000zhQ-3qK4; Wed, 15 Apr 2026 10:49:13 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wCxny-00000000zgw-2TNE for linux-phy@lists.infradead.org; Wed, 15 Apr 2026 10:49:11 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63F9x5Cm1701751; Wed, 15 Apr 2026 10:49:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=IaFZ/jUtQskyYUrB3PlnQwqoEyTQvXvwAD7 +flNMQ0c=; b=oqlTHCBA7t2XPKa/dB22XrbxtI96oL1v1MfyGGdegY30c0qGZWB phaVe9Xp1lB8fCJsW52HMdSKRtuhls8bLF4pfnTaK7DTuAlqaLhMDvERo+INVmXf xIAsOztCpLgxTFSom7Ygv8j2yOPKZ+MXco9zyQGdxqNKAUmWcsSgcreOXnaKvU47 lFiFLy/D6dqid1PJ1wEn1b5R1yJTM1NfOt7H1GmxUDhBLN9rybg0PWgC67YLzz+q HmyXRVVNA9SOffVD0z88uKuHEuoPnfVNmsG6nYbKLFjqiWMxZsLDtW15EMBb5WCD fid0ymr2PvAhT9YXwq2+3pkk2cS7R/7P0kA== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dht56twbb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Apr 2026 10:49:04 +0000 (GMT) Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.18.1.7/8.18.1.7) with ESMTP id 63FAn1Gw016427; Wed, 15 Apr 2026 10:49:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTPS id 4dg5d11btb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Apr 2026 10:49:01 +0000 (GMT) Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.1.12) with ESMTP id 63FAn0ta016417; Wed, 15 Apr 2026 10:49:00 GMT Received: from hu-devc-hyd-u22-c.qualcomm.com ([10.213.101.157]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTPS id 63FAn0UJ016415 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Apr 2026 10:49:00 +0000 (GMT) Received: by hu-devc-hyd-u22-c.qualcomm.com (Postfix, from userid 2342877) id C1C5A5F0; Wed, 15 Apr 2026 16:18:59 +0530 (+0530) From: Nitin Rawat To: vkoul@kernel.org, neil.armstrong@linaro.org, konrad.dybcio@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, mani@kernel.org, abel.vesa@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Nitin Rawat , stable@vger.kernel.org Subject: [PATCH] phy: qcom-qmp-ufs: Fix kaanapali PHY PLL lock failure after SM8650 G4 fix Date: Wed, 15 Apr 2026 16:18:51 +0530 Message-Id: <20260415104851.2763238-1-nitin.rawat@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: VaDh0r7muCZ5B-hP0R8PE6ROCim5d6of X-Proofpoint-GUID: VaDh0r7muCZ5B-hP0R8PE6ROCim5d6of X-Authority-Analysis: v=2.4 cv=K9gS2SWI c=1 sm=1 tr=0 ts=69df6d20 cx=c_pps a=Ou0eQOY4+eZoSc0qltEV5Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=XlGZrpHi-DB37YRDZ8oA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE1MDA5OSBTYWx0ZWRfXxjvJKeXvBW7K Cpya/QTkDp1q308W5imIci+VWyif3zP5yZ47lJOYUalU+/8vnh6dh0TMFgzdRbMXsYIUs9NIX2w bOg3ufs2qLeEF/DGvn0DyN122/akw2Pzn2eSrdqLVCqG5AeQrKOga6+xA9jBhrNv5LdUlfmsVjG Ivlo+eKQAj1skTzluY57NCUVxc22CeT22ZOrlKkq8TJJnaSSK7zpf39yQr4pg7Rafwu97wVrFZk 7MjlTY4g4vXMR4BLHlgnJocVj5flM1yHrwEi+7iGQnT/g2GaH8qieutQLeV9TbmaFD2z1sjwbwd LdmeMJ3Fw7CVqr0AtmxUvnWUfFEmkKH+2yE+tbujJm5IJrgEK1H8iebzo0JS1C0NRWvzgAB9vS3 E314os0vFdSrxQw9EBKGe7bDqFNZPDg2SD7qirU/UjDnG/Ia4nJkqVxC4xV1mvexg1MuArMY/cU wKw+g6e9wQ5EhRXHTrA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_04,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 spamscore=0 clxscore=1011 phishscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604150099 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260415_034910_743002_A1A9C26E X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Commit 81af9e40e2e4 ("phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4") moved QPHY_V6_PCS_UFS_PLL_CNTL register configuration from the shared sm8650_ufsphy_g5_pcs table to the SM8650-specific sm8650_ufsphy_pcs base table to fix Gear 4 operation on SM8650. However, this change inadvertently broke kaanapali and SM8750 SoCs which also rely on the shared sm8650_ufsphy_g5_pcs table for Gear 5 configuration but use their own sm8750_ufsphy_pcs base table. After the change, kaanapali PHYs are left without the required PLL_CNTL = 0x33 setting, causing the PHY PLL to remain at its hardware reset default value, preventing PLL lock and resulting in DME_LINKSTARTUP timeouts. Fix this by adding the missing QPHY_V6_PCS_UFS_PLL_CNTL = 0x33 entry to the sm8750_ufsphy_pcs table, mirroring what the original commit already did for sm8650_ufsphy_pcs. Cc: stable@vger.kernel.org # v6.19.12 Fixes: 81af9e40e2e4 ("phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4") Signed-off-by: Nitin Rawat --- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c index 771bc7c2ab50..b87314c8379d 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c @@ -1112,6 +1112,7 @@ static const struct qmp_phy_init_tbl sm8750_ufsphy_pcs[] = { QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_MULTI_LANE_CTRL1, 0x02), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_MID_TERM_CTRL1, 0x43), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PCS_CTRL1, 0x40), + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PLL_CNTL, 0x33), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_LARGE_AMP_DRV_LVL, 0x0f), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_SIGDET_CTRL2, 0x68), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_POST_EMP_LVL_S4, 0x0e), -- 2.34.1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy