Re: [PATCH v9 3/5] phy: qcom: apq8064-sata: extract UNI PLL register defines

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added header file `phy-qcom-uniphy.h` uses the `BIT()` macro but does not include `<linux/bits.h>`.
--

commit a5da58070a4428e27ba521e2ed52d6c1d0de97b5
Author: Dmitry Baryshkov <lumag@kernel.org>

phy: qcom: apq8064-sata: extract UNI PLL register defines

The "uni" PLL is shared between several PHYS. Extract the common register
names to a separate header with the hope of later having the common code
to handle PLL in those PHYs.

> diff --git a/drivers/phy/qualcomm/phy-qcom-uniphy.h b/drivers/phy/qualcomm/phy-qcom-uniphy.h
> new file mode 100644
> index 0000000000000..5f18f9593cda7
> --- /dev/null
> +++ b/drivers/phy/qualcomm/phy-qcom-uniphy.h
> @@ -0,0 +1,33 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (c) 2014, The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef PHY_QCOM_UNIPHY_H
> +#define PHY_QCOM_UNIPHY_H

[ ... ]

> +#define UNIPHY_PLL_STATUS		0x0c0
> +#define UNIPHY_PLL_LOCK				BIT(0)

Since this header file uses the BIT() macro, should it include
<linux/bits.h> to ensure it is self-contained?

Relying on implicit inclusions from the C files that include this header
might cause compilation errors in the future if those files do not already
have the macro defined in their include chain.

> +
> +#endif

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-fd-hdmi-phy-v9-0-ca98c72f1f9f@oss.qualcomm.com?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy