From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B508CD4F3C for ; Mon, 18 May 2026 07:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M4pbA8eDFJ/JwuesjxU8HJ+K4vbvKBx5g9gk7Mp2W88=; b=YIfUNh+NHtm6yk e1FAwP1W11la6gOqcoOLOvwCLKMN36OgWEIor/VYN7Oscp5ahWkQCYH+eNSjyYdkQtAkDiuTcW/Hd Mrkam86I4olrrHIDy0JHC8DTmAYE4iPmkRaVXGIlxVUwkTE4nPt0DRrrEfxZefmpB2wOPwWjy7Df3 F7ffj0ohVFtHUs3qt39O44fho+a4i406btHO9ZH5civDyx1lyo9chc0d09rl9t7C71PWqW56dRywz tO/6zoA4xIKQN4YntQrDUVjNBbM5gZsX+TifF/4S0EV86rTnP2whZcSa4C35WHJFrFr50jCxqrccB 3sBkk6eqDU0gHviZwzww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOsiK-0000000EfTj-0VfA; Mon, 18 May 2026 07:48:36 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOsiH-0000000EfSw-1m3V for linux-phy@lists.infradead.org; Mon, 18 May 2026 07:48:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E125943C8F; Mon, 18 May 2026 07:48:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F475C2BCF5; Mon, 18 May 2026 07:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779090512; bh=8yeKLbA6TTlPkx/nw/lYFKXTqmximCR8w83wUFWkB4A=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=BmlonbwuSuafrn9CFOwbpN0LCExZO+xUh6Vt2vGqr6B5g9deeuWDbPKW0ehyzCplP ZzeoNuvYDg5ggz54f8D80vaU26945Rp1Uz43VhwR0OrOrZQ3Djo3lKZ8TKAHS5xL1U fIsFoZGengyMbLKFfW3I8YL7gxXb86mpvRylYX3rlQW7qJGF4CdAKsHCLGO/kMh5qb /GtMwvS/Li0O46EXlZE327WISCcJ9weDlhrpNdyrp9oDuphKq21cJND8y0iia8nPio ox+Jiz7gCA3aNJ14TqJQONwZa04GcBn0ZmcAXNCxHztw80a0BDDiqQ/noXEviYgpqn dUZ3+7Ly+fKJw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 4/4] phy: ti-pipe3: Fix clock leak in init error path To: "Hongling Zeng" Cc: olteanv@gmail.com, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, vkoul@kernel.org In-Reply-To: <20260518062938.48114-5-zenghongling@kylinos.cn> References: <20260518062938.48114-5-zenghongling@kylinos.cn> Date: Mon, 18 May 2026 07:48:31 +0000 Message-Id: <20260518074832.8F475C2BCF5@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260518_004833_506398_303BEE5C X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFJlc291cmNlIGxlYWsg aW4gdGlfcGlwZTNfaW5pdCgpIGZvciBTQVRBIG1vZGUgbGF0ZS1sb2NrIHJhY2UuCi0gW0hpZ2hd IFVuYmFsYW5jZWQgY2xvY2sgbGlmZWN5Y2xlIG9wZXJhdGlvbnMgZm9yIFNBVEEgbW9kZSBkdWUg dG8gZWFybHkgcmV0dXJuIGluIHRpX3BpcGUzX2V4aXQoKS4KLS0KCmNvbW1pdCBkMjgyMjg3OWY3 OWI0YmU5NTNhNDY1ODQ3YTg2MjEwNjBjYWEzNmFjCkF1dGhvcjogSG9uZ2xpbmcgWmVuZyA8emVu Z2hvbmdsaW5nQGt5bGlub3MuY24+ClN1YmplY3Q6IHBoeTogdGktcGlwZTM6IEZpeCBjbG9jayBs ZWFrIGluIGluaXQgZXJyb3IgcGF0aAoKVGhpcyBjb21taXQgZml4ZXMgYSBjbG9jayByZWZlcmVu Y2UgY291bnQgbGVhayBpbiB0aGUgUENJZSBlcnJvciBwYXRoIG9mCnRpX3BpcGUzX2luaXQoKS4g SXQgZXhwbGljaXRseSBjYWxscyB0aV9waXBlM19kaXNhYmxlX2Nsb2NrcygpIHdoZW4KcmVnbWFw X3VwZGF0ZV9iaXRzKCkgZmFpbHMsIGVuc3VyaW5nIHByb3BlciBjbGVhbnVwIHNpbmNlIHRoZSBQ SFkgZnJhbWV3b3JrCndvbid0IGludm9rZSB0aGUgLmV4aXQgY2FsbGJhY2sgb24gaW5pdCBmYWls dXJlLgoKTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjYwNTE4MDIzNjU3LjQx ODUyQzJCQ0IwQHNtdHAua2VybmVsLm9yZy8KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3Rp L3BoeS10aS1waXBlMy5jIGIvZHJpdmVycy9waHkvdGkvcGh5LXRpLXBpcGUzLmMKPiBpbmRleCA5 ZWMyMjhjMmE5NDBjLi40ODk3ZTRiYTJkN2RiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L3Rp L3BoeS10aS1waXBlMy5jCj4gKysrIGIvZHJpdmVycy9waHkvdGkvcGh5LXRpLXBpcGUzLmMKPiBA QCAtNTE4LDYgKzUxOCw4IEBAIHN0YXRpYyBpbnQgdGlfcGlwZTNfaW5pdChzdHJ1Y3QgcGh5ICp4 KQo+ICAJCXZhbCA9IDB4OTYgPDwgT01BUF9DVFJMX1BDSUVfUENTX0RFTEFZX0NPVU5UX1NISUZU Owo+ICAJCXJldCA9IHJlZ21hcF91cGRhdGVfYml0cyhwaHktPnBjc19zeXNjb24sIHBoeS0+cGNp ZV9wY3NfcmVnLAo+ICAJCQkJCSBQQ0lFX1BDU19NQVNLLCB2YWwpOwo+ICsJCWlmIChyZXQpCj4g KwkJCXRpX3BpcGUzX2Rpc2FibGVfY2xvY2tzKHBoeSk7Cj4gIAkJcmV0dXJuIHJldDsKPiAgCX0K PiAgCgpUaGlzIHByb2JsZW0gd2Fzbid0IGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGEg c2ltaWxhciByZWdyZXNzaW9uCmV4aXN0cyBpbiB0aGUgZXJyb3IgaGFuZGxpbmcgcGF0aCBvZiB0 aV9waXBlM19pbml0KCkganVzdCBiZWxvdyB0aGlzIGJsb2NrLgoKV2hlbiBicmluZ2luZyB0aGUg RFBMTCBvdXQgb2YgSURMRSwgaWYgdGlfcGlwZTNfZHBsbF93YWl0X2xvY2soKSB0aW1lcyBvdXQs Cml0IHNldHMgcmV0IHRvIC1FQlVTWS4gSW1tZWRpYXRlbHkgYWZ0ZXIsIFBMTF9TVEFUVVMgaXMg cmVhZDoKCgl2YWwgPSB0aV9waXBlM19yZWFkbChwaHktPnBsbF9jdHJsX2Jhc2UsIFBMTF9DT05G SUdVUkFUSU9OMik7CglpZiAodmFsICYgUExMX0lETEUpIHsKCQl2YWwgJj0gflBMTF9JRExFOwoJ CXRpX3BpcGUzX3dyaXRlbChwaHktPnBsbF9jdHJsX2Jhc2UsIFBMTF9DT05GSUdVUkFUSU9OMiwg dmFsKTsKCQlyZXQgPSB0aV9waXBlM19kcGxsX3dhaXRfbG9jayhwaHkpOwoJfQoKCS8qIFNBVEEg aGFzIGlzc3VlcyBpZiByZS1wcm9ncmFtbWVkIHdoZW4gbG9ja2VkICovCgl2YWwgPSB0aV9waXBl M19yZWFkbChwaHktPnBsbF9jdHJsX2Jhc2UsIFBMTF9TVEFUVVMpOwoJaWYgKCh2YWwgJiBQTExf TE9DSykgJiYgcGh5LT5tb2RlID09IFBJUEUzX01PREVfU0FUQSkKCQlyZXR1cm4gcmV0OwoKSWYg dGhlIERQTEwgbG9ja2VkIGp1c3QgYWZ0ZXIgdGhlIHRpbWVvdXQsIHRoZSBQTExfTE9DSyBiaXQg d2lsbCBiZSBzZXQuCkZvciBTQVRBIG1vZGUsIHRoZSBmdW5jdGlvbiByZXR1cm5zIC1FQlVTWSBl YXJseSB3aXRob3V0IGNhbGxpbmcKdGlfcGlwZTNfZGlzYWJsZV9jbG9ja3MoKS4KClNpbmNlIHRo ZSBQSFkgZnJhbWV3b3JrIHdvbid0IGludm9rZSB0aGUgZXhpdCBjYWxsYmFjayBvbiBhbiBpbml0 IGZhaWx1cmUsCndpbGwgdGhpcyBsZWFrIHRoZSBjbG9jayByZWZlcmVuY2UgY291bnRzPwoKU2hv dWxkIHRoZSBmdW5jdGlvbiBlaXRoZXIgcmV0dXJuIDAgaGVyZSB0byB0cmVhdCB0aGUgbGF0ZSBs b2NrIGFzIGEgc3VjY2VzcywKb3IgY2FsbCB0aV9waXBlM19kaXNhYmxlX2Nsb2NrcygpIGJlZm9y ZSByZXR1cm5pbmcgdGhlIGVycm9yPwoKQW5vdGhlciByZWdyZXNzaW9uIHRoYXQgd2Fzbid0IGlu dHJvZHVjZWQgYnkgdGhpcyBwYXRjaCBleGlzdHMgaW4gdGhlIGRyaXZlcidzCmxpZmVjeWNsZSBt YW5hZ2VtZW50IGZvciBTQVRBIG1vZGUuCgpJbiB0aV9waXBlM19leGl0KCksIGlmIHRoZSBtb2Rl IGlzIFNBVEEgYW5kIGRwbGxfcmVzZXRfc3lzY29uIGlzIG5vdCBwcmVzZW50LAp0aGUgZnVuY3Rp b24gcmV0dXJucyBlYXJseSB0byBhdm9pZCBwb3dlcmluZyBkb3duIHRoZSBTQVRBIERQTEwgZHVl IHRvCkVycmF0YSBpNzgzOgoKc3RhdGljIGludCB0aV9waXBlM19leGl0KHN0cnVjdCBwaHkgKngp CnsKCXN0cnVjdCB0aV9waXBlMyAqcGh5ID0gcGh5X2dldF9kcnZkYXRhKHgpOwoKCS8qIElmIGRw bGxfcmVzZXRfc3lzY29uIGlzIG5vdCBwcmVzZW50IHdlIHdvbnQgcG93ZXIgZG93biBTQVRBIERQ TEwKCSAqIGR1ZSB0byBFcnJhdGEgaTc4MwoJICovCglpZiAocGh5LT5tb2RlID09IFBJUEUzX01P REVfU0FUQSAmJiAhcGh5LT5kcGxsX3Jlc2V0X3N5c2NvbikKCQlyZXR1cm4gMDsKCkhvd2V2ZXIs IGl0IHJldHVybnMgd2l0aG91dCBjYWxsaW5nIHRpX3BpcGUzX2Rpc2FibGVfY2xvY2tzKCkuCgpC ZWNhdXNlIHRpX3BpcGUzX2luaXQoKSB1bmNvbmRpdGlvbmFsbHkgY2FsbHMgdGlfcGlwZTNfZW5h YmxlX2Nsb2NrcygpLApjb3VsZCByZXBlYXRlZCBpbml0aWFsaXphdGlvbiBhbmQgZXhpdCBjeWNs ZXMsIHN1Y2ggYXMgZHVyaW5nIHN1c3BlbmQgYW5kCnJlc3VtZSBvciBtb2R1bGUgcmVsb2FkLCBp bnZva2UgY2xrX3ByZXBhcmVfZW5hYmxlKCkgd2l0aG91dCBtYXRjaGluZwpjbGtfZGlzYWJsZV91 bnByZXBhcmUoKSBjYWxscz8KCklmIHRoZSBlcnJhdGEgc3RyaWN0bHkgcmVxdWlyZXMga2VlcGlu ZyB0aGUgY2xvY2tzIGVuYWJsZWQsIGRvZXMgdGhlIGRyaXZlcgpuZWVkIHRvIHRyYWNrIHRoZSBp bml0aWFsaXphdGlvbiBzdGF0ZSB0byBhdm9pZCBkb3VibGUtZW5hYmxpbmc/IEFsdGVybmF0aXZl bHksCnNob3VsZCBpdCBwcm9wZXJseSBkaXNhYmxlIHRoZSBjbG9ja3MgYmVmb3JlIHJldHVybmlu Zz8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hz ZXQvMjAyNjA1MTgwNjI5MzguNDgxMTQtMS16ZW5naG9uZ2xpbmdAa3lsaW5vcy5jbj9wYXJ0PTQK Ci0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=