From: sashiko-bot@kernel.org
To: "Vladimir Oltean" <vladimir.oltean@nxp.com>
Cc: vkoul@kernel.org, olteanv@gmail.com,
linux-phy@lists.infradead.org, neil.armstrong@linaro.org
Subject: Re: [PATCH v2 phy-next 02/15] phy: lynx-28g: move lane mode helpers to new core module
Date: Fri, 29 May 2026 17:27:05 +0000 [thread overview]
Message-ID: <20260529172706.50EC21F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260529171509.1163787-3-vladimir.oltean@nxp.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The enum values for `lynx_lane_mode` are globally exposed without proper namespacing, risking build failures due to collisions.
- [Low] Invisible Kconfig symbol contains useless 'help' text.
--
commit afcf6c44814cd194adbadc7748b22b52095d7d42
Author: Vladimir Oltean <vladimir.oltean@nxp.com>
phy: lynx-28g: move lane mode helpers to new core module
This commit extracts lane mode helpers and shared structures from the
lynx-28g driver into a new core module. The lane modes are exported to
a public header to allow coordination with the upcoming lynx-10g driver.
> diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig
> index 81f53564ee156..a87429f634ea8 100644
> --- a/drivers/phy/freescale/Kconfig
> +++ b/drivers/phy/freescale/Kconfig
> @@ -51,11 +51,18 @@ config PHY_FSL_SAMSUNG_HDMI_PHY
> Enable this to add support for the Samsung HDMI PHY in i.MX8MP.
> endif
>
> +config PHY_FSL_LYNX_CORE
> + tristate
> + help
> + Enable this to add common support code for NXP Lynx 10G and Lynx 28G
> + SerDes blocks.
[Severity: Low]
This isn't a bug, but does this invisible Kconfig symbol need a help text?
Since this tristate doesn't have a prompt string, it won't be visible in
menuconfig, making the help text inaccessible to users.
[ ... ]
> diff --git a/include/soc/fsl/phy-fsl-lynx.h b/include/soc/fsl/phy-fsl-lynx.h
> new file mode 100644
> index 0000000000000..92e8272d5ae15
> --- /dev/null
> +++ b/include/soc/fsl/phy-fsl-lynx.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright 2023-2026 NXP */
> +
> +#ifndef __PHY_FSL_LYNX_H_
> +#define __PHY_FSL_LYNX_H_
> +
> +enum lynx_lane_mode {
> + LANE_MODE_UNKNOWN,
> + LANE_MODE_1000BASEX_SGMII,
> + LANE_MODE_10GBASER,
> + LANE_MODE_USXGMII,
> + LANE_MODE_25GBASER,
> + LANE_MODE_MAX,
> +};
[Severity: Low]
Since this header is now globally accessible under include/soc/, could these
generic enum values cause namespace collisions?
Values like LANE_MODE_UNKNOWN and LANE_MODE_MAX lack a subsystem or
driver-specific prefix (like LYNX_ or FSL_). If another subsystem defines
a macro or enum with the same generic name, it might lead to build failures.
> +
> +#endif /* __PHY_FSL_LYNX_H_ */
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529171509.1163787-1-vladimir.oltean@nxp.com?part=2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-05-29 17:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 17:14 [PATCH v2 phy-next 00/15] New Generic PHY driver for Lynx 10G SerDes Vladimir Oltean
2026-05-29 17:14 ` [PATCH v2 phy-next 01/15] phy: lynx-28g: reject probing on devices with unsupported OF nodes Vladimir Oltean
2026-05-29 17:35 ` sashiko-bot
2026-05-29 17:14 ` [PATCH v2 phy-next 02/15] phy: lynx-28g: move lane mode helpers to new core module Vladimir Oltean
2026-05-29 17:27 ` sashiko-bot [this message]
2026-05-29 17:14 ` [PATCH v2 phy-next 03/15] phy: lynx-28g: move data structures to core Vladimir Oltean
2026-05-29 17:14 ` [PATCH v2 phy-next 04/15] phy: lynx-28g: common lynx_pll_get() Vladimir Oltean
2026-05-29 17:14 ` [PATCH v2 phy-next 05/15] phy: lynx-28g: generalize protocol converter accessors Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 06/15] phy: lynx-28g: provide default lynx_lane_supports_mode() implementation Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 07/15] phy: lynx-28g: move struct lynx_info definitions downwards Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 08/15] phy: lynx-28g: make lynx_28g_pll_read_configuration() callable per PLL Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 09/15] phy: lynx-28g: common probe() and remove() Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 10/15] phy: lynx-28g: add support for big endian register maps Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 11/15] phy: lynx-28g: optimize read-modify-write operation Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 12/15] phy: lynx-28g: improve phy_validate() procedure Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 13/15] dt-bindings: phy: lynx-10g: initial document Vladimir Oltean
2026-05-29 17:15 ` [PATCH v2 phy-next 14/15] phy: lynx-10g: new driver Vladimir Oltean
2026-05-29 18:21 ` sashiko-bot
2026-05-29 17:15 ` [PATCH v2 phy-next 15/15] MAINTAINERS: expand Lynx 28G entry to cover Lynx 10G SerDes Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529172706.50EC21F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox