From: sashiko-bot@kernel.org
To: "Vladimir Oltean" <vladimir.oltean@nxp.com>
Cc: neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 phy-next 14/16] dt-bindings: phy: lynx-10g: initial document
Date: Mon, 08 Jun 2026 22:27:42 +0000 [thread overview]
Message-ID: <20260608222742.C65531F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260608221710.1572971-15-vladimir.oltean@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Schema validation error due to conditionally required `big-endian` property not declared at the top-level
--
commit 2c5c4d6b6c1efda8718b0e291015499912a81e6e
Author: Vladimir Oltean <vladimir.oltean@nxp.com>
dt-bindings: phy: lynx-10g: initial document
This commit adds the YAML device tree binding schema for the 10G Lynx
SerDes, supporting various QorIQ and Layerscape SoCs. It defines a common
register map with SoC-specific configurations handled via conditional blocks.
> diff --git a/Documentation/devicetree/bindings/phy/fsl,lynx-10g.yaml b/Documentation/devicetree/bindings/phy/fsl,lynx-10g.yaml
> new file mode 100644
> index 0000000000000..eaef585338258
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/fsl,lynx-10g.yaml
[ ... ]
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,ls1046a-serdes1
> + - fsl,ls1046a-serdes2
> + then:
> + properties:
> + big-endian: true
> + required:
> + - big-endian
[Severity: Low]
Will this cause a schema validation error when dtbs_check is run?
Because big-endian is omitted from the top-level properties block, it
appears the additionalProperties constraint below will reject it even
when the compatible string matches.
Could big-endian: type: boolean be added to the top-level properties
dictionary, or should additionalProperties: false be changed to
unevaluatedProperties: false?
> +
> +additionalProperties: false
> +
> +examples:
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260608221710.1572971-1-vladimir.oltean@nxp.com?part=14
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-06-08 22:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 22:16 [PATCH v4 phy-next 00/16] New Generic PHY driver for Lynx 10G SerDes Vladimir Oltean
2026-06-08 22:16 ` [PATCH v4 phy-next 01/16] phy: lynx-28g: avoid returning NULL in of_xlate() function Vladimir Oltean
2026-06-08 22:26 ` sashiko-bot
2026-06-08 22:16 ` [PATCH v4 phy-next 02/16] phy: lynx-28g: reject probing on devices with unsupported OF nodes Vladimir Oltean
2026-06-08 22:16 ` [PATCH v4 phy-next 03/16] phy: lynx-28g: move lane mode helpers to new core module Vladimir Oltean
2026-06-08 22:24 ` sashiko-bot
2026-06-08 22:16 ` [PATCH v4 phy-next 04/16] phy: lynx-28g: move data structures to core Vladimir Oltean
2026-06-08 22:16 ` [PATCH v4 phy-next 05/16] phy: lynx-28g: common lynx_pll_get() Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 06/16] phy: lynx-28g: generalize protocol converter accessors Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 07/16] phy: lynx-28g: provide default lynx_lane_supports_mode() implementation Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 08/16] phy: lynx-28g: move struct lynx_info definitions downwards Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 09/16] phy: lynx-28g: make lynx_28g_pll_read_configuration() callable per PLL Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 10/16] phy: lynx-28g: common probe() and remove() Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 11/16] phy: lynx-28g: add support for big endian register maps Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 12/16] phy: lynx-28g: optimize read-modify-write operation Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 13/16] phy: lynx-28g: improve phy_validate() procedure Vladimir Oltean
2026-06-08 22:17 ` [PATCH v4 phy-next 14/16] dt-bindings: phy: lynx-10g: initial document Vladimir Oltean
2026-06-08 22:27 ` sashiko-bot [this message]
2026-06-08 22:17 ` [PATCH v4 phy-next 15/16] phy: lynx-10g: new driver Vladimir Oltean
2026-06-08 22:33 ` sashiko-bot
2026-06-08 22:17 ` [PATCH v4 phy-next 16/16] MAINTAINERS: expand Lynx 28G entry to cover Lynx 10G SerDes Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608222742.C65531F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox