From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E936CD98E4 for ; Tue, 16 Jun 2026 14:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W6Y1tivwXDOzbivxK4Lj5jq/cTDkhuNSRFlAzaKF37Y=; b=xYl5X9zHVE56AE 7blL013UqyrCyWy2wvWLdxyPYTqX1uyfGGdjJx1lW7QrwWpJb+OQmQ3V+aIQKXJCI2UN3coRIVz54 naFhUNZC92wZJit7rCOhO3W3zsJAu78ESrZeo5eZOfH3et1Ldhc/7LhHvqaGeryG/+ZSXMYQ4Ruyu yb8oE8Upbyhl7We+TXKJ/n3C/GXI0wK4SrPoQ0wsqbSrj6RlZZDQKPHNgz/FvsIwIn3ThqAKFpYpl xUnmI63JU/C8e+DmVXnWW23mKV92mBbXF4xqceJPHqMO2JX1L+M8IJnsOwbsWQ51cEBDW6BtrwJ2U TRb1tDcz/Lm6s9qC0c+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZUqx-0000000FvVp-0mZs; Tue, 16 Jun 2026 14:33:23 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZUqw-0000000FvVK-0j8M for linux-phy@lists.infradead.org; Tue, 16 Jun 2026 14:33:22 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7F6DB60120; Tue, 16 Jun 2026 14:33:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0ED691F000E9; Tue, 16 Jun 2026 14:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781620401; bh=tnd9k/3C4C48ytmfymyB4OxcxNFgIjT3bhG9au/ax9U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QPSAjtNUOwd8HQNXHHhxDVtjr0A7kO4UYu1cEiyMbFG9Rd6c7r5cUBn/6s4spsUVJ sSO8ZNFVGOWmwKgyLjVdlLQzzqwYyvTC8f0MeAA98J1yc7N0vDLh6OcEZQVjrAwkDO BCydUAUAUyXJxEzQhSfhqyLS4cFbxB6l3S0SjR2m34LPzSvKT82fGnSlxN46nhCpY5 L9lkBJPtFWUEDPrwXhOE5LieIZVKBP7AlagT5jNUNoWwYihA6Ilj2ZaPcsJ6gbuX73 XgtUe2INHOHinmbw4uSgxw1LnZrRirPVvCXIPko907KcNBqu9gG/y4G9uZ5cwFsbvb OUFCqdojTqiSw== From: sashiko-bot@kernel.org Subject: Re: [PATCH] phy: sunplus: fix refcount leak in sp_uphy_init() To: "Wentao Liang" Cc: neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260616142234.1690457-1-vulab@iscas.ac.cn> References: <20260616142234.1690457-1-vulab@iscas.ac.cn> Date: Tue, 16 Jun 2026 14:33:20 +0000 Message-Id: <20260616143321.0ED691F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBLZXJuZWwgcGFuaWMgZHVlIHRvIGRlcmVmZXJlbmNpbmcgYW4gRVJSX1BUUiBpZiB0 aGUgb3B0aW9uYWwgbnZtZW0gY2VsbCBmYWlscyB0byBsb2FkLgotIFtIaWdoXSBNZW1vcnkgbGVh ayBvZiB0aGUgYnVmZmVyIHJldHVybmVkIGJ5IGBudm1lbV9jZWxsX3JlYWQoKWAuCi0gW0hpZ2hd IFVuY29uZGl0aW9uYWwgb3V0LW9mLWJvdW5kcyByZWFkIG9uIHRoZSBudm1lbSBidWZmZXIuCi0g W0hpZ2hdIEltYmFsYW5jZWQgY2xlYW51cCBpbiBlcnJvciBoYW5kbGluZyBjYXVzaW5nIHJlZmVy ZW5jZSBjb3VudCB1bmRlcmZsb3dzLgotLQoKY29tbWl0IDk4ZmQ0NzIzNmRiNjBiYjgyYmI5YTQz MWY2MDNlMjgyOTBmZjJhOGIKQXV0aG9yOiBXZW50YW8gTGlhbmcgPHZ1bGFiQGlzY2FzLmFjLmNu PgoKcGh5OiBzdW5wbHVzOiBmaXggcmVmY291bnQgbGVhayBpbiBzcF91cGh5X2luaXQoKQoKVGhp cyBjb21taXQgY2hhbmdlcyB0aGUgZXJyb3IgcGF0aCBpbiBzcF91cGh5X2luaXQgdG8gY29ycmVj dGx5IGp1bXAgdG8KZXJyX3Jlc2V0IGluc3RlYWQgb2YgcmV0dXJuaW5nIGRpcmVjdGx5IHdoZW4g dXBkYXRlX2Rpc2Nfdm9sIGZhaWxzLAplbnN1cmluZyByZXNvdXJjZXMgYXJlIGNsZWFuZWQgdXAu CgpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwpGaXhlczogOTlkOWNjZDk3Mzg1ICgicGh5OiB1 c2I6IEFkZCBVU0IyLjAgcGh5IGRyaXZlciBmb3IgU3VucGx1cyBTUDcwMjEiKQoKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9waHkvc3VucGx1cy9waHktc3VucGx1cy11c2IyLmMgYi9kcml2ZXJzL3Bo eS9zdW5wbHVzL3BoeS1zdW5wbHVzLXVzYjIuYwo+IGluZGV4IDYzN2E1ZmJhZTZkOWEuLmM3YmMz YWM4OWNhOWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvc3VucGx1cy9waHktc3VucGx1cy11 c2IyLmMKPiArKysgYi9kcml2ZXJzL3BoeS9zdW5wbHVzL3BoeS1zdW5wbHVzLXVzYjIuYwo+IEBA IC0xMjksNyArMTI5LDcgQEAgc3RhdGljIGludCBzcF91cGh5X2luaXQoc3RydWN0IHBoeSAqcGh5 KQo+ICAJLyogZGlzY29ubmVjdCB2b2x0YWdlICovCj4gIAlyZXQgPSB1cGRhdGVfZGlzY192b2wo dXNicGh5KTsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwg YnV0IGNvdWxkIHRoaXMgY2FsbCBsZWFkIHRvIGEga2VybmVsIHBhbmljCmlmIHRoZSBvcHRpb25h bCBudm1lbSBjZWxsIGZhaWxzIHRvIGxvYWQ/CgpJbiBkcml2ZXJzL3BoeS9zdW5wbHVzL3BoeS1z dW5wbHVzLXVzYjIuYzp1cGRhdGVfZGlzY192b2woKSwgdGhlIHJldHVybgp2YWx1ZSBvZiBudm1l bV9jZWxsX2dldCBpcyBjaGVja2VkLCBidXQgaWYgaXQgaXMgYW4gZXJyb3IgcG9pbnRlciBvdGhl cgp0aGFuIC1FUFJPQkVfREVGRVIsIGl0IGlzIHBhc3NlZCBkaXJlY3RseSB0byBudm1lbV9jZWxs X3JlYWQ6Cgpkcml2ZXJzL3BoeS9zdW5wbHVzL3BoeS1zdW5wbHVzLXVzYjIuYzp1cGRhdGVfZGlz Y192b2woKSB7CgljZWxsID0gbnZtZW1fY2VsbF9nZXQodXNicGh5LT5kZXYsIGRpc2NfbmFtZSk7 CglpZiAoSVNfRVJSX09SX05VTEwoY2VsbCkpIHsKCQlpZiAoUFRSX0VSUihjZWxsKSA9PSAtRVBS T0JFX0RFRkVSKQoJCQlyZXR1cm4gLUVQUk9CRV9ERUZFUjsKCX0KCglvdHBfdiA9IG52bWVtX2Nl bGxfcmVhZChjZWxsLCAmb3RwX2wpOwoJLi4uCn0KCkRvZXMgdGhpcyBjYXVzZSBhbiBpbnZhbGlk IG1lbW9yeSBhY2Nlc3Mgd2hlbiBudm1lbV9jZWxsX3JlYWQgYXR0ZW1wdHMgdG8KZGVyZWZlcmVu Y2UgdGhlIHVuaGFuZGxlZCBlcnJvciBwb2ludGVyPwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlz IGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9lcyB1cGRhdGVfZGlzY192b2woKSBsZWFrIHRo ZSBidWZmZXIKcmV0dXJuZWQgYnkgbnZtZW1fY2VsbF9yZWFkKCk/CgoJb3RwX3YgPSBudm1lbV9j ZWxsX3JlYWQoY2VsbCwgJm90cF9sKTsKCW52bWVtX2NlbGxfcHV0KGNlbGwpOwoKCWlmICghSVNf RVJSKG90cF92KSkgewoJCXNldCA9ICoob3RwX3YgKyAxKTsKCQlzZXQgPSAoc2V0IDw8IChzaXpl b2YoY2hhcikgKiA4KSkgfCAqb3RwX3Y7CgkuLi4KCklzIHRoZSBkeW5hbWljYWxseSBhbGxvY2F0 ZWQgbWVtb3J5IGZvciBvdHBfdiBsZWFrZWQgd2hlbiB0aGUgZnVuY3Rpb24KcmV0dXJucz8KCltT ZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IGlzIHRoZXJl IGEgcG90ZW50aWFsIG91dC1vZi1ib3VuZHMgcmVhZApvbiB0aGUgbnZtZW0gYnVmZmVyIGhlcmU/ CgoJaWYgKCFJU19FUlIob3RwX3YpKSB7CgkJc2V0ID0gKihvdHBfdiArIDEpOwoJLi4uCgpBcmUg d2UgdW5jb25kaXRpb25hbGx5IGFjY2Vzc2luZyB0aGUgc2Vjb25kIGJ5dGUgb2YgdGhlIGJ1ZmZl ciB3aXRob3V0CnZlcmlmeWluZyB0aGF0IHRoZSByZXR1cm5lZCBsZW5ndGggaW4gb3RwX2wgaXMg YXQgbGVhc3QgMiBieXRlcz8KCj4gIAlpZiAocmV0IDwgMCkKPiAtCQlyZXR1cm4gcmV0Owo+ICsJ CWdvdG8gZXJyX3Jlc2V0OwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5n IGlzc3VlLCBidXQgZG8gdGhlIGVycm9yIHBhdGhzIGluIHNwX3VwaHlfaW5pdCgpCmluY29ycmVj dGx5IGNsZWFuIHVwIHJlc291cmNlcyB0aGF0IGZhaWxlZCB0byBpbml0aWFsaXplPwoKSWYgY2xr X3ByZXBhcmVfZW5hYmxlIGZhaWxzLCB0aGUgY29kZSBqdW1wcyB0byBlcnJfY2xrIGFuZCBjYWxs cwpjbGtfZGlzYWJsZV91bnByZXBhcmUgb24gdGhlIHNhbWUgY2xvY2s6Cgpkcml2ZXJzL3BoeS9z dW5wbHVzL3BoeS1zdW5wbHVzLXVzYjIuYzpzcF91cGh5X2luaXQoKSB7CglyZXQgPSBjbGtfcHJl cGFyZV9lbmFibGUodXNicGh5LT5waHlfY2xrKTsKCWlmIChyZXQpCgkJZ290byBlcnJfY2xrOwoK CXJldCA9IHJlc2V0X2NvbnRyb2xfZGVhc3NlcnQodXNicGh5LT5yc3RjKTsKCWlmIChyZXQpCgkJ Z290byBlcnJfcmVzZXQ7CgkuLi4KZXJyX3Jlc2V0OgoJcmVzZXRfY29udHJvbF9hc3NlcnQodXNi cGh5LT5yc3RjKTsKZXJyX2NsazoKCWNsa19kaXNhYmxlX3VucHJlcGFyZSh1c2JwaHktPnBoeV9j bGspOwoKCXJldHVybiByZXQ7Cn0KCldvdWxkIHRoaXMgZGVjcmVtZW50IHRoZSBjbG9jayBmcmFt ZXdvcmsncyByZWZlcmVuY2UgY291bnRzIGZvciBhIGNsb2NrCnRoYXQgd2FzIG5ldmVyIHN1Y2Nl c3NmdWxseSBlbmFibGVkPyBTaW1pbGFybHksIGlmIHJlc2V0X2NvbnRyb2xfZGVhc3NlcnQKZmFp bHMsIGl0IGFzc2VydHMgdGhlIHJlc2V0IHRoYXQgZmFpbGVkIHRvIGRlYXNzZXJ0LgoKLS0gClNh c2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDYx NjE0MjIzNC4xNjkwNDU3LTEtdnVsYWJAaXNjYXMuYWMuY24/cGFydD0xCgotLSAKbGludXgtcGh5 IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK