Re: [PATCH v10 1/5] dt-bindings: clock: airoha: Add PHY binding for Serdes port

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `#phy-cells` property is implicitly allowed for the `econet,en751221-scu` compatible, contradicting the commit message which states it is exclusive to the Airoha AN7581 SoC.
- [Medium] The `airoha,en7581-scu` variant gains a new PHY provider capability, but `#phy-cells` is not added to its required properties, and the schema example is not updated.
--

commit 6d3a613072b0007e76d5846629212f75c8dfc300
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: clock: airoha: Add PHY binding for Serdes port

This commit adds the #phy-cells property for Serdes port selection,
specifying that it is currently supported only for the Airoha AN7581 SoC.

> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index eb24a5687639e..913ddc16182b8 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
[ ... ]
> @@ -65,6 +72,8 @@ allOf:
>          reg:
>            minItems: 2
>  
> +        '#phy-cells': false
> +
>    - if:
>        properties:
>          compatible:

[Severity: Medium]
The commit message states that the #phy-cells property is currently supported
only for the Airoha AN7581 SoC. However, looking at the allOf conditional
block:

  - if:
      properties:
        compatible:
          enum:
            - airoha,en7581-scu
            - econet,en751221-scu

Since econet,en751221-scu shares this block and does not explicitly have
'#phy-cells': false like the previous block, does this implicitly allow the
property for it and contradict the commit message?

[Severity: Medium]
Additionally, since the airoha,en7581-scu variant gains a new PHY provider
capability, should #phy-cells be added to its required properties list?

The example for airoha,en7581-scu in the same file is also missing the
property:

      scuclk: clock-controller@1fb00000 {
        compatible = "airoha,en7581-scu";
        reg = <0x0 0x1fb00000 0x0 0x970>;
              #clock-cells = <1>;
              #reset-cells = <1>;
      };

Would it be better to update the schema to mandate the property and update
the example to include #phy-cells = <1> so incomplete device tree nodes do
not silently pass schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702093812.15918-1-ansuelsmth@gmail.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy