From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A778C43458 for ; Tue, 7 Jul 2026 14:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MLTVbLj/sgr8D52FzPkdRtTWLuFXdxFV7qr1nS5WZu4=; b=KZ7dXOYGqEwh0j PWDeOuhDjbq2nMm2ld6uxnH8sbG29ZXEAWUjNe5ONJCrPSPuh2r70oZ3JQ82VZIT28c8yyYxsJu8P b1O91l+giASWv5fN2bkiGWWGHPiS0zx5GeI3I0mrPd6Mvz+fZN/1lxhpXtTe3Yywa48G3CN1lEQx5 ip0wapcdHcJeFzxp9aQscAPPgc3sSOIM5IktZZeepmZjrprsekdigM7sqeIthgX5O11FNgreT7qIe w9LvG3AP0yvYmXPFklCoidZTZk0qBNLzRC3TE00n5x30efTN/hbFp7pJUtEER+dqsTTXEc1YpslvJ PO6IV0K1Hl+uHzF+px7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6rJ-0000000FBTB-3Nh0; Tue, 07 Jul 2026 14:33:13 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6rI-0000000FBSr-0rYN for linux-phy@lists.infradead.org; Tue, 07 Jul 2026 14:33:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8C3A7600C3; Tue, 7 Jul 2026 14:33:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1D5D1F000E9; Tue, 7 Jul 2026 14:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783434791; bh=WvPCsvkPIm1Ji0A+edy/KwqEoKpNNG0SeqzntHfLNVI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=e141pv7+1m+MaVssYdSEuSStETnCZPwJt9BfNpor7Z492sCVJeY6YiHFBlNjUNuJL Tdk0/JWJfQoH1gUfQ3m9MWZ8OxARamkmxvg4/y7A1+E+iVU/hD+Ts8qc2sVRJAj7Je tr2yAoERDXd+aAbsu6+ssLW0z2S7mtfigLqOnIWCiISf/fYqmT1zU8EDuxYdjPfbOF ag2Rv0zEOHMlW6DWKHamfI1vdM4WBqgeEYIvi71FNr8oPDylNjoD/PLnDhvAxWdYFM q80i7z4rDjmAJj07yVStsfgdxBTws8HSim7dFrZX6sUkq0MhNKK6p8eaHxO7ZlSkpB +6HJF764mrt7w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 05/12] phy: phy-mtk-dp: Implement power_on and power_off PHY callbacks To: "AngeloGioacchino Del Regno" Cc: conor+dt@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, dri-devel@lists.freedesktop.org, olteanv@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20260707141931.191172-6-angelogioacchino.delregno@collabora.com> References: <20260707141931.191172-1-angelogioacchino.delregno@collabora.com> <20260707141931.191172-6-angelogioacchino.delregno@collabora.com> Date: Tue, 07 Jul 2026 14:33:10 +0000 Message-Id: <20260707143310.E1D5D1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtNZWRpdW1d IG10a19kcF9waHlfcG93ZXJfb2ZmKCkgYWJvcnRzIGVhcmx5IG9uIHJlZ21hcF9zZXRfYml0cyBm YWlsdXJlLCBsZWF2aW5nIHRoZSBSWCBjaGFubmVsIHBlcnBldHVhbGx5IGVuYWJsZWQuCi0gW01l ZGl1bV0gTWlzc2luZyBjaGVjayBmb3IgZGV2aWNlX2dldF9tYXRjaF9kYXRhKCkgcmV0dXJuaW5n IE5VTEwgaW4gbXRrX2RwX3BoeV9wcm9iZSwgbGVhZGluZyB0byBhIGNyYXNoIGluIFBIWSBvcGVy YXRpb25zLgotIFtMb3ddIFVuZGVjbGFyZWQgdmFyaWFibGUgJ3JldCcgaW4gbXRrX2RwX3BoeV9w cm9iZSgpIGNhdXNlcyBhIHN0cmljdCBidWlsZCBmYWlsdXJlLgoKUHJlLWV4aXN0aW5nIGlzc3Vl czoKLSBbSGlnaF0gRGVyZWZlcmVuY2luZyBkZXYtPnBsYXRmb3JtX2RhdGEgd2l0aG91dCBjaGVj a2luZyBmb3IgTlVMTCBpbiBtdGtfZHBfcGh5X2xlZ2FjeV9wcm9iZSBsZWFkcyB0byBhIGtlcm5l bCBwYW5pYy4KLS0KCi0tLSBQYXRjaCBbNV06IFtQQVRDSCB2MiAwNS8xMl0gcGh5OiBwaHktbXRr LWRwOiBJbXBsZW1lbnQgcG93ZXJfb24gYW5kIHBvd2VyX29mZiBQSFkgY2FsbGJhY2tzIC0tLQpj b21taXQgZGIyNzM4Mzg3ODNmMWVhMzQxZDc3Mjg2NjAxODM5NjZhZDNjNGQxNgpBdXRob3I6IEFu Z2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxh Ym9yYS5jb20+CgpwaHk6IHBoeS1tdGstZHA6IEltcGxlbWVudCBwb3dlcl9vbiBhbmQgcG93ZXJf b2ZmIFBIWSBjYWxsYmFja3MKClRoaXMgY29tbWl0IGFkZHMgLnBvd2VyX29uKCkgYW5kIC5wb3dl cl9vZmYoKSBjYWxsYmFja3MgdG8gdGhlIERpc3BsYXlQb3J0ClBIWSBvcGVyYXRpb25zLiBUaGVz ZSBhZGRpdGlvbnMgYWxsb3cgdGhlIERpc3BsYXlQb3J0IGRyaXZlciB0byB1c2UgdGhlCnBoeV9w b3dlcl9vbigpIGFuZCBwaHlfcG93ZXJfb2ZmKCkgQVBJcyBpbnN0ZWFkIG9mIGhhcmRjb2RlZCBy ZWdpc3RlciB3cml0ZXMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHkt bXRrLWRwLmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWRwLmMKPiBpbmRleCA5MTVm MTQ4MzI1YzQ5Li4wYzNmMDY3OTE2MTNhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L21lZGlh dGVrL3BoeS1tdGstZHAuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstZHAu YwoKWyAuLi4gXQoKPiBAQCAtMjAwLDYgKzIyNSw1OSBAQCBzdGF0aWMgaW50IG10a19kcF9waHlf Y29uZmlndXJlKHN0cnVjdCBwaHkgKnBoeSwgdW5pb24gcGh5X2NvbmZpZ3VyZV9vcHRzICpvcHRz KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgbXRrX2RwX3BoeV9wb3dlcl9v bihzdHJ1Y3QgcGh5ICpwaHkpCj4gK3sKClsgLi4uIF0KCj4gK3N0YXRpYyBpbnQgbXRrX2RwX3Bo eV9wb3dlcl9vZmYoc3RydWN0IHBoeSAqcGh5KQo+ICt7Cj4gKwlzdHJ1Y3QgbXRrX2RwX3BoeSAq ZHBfcGh5ID0gcGh5X2dldF9kcnZkYXRhKHBoeSk7Cj4gKwljb25zdCBzdHJ1Y3QgbXRrX2RwX3Bo eV9wZGF0YSAqcGRhdGEgPSBkcF9waHktPnBkYXRhOwo+ICsJY29uc3QgdTggKnJlZ3NfZGlnID0g cGRhdGEtPnJlZ3NfZGlnX2dsYjsKPiArCWNvbnN0IHU4ICpyZWdzX2FuYSA9IHBkYXRhLT5yZWdz X2FuYV9nbGI7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXJldCA9IHJlZ21hcF9zZXRfYml0cyhkcF9w aHktPnJlZ21hcCwKPiArCQkJICAgICAgcGRhdGEtPm9mZl9hbmFfZ2xiICsgcmVnc19hbmFbRFBf UEhZQV9HTEJfRk9SQ0VfQ1RSTF8xXSwKPiArCQkJICAgICAgQ0tNX0NLVFgwX0VOX0ZPUkNFX01P REUpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0OwoKW1NldmVyaXR5OiBNZWRpdW1dCklm IHJlZ21hcF9zZXRfYml0cygpIGZhaWxzIGFuZCByZXR1cm5zIGVhcmx5LCBjb3VsZCB0aGlzIGxl YXZlIHRoZSBoYXJkd2FyZQpSWCBjaGFubmVsIHBvd2VyZWQgb24gaW5kZWZpbml0ZWx5PyAKClRl YXJkb3duIHN0ZXBzIHVzdWFsbHkgcHJvY2VlZCBvbiBhIGJlc3QtZWZmb3J0IGJhc2lzIHRvIGVu c3VyZSBzdWJzZXF1ZW50CmhhcmR3YXJlIGRpc2FibGUgb3BlcmF0aW9ucyBhcmUgZXhlY3V0ZWQu Cgo+ICsKPiArCS8qIERpc2FibGUgUlggKi8KPiArCXJldCA9IHJlZ21hcF93cml0ZShkcF9waHkt PnJlZ21hcCwKPiArCQkJICAgcGRhdGEtPm9mZl9kaWdfZ2xiICsgcmVnc19kaWdbRFBfUEhZRF9B VVhfUlhfQ1RMXSwgMCk7CgpbIC4uLiBdCgo+IEBAIC0zMTksOCArMzk5LDEwIEBAIHN0YXRpYyBp bnQgbXRrX2RwX3BoeV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICB9Cgpb U2V2ZXJpdHk6IExvd10KRG9lcyB0aGlzIGNvZGUgY2F1c2UgYSBidWlsZCBmYWlsdXJlPwoKZHJp dmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1kcC5jOm10a19kcF9waHlfcHJvYmUoKSB7CiAgICAu Li4KICAgIHJldCA9IGRldm1fcG1fcnVudGltZV9lbmFibGUoZGV2KTsKICAgIGlmIChyZXQpCiAg ICAgICAgcmV0dXJuIHJldDsKICAgIC4uLgp9CgpJdCBhcHBlYXJzIHRoZSB2YXJpYWJsZSAncmV0 JyBpcyB1c2VkIGJ1dCBub3QgZGVjbGFyZWQuCgpbU2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyB0aGlz IGNvZGUgbmVlZCBhIE5VTEwgY2hlY2sgZm9yIHRoZSByZXR1cm4gdmFsdWUgb2YKZGV2aWNlX2dl dF9tYXRjaF9kYXRhKCk/Cgpkcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWRwLmM6bXRrX2Rw X3BoeV9wcm9iZSgpIHsKICAgIC4uLgogICAgZHBfcGh5LT5wZGF0YSA9IGRldmljZV9nZXRfbWF0 Y2hfZGF0YShkZXYpOwoKICAgIHBoeSA9IGRldm1fcGh5X2NyZWF0ZShkZXYsIE5VTEwsICZtdGtf ZHBfcGh5X2Rldl9vcHMpOwogICAgLi4uCn0KCklmIHRoZSBkZXZpY2UgaXMgYm91bmQgbWFudWFs bHkgdmlhIHN5c2ZzIGFuZCB0aGUgY29tcGF0aWJsZSBzdHJpbmcgZG9lc24ndAptYXRjaCwgZGV2 aWNlX2dldF9tYXRjaF9kYXRhKCkgY291bGQgcmV0dXJuIE5VTEwsIHdoaWNoIG1pZ2h0IGNyYXNo IHRoZQprZXJuZWwgaW4gc3Vic2VxdWVudCBvcGVyYXRpb25zIGxpa2UgbXRrX2RwX3BoeV9wb3dl cl9vbigpLgoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBi dXQgZG9lcyBkZXJlZmVyZW5jaW5nIGRldi0+cGxhdGZvcm1fZGF0YQp3aXRob3V0IGNoZWNraW5n IGZvciBOVUxMIGluIG10a19kcF9waHlfbGVnYWN5X3Byb2JlKCkgbGVhZCB0byBhIGNyYXNoPwoK ZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1kcC5jOm10a19kcF9waHlfbGVnYWN5X3Byb2Jl KCkgewogICAgLi4uCiAgICBkcF9waHktPnJlZ21hcCA9ICooc3RydWN0IHJlZ21hcCAqKilkZXYt PnBsYXRmb3JtX2RhdGE7CiAgICBpZiAoIWRwX3BoeS0+cmVnbWFwKQogICAgICAgIHJldHVybiBk ZXZfZXJyX3Byb2JlKGRldiwgLUVJTlZBTCwgIk5vIHBsYXRmb3JtIGRhdGEgYXZhaWxhYmxlXG4i KTsKICAgIC4uLgp9CgpJZiBwZGV2LT5kZXYucGxhdGZvcm1fZGF0YSBpcyBOVUxMLCB0aGUgYmxp bmQgcG9pbnRlciBkZXJlZmVyZW5jZSBoYXBwZW5zCmJlZm9yZSB0aGUgc2FuaXR5IGNoZWNrIGlz IHJlYWNoZWQuCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8j L3BhdGNoc2V0LzIwMjYwNzA3MTQxOTMxLjE5MTE3Mi0xLWFuZ2Vsb2dpb2FjY2hpbm8uZGVscmVn bm9AY29sbGFib3JhLmNvbT9wYXJ0PTUKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4 LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=