Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY - sashiko-bot

From: sashiko-bot@kernel.org
To: "Icenowy Zheng" <zhengxingda@iscas.ac.cn>
Cc: vkoul@kernel.org, conor+dt@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY
Date: Thu, 23 Jul 2026 08:47:57 +0000	[thread overview]
Message-ID: <20260723084759.3BBF81F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723084316.3573714-2-zhengxingda@iscas.ac.cn>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The 'reg' property is omitted from the 'required' list for a memory-mapped PHY.
- [Medium] The 'avdd33-usb3-supply' is omitted from the 'required' list based on software limitations rather than hardware description.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY ---
commit 91b4840ee15364137facb1905580d4df2ba57663
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>

dt-bindings: phy: add binding for T-Head TH1520 USB PHY

This commit adds a device tree binding for the T-Head TH1520 USB PHY,
which is a Synopsys USB 3.0 FemtoPHY with custom glue logic.

> Changes in v2:
> - Lifted avdd33-usb3-supply from required properties list. Because of
>   this the R-b from Conor isn't added yet for reconfirmation. (The
>   related regulator isn't yet controllable because no driver is
>   available.)

[Severity: Medium]
Since device tree bindings must describe hardware independently of software
state, shouldn't this physical supply be required if the hardware mandates it?

Software limitations are typically handled in the board DTS (e.g., using a
fixed-regulator), rather than compromising the generic hardware schema.

> diff --git a/Documentation/devicetree/bindings/phy/thead,th1520-usb-phy.yaml b/Documentation/devicetree/bindings/phy/thead,th1520-usb-phy.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/thead,th1520-usb-phy.yaml
[ ... ]
> +required:
> +  - compatible
> +  - "#phy-cells"
> +  - clocks
> +  - clock-names
> +  - resets
> +  - reset-names

[Severity: Medium]
Since this is a memory-mapped PHY, shouldn't the reg property be included in
the required list?

Without it, device tree nodes missing the reg property will silently pass
schema validation, leading to incomplete hardware descriptions that fail at
runtime.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723084316.3573714-1-zhengxingda@iscas.ac.cn?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy