Re: [PATCH v9 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema omits the `resets` property while restricting additional properties, which will cause DT validation failures.
--

--- Patch [1]: [PATCH v9 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller ---
commit aac89094dd71d6499e06c62f3e14a6df6d5efac5
Author: Stefan Dösinger <stefandoesinger@gmail.com>

dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller

This commit adds the device tree binding schema for the ZTE zx297520v3 top
clock and reset controller. It defines clocks, resets, and PHY properties
for the topcrm node, as well as a syscon reboot child node.

> diff --git a/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - const: zte,zx297520v3-topcrm
> +      - const: syscon
[ ... ]
> +  "#reset-cells":
> +    const: 1
> +
> +  reboot:
> +    type: object
> +    $ref: /schemas/power/reset/syscon-reboot.yaml#
> +    unevaluatedProperties: false
> +    description:
> +      Reboot method for the SoC.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +  - interrupt-names
> +  - reboot
> +  - "#clock-cells"
> +  - "#phy-cells"
> +  - "#reset-cells"
> +
> +additionalProperties: false

[Severity: Medium]
Should the resets property be explicitly added to the properties block?

The commit message mentions a self-referencing reset property being used on
this node, but because additionalProperties is set to false, omitting resets
from the schema will cause dtbs_check to fail when validating device trees
that include it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-zx29clk-v9-0-d05530d85d28@gmail.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy