From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5357BC55184 for ; Tue, 4 Aug 2026 15:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zq6YrrnI0vkAwsTL0mzOh7SAxcpyVSpjqX+y7/X2AzE=; b=G11oMGApRsMYdP KYWG1wRIAHAJSYYrEdxqT5Lw1FEkwkQvtnCEVCgRi7nKmB69mvt0T8d9mHYKYyafO5napQtKbtsMp MENt7ODQyfNCS8fvYcw8DvNxheQkJeGmLhDPoaNYUuuNhpHXmdVxwZSgpKhhRQzjadEYvmTPWMMcK reuDapVSS3LTCWAl9SczmlRniBN24+UbIv7cGtur+wirhz0FSnvw3wOAnmOaIS83d90i8nZILhY8P sSoocSpELW044AZLIrvfSmunJ9avFuLlTr7abtCGvbMT3fnMdDmsp+XC+ieqtl3r5j83+5Ipawgh4 YZG2qT/7F1lHFmOaajqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrHXp-00000002Fsi-2s0i; Tue, 04 Aug 2026 15:59:09 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrHXo-00000002FsQ-1yvr for linux-phy@lists.infradead.org; Tue, 04 Aug 2026 15:59:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 901C460A75; Tue, 4 Aug 2026 15:59:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEBAF1F000E9; Tue, 4 Aug 2026 15:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785859147; bh=RFPl7KoBGs2M2IOPGst5iLfx9s5X088SeFqClnJFRmQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=b5bA8EXTLbt++HTVVYmR0MNcaNyGqHeYDb2TK2w9XrxF/o+YlsfiEmW9OmfpGp0sA f6GGLVvU9ZD2/8gz5EgGCeyRcKhpS344bjIKyqCRON+csK0L/8349JqKWH/M5iFC66 iL3Km+VjCCTAW2Q7Y4z7ZBNBRf4vGWQFQcH22EFS4rH1Wpu4dBIhMapyJOhgn/10X6 9bRBQ8AwzTG576XX13SdBorTuI2kh26EkhlxUu+3zK+6BNJYhePbSYhkeyIC87yTKe hI2I2MIhmVryA5CIHNn6fqc2IduDtqaIYCUYDhOno2J4I6GxXSmqm1zSuosJE4zCBQ tKoSxd3XUqM6w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/3] phy: renesas: rcar-gen2: Use dev_err_probe() in probe To: "Felix Gu" Cc: linux-phy@lists.infradead.org, wsa+renesas@sang-engineering.com, olteanv@gmail.com, vkoul@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260804-rcar-gen2-v2-3-829cb84112ca@gmail.com> References: <20260804-rcar-gen2-v2-0-829cb84112ca@gmail.com> <20260804-rcar-gen2-v2-3-829cb84112ca@gmail.com> Date: Tue, 04 Aug 2026 15:59:06 +0000 Message-Id: <20260804155906.EEBAF1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUaGUgUEhZIHByb3ZpZGVyIGlzIHJlZ2lzdGVyZWQgYmVmb3JlIHRoZSBkcml2ZXIg ZGF0YSBpcyBzZXQsIGNyZWF0aW5nIGEgcmFjZSB3aW5kb3cgd2hlcmUgUEhZIGxvb2t1cCBjYW4g ZmFpbC4KLSBbSGlnaF0gVGhlIGRyaXZlciBzYXZlcyBhIHNjb3BlZCBkZXZpY2Ugbm9kZSBwb2lu dGVyIGludG8gYSBwZXJzaXN0ZW50IHN0cnVjdHVyZSB3aXRob3V0IGluY3JlbWVudGluZyBpdHMg cmVmZXJlbmNlIGNvdW50LCBsZWFkaW5nIHRvIGEgZGFuZ2xpbmcgcG9pbnRlci4KLSBbSGlnaF0g QSBUaW1lLU9mLUNoZWNrIHRvIFRpbWUtT2YtVXNlIChUT0NUT1UpIHJhY2UgY29uZGl0aW9uIHdp dGggZGV2aWNlIHRyZWUgbW9kaWZpY2F0aW9ucyBjYW4gbGVhZCB0byBhbiBhcnJheSBvdXQtb2Yt Ym91bmRzIGFjY2Vzcy4KLS0KCi0tLSBQYXRjaCBbM106IFtQQVRDSCB2MiAzLzNdIHBoeTogcmVu ZXNhczogcmNhci1nZW4yOiBVc2UgZGV2X2Vycl9wcm9iZSgpIGluIHByb2JlIC0tLQpjb21taXQg NzA5ZDliODIxODA4N2FiYzY1MjZiMjliMzgyODU2ZWI1M2NjYjNiYQpBdXRob3I6IEZlbGl4IEd1 IDx1c3RjLmd1QGdtYWlsLmNvbT4KCiAgICBwaHk6IHJlbmVzYXM6IHJjYXItZ2VuMjogVXNlIGRl dl9lcnJfcHJvYmUoKSBpbiBwcm9iZQogICAgCiAgICBDb252ZXJ0IHRoZSBlcnJvciBwYXRocyBp biByY2FyX2dlbjJfcGh5X3Byb2JlKCkgdG8gZGV2X2Vycl9wcm9iZSgpLgoKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9waHkvcmVuZXNhcy9waHktcmNhci1nZW4yLmMgYi9kcml2ZXJzL3BoeS9yZW5l c2FzL3BoeS1yY2FyLWdlbjIuYwo+IGluZGV4IGIxODcyN2VkNDFhMTAuLjU4MWY2NzY4ZTJiYjIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcmVuZXNhcy9waHktcmNhci1nZW4yLmMKPiArKysg Yi9kcml2ZXJzL3BoeS9yZW5lc2FzL3BoeS1yY2FyLWdlbjIuYwpbIC4uLiBdCj4gQEAgLTM4OCwx MCArMzg0LDkgQEAgc3RhdGljIGludCByY2FyX2dlbjJfcGh5X3Byb2JlKHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2UgKnBkZXYpCj4gIAkJY2hhbm5lbC0+c2VsZWN0ZWRfcGh5ID0gLTE7CgpbU2V2ZXJp dHk6IEhpZ2hdClRoaXMgaXNuJ3QgYSBidWcgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNoLCBidXQg Y291bGQgdGhlIGFzc2lnbm1lbnQgdG8KY2hhbm5lbC0+b2Zfbm9kZSBqdXN0IGFib3ZlIHRoaXMg bGluZSByZXN1bHQgaW4gYSBkYW5nbGluZyBwb2ludGVyPwoKTG9va2luZyBhdCByY2FyX2dlbjJf cGh5X3Byb2JlKCksIHRoZSBsb29wIHVzZXMKZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZV9zY29wZWQo ZGV2LT5vZl9ub2RlLCBucCkgd2hpY2ggYXV0b21hdGljYWxseQpkZWNyZW1lbnRzIHRoZSByZWZl cmVuY2UgY291bnQgb2YgbnAgYXQgdGhlIGVuZCBvZiBlYWNoIGl0ZXJhdGlvbi4KClNpbmNlIGNo YW5uZWwtPm9mX25vZGUgPSBucCBzdG9yZXMgdGhpcyBwb2ludGVyIGludG8gdGhlIHBlcnNpc3Rl bnQKY2hhbm5lbCBzdHJ1Y3R1cmUgd2l0aG91dCBjYWxsaW5nIG9mX25vZGVfZ2V0KG5wKSwgd291 bGRuJ3QgdGhpcyBsZWF2ZQpjaGFubmVsLT5vZl9ub2RlIHBvaW50aW5nIHRvIGZyZWVkIG1lbW9y eSBvbmNlIHRoZSBzY29wZSBlbmRzPwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzbid0IGEgYnVn IGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IGlzIHRoZXJlIGEgcmlzayBvZiBhbgpvdXQt b2YtYm91bmRzIGFycmF5IGFjY2VzcyBpbiB0aGlzIGxvb3A/CgpFYXJsaWVyIGluIHJjYXJfZ2Vu Ml9waHlfcHJvYmUoKSwgZHJ2LT5jaGFubmVscyBpcyBhbGxvY2F0ZWQgYmFzZWQgb24Kb2ZfZ2V0 X2NoaWxkX2NvdW50KCk6CgogICAgZHJ2LT5udW1fY2hhbm5lbHMgPSBvZl9nZXRfY2hpbGRfY291 bnQoZGV2LT5vZl9ub2RlKTsKICAgIGRydi0+Y2hhbm5lbHMgPSBkZXZtX2tjYWxsb2MoZGV2LCBk cnYtPm51bV9jaGFubmVscywgLi4uKTsKCklmIGEgZHluYW1pYyBkZXZpY2UgdHJlZSBvdmVybGF5 IGFkZHMgYSBjaGlsZCBub2RlIGNvbmN1cnJlbnRseSBiZWZvcmUgb3IKZHVyaW5nIHRoZSBmb3Jf ZWFjaF9jaGlsZF9vZl9ub2RlX3Njb3BlZCgpIGxvb3AsIHRoZSBsb29wIHdpbGwgaXRlcmF0ZQpt b3JlIHRpbWVzIHRoYW4gZHJ2LT5udW1fY2hhbm5lbHMuIFdvdWxkIHRoZSBhc3NpZ25tZW50CmNo YW5uZWwgPSBkcnYtPmNoYW5uZWxzICsgaSB0aGVuIHdyaXRlIHBhc3QgdGhlIGVuZCBvZiB0aGUg YWxsb2NhdGlvbj8KCj4gIAkJZXJyb3IgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMihucCwgInJlZyIs ICZjaGFubmVsX251bSk7Cj4gLQkJaWYgKGVycm9yIHx8IGNoYW5uZWxfbnVtID49IGRhdGEtPm51 bV9jaGFubmVscykgewo+IC0JCQlkZXZfZXJyKGRldiwgIkludmFsaWQgXCJyZWdcIiBwcm9wZXJ0 eVxuIik7Cj4gLQkJCXJldHVybiBlcnJvciA/OiAtRUlOVkFMOwo+IC0JCX0KPiArCQlpZiAoZXJy b3IgfHwgY2hhbm5lbF9udW0gPj0gZGF0YS0+bnVtX2NoYW5uZWxzKQo+ICsJCQlyZXR1cm4gZGV2 X2Vycl9wcm9iZShkZXYsIGVycm9yID86IC1FSU5WQUwsCj4gKwkJCQkJICAgICAiSW52YWxpZCBc InJlZ1wiIHByb3BlcnR5XG4iKTsKPiAgCQljaGFubmVsLT5zZWxlY3RfbWFzayA9IHNlbGVjdF9t YXNrW2NoYW5uZWxfbnVtXTsKWyAuLi4gXQo+IEBAIC00MTQsMTAgKzQwOCw5IEBAIHN0YXRpYyBp bnQgcmNhcl9nZW4yX3BoeV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJ fQo+ICAKPiAgCXByb3ZpZGVyID0gZGV2bV9vZl9waHlfcHJvdmlkZXJfcmVnaXN0ZXIoZGV2LCBy Y2FyX2dlbjJfcGh5X3hsYXRlKTsKPiAtCWlmIChJU19FUlIocHJvdmlkZXIpKSB7Cj4gLQkJZGV2 X2VycihkZXYsICJGYWlsZWQgdG8gcmVnaXN0ZXIgUEhZIHByb3ZpZGVyXG4iKTsKPiAtCQlyZXR1 cm4gUFRSX0VSUihwcm92aWRlcik7Cj4gLQl9Cj4gKwlpZiAoSVNfRVJSKHByb3ZpZGVyKSkKPiAr CQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBUUl9FUlIocHJvdmlkZXIpLAo+ICsJCQkJICAg ICAiRmFpbGVkIHRvIHJlZ2lzdGVyIFBIWSBwcm92aWRlclxuIik7Cj4gIAo+ICAJZGV2X3NldF9k cnZkYXRhKGRldiwgZHJ2KTsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpc24ndCBhIGJ1ZyBpbnRy b2R1Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCBkb2VzIHRoZSByZWdpc3RyYXRpb24gb3JkZXIKY3Jl YXRlIGEgcmFjZSBjb25kaXRpb24/CgpUaGUgUEhZIHByb3ZpZGVyIGlzIHJlZ2lzdGVyZWQgdmlh IGRldm1fb2ZfcGh5X3Byb3ZpZGVyX3JlZ2lzdGVyKCkgYmVmb3JlCmRldl9zZXRfZHJ2ZGF0YShk ZXYsIGRydikgaXMgY2FsbGVkLgoKSWYgYSBjb25jdXJyZW50IGRlZmVycmVkIHByb2JlIG9yIG1v ZHVsZSBsb2FkIGNhbGxzIHJjYXJfZ2VuMl9waHlfeGxhdGUoKQpkdXJpbmcgdGhpcyB3aW5kb3cs IGl0IHdpbGwgdHJ5IHRvIGFjY2VzcyBkcml2ZXIgZGF0YSB0aGF0IGhhc24ndCBiZWVuIHNldAp5 ZXQuIFNob3VsZCBkZXZfc2V0X2RydmRhdGEoKSBiZSBjYWxsZWQgYmVmb3JlIGV4cG9zaW5nIHRo ZSBQSFkgcHJvdmlkZXIKdG8gdGhlIHN5c3RlbT8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBo dHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4MDQtcmNhci1nZW4yLXYyLTAtODI5 Y2I4NDExMmNhQGdtYWlsLmNvbT9wYXJ0PTMKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0Cmxp bnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=