From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Xu Yang <xu.yang_2@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Peter Chen <peter.chen@kernel.org>,
Pavankumar Kondeti <quic_pkondeti@quicinc.com>,
Stephen Boyd <stephen.boyd@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Peter Chen <peter.chen@nxp.com>
Subject: [PATCH 07/10] usb: chipidea: msm: do not force the TX FIFO idle on HSIC instances
Date: Mon, 10 Aug 2026 18:42:11 +0300 [thread overview]
Message-ID: <20260810-msm8974-usb-hsic-v1-7-e5f93ea76ffa@oss.qualcomm.com> (raw)
In-Reply-To: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com>
The controller reset handler unconditionally clears
GENCONFIG[TXFIFO_IDLE_FORCE_DIS] as a workaround for an RX buffer
collision issue. The vendor HSIC host driver never applies this
workaround on the HSIC instances and leaves the bit at its power-on
default (set), so clearing it makes the HSIC instance diverge from the
known-working configuration.
Skip the workaround for HSIC instances, like the neighbouring
GENCONFIG_2 write already does.
Fixes: 47654a162081 ("usb: chipidea: msm: Restore wrapper settings after reset")
Assisted-by: Claude:claude-fable-5
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/usb/chipidea/ci_hdrc_msm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
index 9a9410a814e5..69be194f8e27 100644
--- a/drivers/usb/chipidea/ci_hdrc_msm.c
+++ b/drivers/usb/chipidea/ci_hdrc_msm.c
@@ -108,8 +108,9 @@ static int ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event)
hw_write_id_reg(ci, HS_PHY_AHB_MODE, 0xffffffff, 0x8);
/* workaround for rx buffer collision issue */
- hw_write_id_reg(ci, HS_PHY_GENCONFIG,
- HS_PHY_TXFIFO_IDLE_FORCE_DIS, 0);
+ if (!msm_ci->hsic)
+ hw_write_id_reg(ci, HS_PHY_GENCONFIG,
+ HS_PHY_TXFIFO_IDLE_FORCE_DIS, 0);
if (!msm_ci->hsic)
hw_write_id_reg(ci, HS_PHY_GENCONFIG_2,
--
2.47.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-08-10 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 15:42 [PATCH 00/10] ARM: qcom: msm8974: enable HSIC controller Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 01/10] dt-bindings: pinctrl: qcom,tlmm-common: allow functions on the HSIC pins Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 02/10] dt-bindings: usb: ci-hdrc-usb2: allow the HSIC PHY as the ULPI child Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 03/10] phy: qcom-usb-hsic: do not run the sleep calibration clock Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 04/10] phy: qcom-usb-hsic: engage HSIC mode from phy_calibrate() Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 05/10] usb: chipidea: msm: support the HSIC asynchronous wakeup interrupt Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 06/10] usb: chipidea: msm: keep the glue device runtime-active Dmitry Baryshkov
2026-08-10 15:42 ` Dmitry Baryshkov [this message]
2026-08-10 15:42 ` [PATCH 08/10] usb: chipidea: host: calibrate the PHY after starting the host Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 09/10] ARM: dts: qcom: msm8974: add the HSIC USB controller Dmitry Baryshkov
2026-08-10 15:42 ` [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable the HSIC host Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810-msm8974-usb-hsic-v1-7-e5f93ea76ffa@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregkh@suse.de \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=peter.chen@kernel.org \
--cc=peter.chen@nxp.com \
--cc=quic_pkondeti@quicinc.com \
--cc=robh@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=vkoul@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox